* [PATCH 1/2] [media] pxa_camera: make soc_mbus_xlate_by_fourcc() static
@ 2016-09-09 14:00 Mauro Carvalho Chehab
2016-09-09 14:00 ` [PATCH 2/2] [media] pxa_camera: remove an unused structure pointer Mauro Carvalho Chehab
2016-09-18 18:47 ` [PATCH 1/2] [media] pxa_camera: make soc_mbus_xlate_by_fourcc() static Robert Jarzmik
0 siblings, 2 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2016-09-09 14:00 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Linux Media Mailing List,
Mauro Carvalho Chehab, Mauro Carvalho Chehab, Robert Jarzmik,
Hans Verkuil, Guennadi Liakhovetski, Arnd Bergmann
As warned by smatch:
drivers/media/platform/pxa_camera.c:283:39: warning: no previous prototype for 'soc_mbus_xlate_by_fourcc' [-Wmissing-prototypes]
const struct soc_camera_format_xlate *soc_mbus_xlate_by_fourcc(
^~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
drivers/media/platform/pxa_camera.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c
index c2d1ceaea49b..733677f06cb4 100644
--- a/drivers/media/platform/pxa_camera.c
+++ b/drivers/media/platform/pxa_camera.c
@@ -280,8 +280,9 @@ static const char *pxa_cam_driver_description = "PXA_Camera";
/*
* Format translation functions
*/
-const struct soc_camera_format_xlate *soc_mbus_xlate_by_fourcc(
- struct soc_camera_format_xlate *user_formats, unsigned int fourcc)
+static const struct soc_camera_format_xlate
+*soc_mbus_xlate_by_fourcc(struct soc_camera_format_xlate *user_formats,
+ unsigned int fourcc)
{
unsigned int i;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] [media] pxa_camera: remove an unused structure pointer
2016-09-09 14:00 [PATCH 1/2] [media] pxa_camera: make soc_mbus_xlate_by_fourcc() static Mauro Carvalho Chehab
@ 2016-09-09 14:00 ` Mauro Carvalho Chehab
2016-09-18 18:48 ` Robert Jarzmik
2016-09-18 18:47 ` [PATCH 1/2] [media] pxa_camera: make soc_mbus_xlate_by_fourcc() static Robert Jarzmik
1 sibling, 1 reply; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2016-09-09 14:00 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Linux Media Mailing List,
Mauro Carvalho Chehab, Mauro Carvalho Chehab, Robert Jarzmik,
Hans Verkuil, Guennadi Liakhovetski, Arnd Bergmann
As reported by smatch:
drivers/media/platform/pxa_camera.c: In function 'pxa_dma_start_channels':
drivers/media/platform/pxa_camera.c:457:21: warning: variable 'active' set but not used [-Wunused-but-set-variable]
struct pxa_buffer *active;
^~~~~~
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
drivers/media/platform/pxa_camera.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c
index 733677f06cb4..11478364c6d6 100644
--- a/drivers/media/platform/pxa_camera.c
+++ b/drivers/media/platform/pxa_camera.c
@@ -455,9 +455,6 @@ static void pxa_videobuf_set_actdma(struct pxa_camera_dev *pcdev,
static void pxa_dma_start_channels(struct pxa_camera_dev *pcdev)
{
int i;
- struct pxa_buffer *active;
-
- active = pcdev->active;
for (i = 0; i < pcdev->channels; i++) {
dev_dbg(pcdev_to_dev(pcdev),
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] [media] pxa_camera: remove an unused structure pointer
2016-09-09 14:00 ` [PATCH 2/2] [media] pxa_camera: remove an unused structure pointer Mauro Carvalho Chehab
@ 2016-09-18 18:48 ` Robert Jarzmik
0 siblings, 0 replies; 4+ messages in thread
From: Robert Jarzmik @ 2016-09-18 18:48 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Mauro Carvalho Chehab, Hans Verkuil, Guennadi Liakhovetski,
Arnd Bergmann
Mauro Carvalho Chehab <mchehab@s-opensource.com> writes:
> As reported by smatch:
>
> drivers/media/platform/pxa_camera.c: In function 'pxa_dma_start_channels':
> drivers/media/platform/pxa_camera.c:457:21: warning: variable 'active' set but not used [-Wunused-but-set-variable]
> struct pxa_buffer *active;
> ^~~~~~
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] [media] pxa_camera: make soc_mbus_xlate_by_fourcc() static
2016-09-09 14:00 [PATCH 1/2] [media] pxa_camera: make soc_mbus_xlate_by_fourcc() static Mauro Carvalho Chehab
2016-09-09 14:00 ` [PATCH 2/2] [media] pxa_camera: remove an unused structure pointer Mauro Carvalho Chehab
@ 2016-09-18 18:47 ` Robert Jarzmik
1 sibling, 0 replies; 4+ messages in thread
From: Robert Jarzmik @ 2016-09-18 18:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Mauro Carvalho Chehab, Hans Verkuil, Guennadi Liakhovetski,
Arnd Bergmann
Mauro Carvalho Chehab <mchehab@s-opensource.com> writes:
> As warned by smatch:
>
> drivers/media/platform/pxa_camera.c:283:39: warning: no previous prototype for 'soc_mbus_xlate_by_fourcc' [-Wmissing-prototypes]
> const struct soc_camera_format_xlate *soc_mbus_xlate_by_fourcc(
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-18 18:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-09 14:00 [PATCH 1/2] [media] pxa_camera: make soc_mbus_xlate_by_fourcc() static Mauro Carvalho Chehab
2016-09-09 14:00 ` [PATCH 2/2] [media] pxa_camera: remove an unused structure pointer Mauro Carvalho Chehab
2016-09-18 18:48 ` Robert Jarzmik
2016-09-18 18:47 ` [PATCH 1/2] [media] pxa_camera: make soc_mbus_xlate_by_fourcc() static Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).