Re: [PATCH 02/15] dma-buf: specify usage while adding fences to dma_resv obj v7

Javier Martinez Canillas
2022-04-07T13:17:00Z

On 4/7/22 15:13, Christian König wrote:
> Am 07.04.22 um 15:08 schrieb Javier Martinez Canillas:
>> Hello Christian,
>>
>> On 4/7/22 10:59, Christian König wrote:
>>> Instead of distingting between shared and exclusive fences specify
>>> the fence usage while adding fences.
>>>
>>> Rework all drivers to use this interface instead and deprecate the old one.
>>>
>> This patch broke compilation for the vc4 DRM driver.
>
> My apologies for that. I've tried really hard to catch all cases, but
> looks like I missed some.
>

No worries, I know that's not easy to get all callers when doing these
subsystem wide changes.

>> I've this patch locally
>> which seems to work but I don't know enough about the fence API to know if
>> is correct.
>>
>> If you think is the proper fix then I can post it as a patch.
>
> Yes, that patch looks absolutely correct to me.
>

Thanks for looking at it.

> Feel free to add an Reviewed-by: Christian König
> <christian.koenig@amd.com> and CC me so that I can push it to
> drm-misc-next ASAP.
>

I can also do it after posting (just to get a proper Link: tag with dim)

Already have another set that wanted to push but found this issue after
doing a build test before pushing.

> Thanks,
> Christian.
>
--
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat