From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3892B36C9D5 for ; Wed, 3 Jun 2026 05:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780464396; cv=none; b=VMhDYm6A0+ZdMj2NnNx7EF2atMQ3+hmSXZhZin8PFB6kxmAwnkfllPVFlAD1YCrwdxyBMhbtU36q8PFtnKEIflhM20UE6U8xxKyPRe7OAFdPbm8GnS/uCRElrde7P/H7nhHfKB85PmdBE/n/eI0HjilzFsg2k7gJFjjJK3TUxWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780464396; c=relaxed/simple; bh=YJckN7k5QaN4smziFaJ4SRbWkD8f7N5Q6iRQlgaG3Kg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p9KFqoE4WFrJVaWRPTCK5JXg6/q4vXp1ideOg1CwJQ14KZ0ULXPShmmcBpMslUu9vhUVcmm+Wm++NBJxQZq3VmfuCV1zLCfDub4ca54PNWe0IX9DTgd7Z07iyu04QVgxXVG6rpOyolXU6zdmBKmAl6Wabtyvd4/bA+yRcxmPFYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oWTLogLX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EPsyCpVP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oWTLogLX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EPsyCpVP" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 652MSPb11638302 for ; Wed, 3 Jun 2026 05:26:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= m3YqEw6zmQVetKx6FqU85A3xswC4mhkwqjLvA/EaE9Y=; b=oWTLogLXHlBUieIp QeaN0yv1pxWQz460jHGVfJwyvC+ISSABgzq/NU2K2JZBMhdjIwkPZ7OAynwQWpsw sT5TrLSuvInxSSDqeiO5NPvdKlbpBa8ISSRRHoaF0TlRVhRMHwK0j/pDBqjah6R/ oWN/446gEL9YJikmBnHmsG+zEQm+RUVhJcvwh8Hx+4LyaD1Rh8sfcCxWnMxy8N4O 9jbHEnn3UfV45GWYcRJUqJmZiMCAQVJWfq3GhYivelnlh659geNxJ8Rp/yvqsiE8 urL6JcbMCp6h9lfDmm4XyrUVEEQwPh5vXQ9cropBDJTEIKDdgv/DNqVUV3AfDz6U H7Xrig== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehu1cmuwq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 05:26:34 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-36d99333358so3118242a91.3 for ; Tue, 02 Jun 2026 22:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780464393; x=1781069193; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m3YqEw6zmQVetKx6FqU85A3xswC4mhkwqjLvA/EaE9Y=; b=EPsyCpVPbiUo2305IrI8xRbvhWYNONhJ/XS10ASAjzz4IudM6u8zepz3aQQRNtpRUE f3zbDuuuVVibVa40LrITzUmcQhI4cN2mPFGUh5otjOGCdCEHp+TeqIKHXlT0tZkbfjXP Rs5v7Oc2lhtS87zOdDkVtasC8o82Sy4ep59fcfcvE3qSvKHLDcc+mqpQBY6ZS6C+o3I2 rMANvJqIdCt7hXxXHL+MQbgdWkFvkQLA+R9nH9IZQji5PCEe6RszAQMSzmBI/6TzSl+W +c66tVQsAc+t4AMYrh1jJcQtqwe0zV5mZTSXTeJCiliPls73mmW6pC3DoARQY6l17p4a 46Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780464393; x=1781069193; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m3YqEw6zmQVetKx6FqU85A3xswC4mhkwqjLvA/EaE9Y=; b=TldWeLvT5FaJ0sHOD6Csz/wvOPYaKT+5ymVH9By4Jcah2f2V7/on4x8rGixFZKVEvE JdmgTy/0FDuNS+Hcvh5G76qSbLipolxDrP24mAlrvMc31rX+R9DNprUTVcsjHK7SxpS7 R4uHFJCQQb7zlrBrccvfpP8eufRGaXYyepN5968fdr4WI6j6tWwFdC4yPbtX5NsSixOo jSZFaEfVv44ofjPWIvZx0dqYOEKlSAdezanraDzc5URWwkXGq2rx6CPePAbCYEIHAtjd C/2cq8tJd0XF3cOsxLzbJ2RrNDw+CQapy4YnUm1vNafm3wmy54wFyN5+Dv87Yf/bUYPo 5JaQ== X-Forwarded-Encrypted: i=1; AFNElJ9NA/TT7rMPxsDiAfyHPRlRCYRdYvY0b8EbTScjCv7UpA0DkEl3Oc9MwB2AS636Y8oE+KFLc3ds7KRQog==@vger.kernel.org X-Gm-Message-State: AOJu0YyIbL8C1ukJQJxJYcHnEj+XPBpvyHoIY2LCKuZI0CTp8e0qQ23K YaQoGLv+qvDv/gsfuzEN8p57n8x6eVXGRMJVnxtsv7TZlgFHeAWR3bMNrFGNSfXUkLu6rk+6yoC Db13eDlXRLS8SfQJxGAMXAJEFLjFpgcWYIC04WiUlPFXntnaWqt+8loYwRjq2aJNVBw== X-Gm-Gg: Acq92OHq5wXZXBDz2qwgHw4mNjCpM7jNDLanPmFs3fRlHw6kXwmy84+i0CPeBz2UBpd sl2bXH2e9pJSfV6Nd+WeYN/MGIqZFbkbCpVJVHoWAYpmw2frAQe5dtX9sCOBBy5FpC1Y7reRiSC 9pw4i/qa1DVc4epWEHF9ZJ0Z04t+o3EINDpnI4Bs8bFz1aNCXIJVfFLEkfC9fWVIgfac8as2Xw8 pgfkCo9es51uW4UOQibPNQLG7Vye3YXAjCmN7SKPp9m5IUrmfZuPJ0TpWRPOJKMVYGEXJdc3S3t tOTBXE1GLn77BR1vymVrU0P94dWFjwNrkGNxB8LENmnx0C9Na1NIt+lUw5GDqm4Pi66EY+1qq6k OTJFFTciMZkrjh4HSh2N5KXZ3bpzDrX3YtjN2wAzWGFJksfrjD3RUccLYPi2g X-Received: by 2002:a05:6a21:46c5:b0:3b4:7bcc:5227 with SMTP id adf61e73a8af0-3b4977ff33bmr2188823637.12.1780464392898; Tue, 02 Jun 2026 22:26:32 -0700 (PDT) X-Received: by 2002:a05:6a21:46c5:b0:3b4:7bcc:5227 with SMTP id adf61e73a8af0-3b4977ff33bmr2188762637.12.1780464392345; Tue, 02 Jun 2026 22:26:32 -0700 (PDT) Received: from [10.204.78.54] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8428221a7e9sm1964720b3a.11.2026.06.02.22.26.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 22:26:31 -0700 (PDT) Message-ID: <8cdcca7f-7167-429b-b7ce-28e9b1f32256@oss.qualcomm.com> Date: Wed, 3 Jun 2026 10:56:23 +0530 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/15] accel/qda: Add initial QDA DRM accelerator driver To: Dmitry Baryshkov Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Bharath Kumar , Chenna Kesava Raju , srini@kernel.org, andersson@kernel.org, konradybcio@kernel.org, robin.clark@oss.qualcomm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org References: <20260519-qda-series-v1-0-b2d984c297f8@oss.qualcomm.com> <20260519-qda-series-v1-3-b2d984c297f8@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: GVI0MZZX_y_yhTdle3uaSwmSIYPNxryh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDA0OSBTYWx0ZWRfX9DB+GSuRp+Xv lV/uQGHarimt58L23Nj1GYx5asCka6YW5kdv66JxGL/4CNgE9z9uQfYss/aitX1iTNAdT0ETQZH FUAxmvZrDC8MDKu21jawoXPQQRvcmiWNtC/2JyeYnGewyhtEmzOsZxvXN2g3aY1caDF+/AA4xNa CFo/nn1kBAzm8mVRusAu8It6X8vkTqBrEuzEkDbgRX3d6QB08z2roSh/9BCSKZHOFXHwOinpLMh HeMZYXTx4wSloCGfninsDT9cxPQwJP7/Fby7ueRyY/8m+YYdqc+eDhB1p9+qbGBbOR9bU3AnL9A ghKwXJgZkR7JiYIelQcd1HMuinpMNjVeGy7K995qXgYjjfGNevaxTcTE3tg6L288MVyoTIGEwEG C2PRO2sPelQ9L3UBf00iMiYXGVX3jT8BidfyjWGXuOIj7CJcHCEMZ8cEtBKDHs1J98FPvEW+VTq 56YifADJsfhso50+ROw== X-Proofpoint-GUID: GVI0MZZX_y_yhTdle3uaSwmSIYPNxryh X-Authority-Analysis: v=2.4 cv=O6IJeh9W c=1 sm=1 tr=0 ts=6a1fbb0a cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=vu9siaMUKByHOgeoVcYA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_02,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030049 On 20-05-2026 19:48, Dmitry Baryshkov wrote: > On Tue, May 19, 2026 at 11:45:53AM +0530, Ekansh Gupta via B4 Relay wrote: >> From: Ekansh Gupta >> >> Add the foundational driver files for the Qualcomm DSP Accelerator >> (QDA), a DRM accel driver for Qualcomm DSPs. The driver integrates >> with the DRM accel subsystem (drivers/accel/) and provides: >> >> - A standard /dev/accel/accel* character device node via DRM. >> - GEM-based buffer management with DMA-BUF import/export (PRIME). >> - IOMMU context bank management for per-session memory isolation. >> - Standard DRM IOCTLs for device management and job submission. >> >> qda_drv.c / qda_drv.h: Core DRM driver registration. Defines the >> drm_driver ops table, per-file private state (qda_file_priv), and the >> main device structure (qda_dev) which embeds drm_device. >> >> qda_rpmsg.c / qda_rpmsg.h: RPMsg transport layer. Registers an >> rpmsg_driver matching the "qcom,fastrpc" compatible string. On probe >> it allocates a qda_dev, reads the DSP domain name from the "label" DT >> property, and registers the DRM device. >> >> Assisted-by: Claude:claude-4-6-sonnet >> Signed-off-by: Ekansh Gupta >> --- >> drivers/accel/Kconfig | 1 + >> drivers/accel/Makefile | 1 + >> drivers/accel/qda/Kconfig | 30 +++++++++++++ >> drivers/accel/qda/Makefile | 10 +++++ >> drivers/accel/qda/qda_drv.c | 97 ++++++++++++++++++++++++++++++++++++++++++ >> drivers/accel/qda/qda_drv.h | 62 +++++++++++++++++++++++++++ >> drivers/accel/qda/qda_rpmsg.c | 99 +++++++++++++++++++++++++++++++++++++++++++ >> drivers/accel/qda/qda_rpmsg.h | 13 ++++++ >> 8 files changed, 313 insertions(+) >> >> diff --git a/drivers/accel/Kconfig b/drivers/accel/Kconfig >> index bdf48ccafcf2..74ac0f71bc9d 100644 >> --- a/drivers/accel/Kconfig >> +++ b/drivers/accel/Kconfig >> @@ -29,6 +29,7 @@ source "drivers/accel/ethosu/Kconfig" >> source "drivers/accel/habanalabs/Kconfig" >> source "drivers/accel/ivpu/Kconfig" >> source "drivers/accel/qaic/Kconfig" >> +source "drivers/accel/qda/Kconfig" >> source "drivers/accel/rocket/Kconfig" >> >> endif >> diff --git a/drivers/accel/Makefile b/drivers/accel/Makefile >> index 1d3a7251b950..58c08dd5f389 100644 >> --- a/drivers/accel/Makefile >> +++ b/drivers/accel/Makefile >> @@ -5,4 +5,5 @@ obj-$(CONFIG_DRM_ACCEL_ARM_ETHOSU) += ethosu/ >> obj-$(CONFIG_DRM_ACCEL_HABANALABS) += habanalabs/ >> obj-$(CONFIG_DRM_ACCEL_IVPU) += ivpu/ >> obj-$(CONFIG_DRM_ACCEL_QAIC) += qaic/ >> +obj-$(CONFIG_DRM_ACCEL_QDA) += qda/ >> obj-$(CONFIG_DRM_ACCEL_ROCKET) += rocket/ >> \ No newline at end of file >> diff --git a/drivers/accel/qda/Kconfig b/drivers/accel/qda/Kconfig >> new file mode 100644 >> index 000000000000..484d21ff1b55 >> --- /dev/null >> +++ b/drivers/accel/qda/Kconfig >> @@ -0,0 +1,30 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> +# >> +# Qualcomm DSP accelerator driver >> +# >> + >> +config DRM_ACCEL_QDA >> + tristate "Qualcomm DSP accelerator" >> + depends on DRM_ACCEL >> + depends on ARCH_QCOM || COMPILE_TEST >> + depends on RPMSG >> + help >> + Enables the DRM-based accelerator driver for Qualcomm's Hexagon DSPs. >> + This driver provides a standardized interface for offloading computational >> + tasks to the DSP, including audio processing, sensor offload, computer >> + vision, and AI inference workloads. >> + >> + The driver supports all DSP domains (ADSP, CDSP, SDSP, GDSP) and >> + implements the FastRPC protocol for communication between the application >> + processor and DSP. It integrates with the Linux kernel's Compute >> + Accelerators subsystem (drivers/accel/) and provides a modern alternative >> + to the legacy FastRPC driver found in drivers/misc/. >> + >> + Key features include DMA-BUF interoperability for seamless buffer sharing > > Key features of what? Consider distro maintainers reading your help text > in order to identify whether to enable it or not. ack> >> + with other multimedia subsystems, IOMMU-based memory isolation, and >> + standard DRM IOCTLs for device management and job submission. >> + >> + If unsure, say N. >> + >> + To compile this driver as a module, choose M here: the >> + module will be called qda. >> diff --git a/drivers/accel/qda/Makefile b/drivers/accel/qda/Makefile >> new file mode 100644 >> index 000000000000..dbe809067a8b >> --- /dev/null >> +++ b/drivers/accel/qda/Makefile >> @@ -0,0 +1,10 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> +# >> +# Makefile for Qualcomm DSP accelerator driver >> +# >> + >> +obj-$(CONFIG_DRM_ACCEL_QDA) := qda.o >> + >> +qda-y := \ >> + qda_drv.o \ >> + qda_rpmsg.o >> diff --git a/drivers/accel/qda/qda_drv.c b/drivers/accel/qda/qda_drv.c >> new file mode 100644 >> index 000000000000..1c1bab68d445 >> --- /dev/null >> +++ b/drivers/accel/qda/qda_drv.c >> @@ -0,0 +1,97 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include "qda_drv.h" >> +#include "qda_rpmsg.h" >> + >> +static int qda_open(struct drm_device *dev, struct drm_file *file) >> +{ >> + struct qda_file_priv *qda_file_priv; >> + >> + qda_file_priv = kzalloc_obj(*qda_file_priv); >> + if (!qda_file_priv) >> + return -ENOMEM; >> + >> + qda_file_priv->qda_dev = qda_dev_from_drm(dev); >> + file->driver_priv = qda_file_priv; >> + >> + return 0; >> +} >> + >> +static void qda_postclose(struct drm_device *dev, struct drm_file *file) >> +{ >> + struct qda_file_priv *qda_file_priv = file->driver_priv; >> + >> + kfree(qda_file_priv); >> + file->driver_priv = NULL; >> +} >> + >> +DEFINE_DRM_ACCEL_FOPS(qda_accel_fops); >> + >> +static const struct drm_driver qda_drm_driver = { >> + .driver_features = DRIVER_COMPUTE_ACCEL, >> + .fops = &qda_accel_fops, >> + .open = qda_open, >> + .postclose = qda_postclose, >> + .name = QDA_DRIVER_NAME, >> + .desc = "Qualcomm DSP Accelerator Driver", >> +}; >> + >> +struct qda_dev *qda_alloc_device(struct device *dev) >> +{ >> + struct qda_dev *qdev; >> + >> + qdev = devm_drm_dev_alloc(dev, &qda_drm_driver, struct qda_dev, drm_dev); >> + if (IS_ERR(qdev)) >> + return ERR_CAST(qdev); >> + >> + return qdev; >> +} >> + >> +void qda_unregister_device(struct qda_dev *qdev) >> +{ >> + drm_dev_unregister(&qdev->drm_dev); >> +} >> + >> +int qda_register_device(struct qda_dev *qdev) >> +{ >> + int ret; >> + >> + ret = drm_dev_register(&qdev->drm_dev, 0); >> + if (ret) >> + drm_err(&qdev->drm_dev, "Failed to register DRM device: %d\n", ret); >> + >> + return ret; >> +} >> + >> +static int __init qda_core_init(void) >> +{ >> + int ret; >> + >> + ret = qda_rpmsg_register(); >> + if (ret) >> + return ret; >> + >> + pr_info("qda: QDA driver initialization complete\n"); >> + return 0; >> +} >> + >> +static void __exit qda_core_exit(void) >> +{ >> + qda_rpmsg_unregister(); >> +} >> + >> +module_init(qda_core_init); >> +module_exit(qda_core_exit); >> + >> +MODULE_AUTHOR("Qualcomm AI Infra Team"); >> +MODULE_DESCRIPTION("Qualcomm DSP Accelerator Driver"); >> +MODULE_LICENSE("GPL"); >> diff --git a/drivers/accel/qda/qda_drv.h b/drivers/accel/qda/qda_drv.h >> new file mode 100644 >> index 000000000000..7ba2ef19a411 >> --- /dev/null >> +++ b/drivers/accel/qda/qda_drv.h >> @@ -0,0 +1,62 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#ifndef __QDA_DRV_H__ >> +#define __QDA_DRV_H__ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +/* Driver identification */ >> +#define QDA_DRIVER_NAME "qda" >> + >> +/** >> + * struct qda_file_priv - Per-process private data for DRM file >> + */ >> +struct qda_file_priv { >> + /** @qda_dev: Back-pointer to device structure */ >> + struct qda_dev *qda_dev; >> +}; >> + >> +/** >> + * struct qda_dev - Main device structure for QDA driver >> + * >> + * The DRM device is embedded as the first member so that container_of() >> + * can recover the qda_dev from any drm_device pointer. >> + */ >> +struct qda_dev { >> + /** @drm_dev: Embedded DRM device; recover via qda_dev_from_drm() */ >> + struct drm_device drm_dev; >> + /** @rpdev: RPMsg device for communication with the remote processor */ >> + struct rpmsg_device *rpdev; >> + /** @dev: Underlying Linux device */ >> + struct device *dev; >> + /** @dsp_name: Name of the DSP domain (e.g. "cdsp", "adsp") */ >> + const char *dsp_name; >> +}; >> + >> +/** >> + * qda_dev_from_drm - Recover qda_dev from an embedded drm_device pointer >> + * @dev: Pointer to the embedded drm_device >> + * >> + * Return: Pointer to the enclosing qda_dev. >> + */ >> +static inline struct qda_dev *qda_dev_from_drm(struct drm_device *dev) >> +{ >> + return container_of(dev, struct qda_dev, drm_dev); >> +} >> + >> +/* Device allocation (uses devm_drm_dev_alloc internally) */ >> +struct qda_dev *qda_alloc_device(struct device *dev); >> + >> +/* Core device lifecycle */ >> +int qda_register_device(struct qda_dev *qdev); >> +void qda_unregister_device(struct qda_dev *qdev); >> + >> +#endif /* __QDA_DRV_H__ */ >> diff --git a/drivers/accel/qda/qda_rpmsg.c b/drivers/accel/qda/qda_rpmsg.c >> new file mode 100644 >> index 000000000000..6eaf1b145f8a >> --- /dev/null >> +++ b/drivers/accel/qda/qda_rpmsg.c >> @@ -0,0 +1,99 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +// Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> +#include >> +#include >> +#include >> +#include >> + >> +#include "qda_drv.h" >> +#include "qda_rpmsg.h" >> + >> +static struct qda_dev *alloc_and_init_qdev(struct rpmsg_device *rpdev) > > Use the prefix uniformly. > ack>> +{ >> + struct qda_dev *qdev; >> + >> + qdev = qda_alloc_device(&rpdev->dev); >> + if (IS_ERR(qdev)) >> + return qdev; >> + >> + qdev->dev = &rpdev->dev; >> + qdev->rpdev = rpdev; >> + dev_set_drvdata(&rpdev->dev, qdev); >> + >> + return qdev; >> +} >> + >> +static int qda_rpmsg_cb(struct rpmsg_device *rpdev, void *data, int len, >> + void *priv, u32 src) >> +{ >> + /* Placeholder: responses will be dispatched here */ >> + return 0; >> +} >> + >> +static void qda_rpmsg_remove(struct rpmsg_device *rpdev) >> +{ >> + struct qda_dev *qdev = dev_get_drvdata(&rpdev->dev); >> + >> + drm_dev_unplug(&qdev->drm_dev); >> + qdev->rpdev = NULL; >> + qda_unregister_device(qdev); >> + dev_info(qdev->dev, "RPMsg device removed\n"); > > Drop the spamming. And useless (where it is useless) drm_dbg() / dev_dbg() spamming too. ack> >> +} >> + >> +static int qda_rpmsg_probe(struct rpmsg_device *rpdev) >> +{ >> + struct qda_dev *qdev; >> + const char *label; >> + int ret; >> + >> + dev_dbg(&rpdev->dev, "QDA RPMsg probe starting\n"); >> + >> + qdev = alloc_and_init_qdev(rpdev); >> + if (IS_ERR(qdev)) >> + return PTR_ERR(qdev); >> + >> + ret = of_property_read_string(rpdev->dev.of_node, "label", &label); >> + if (ret) { >> + dev_err(qdev->dev, "Missing 'label' property in DT node: %d\n", ret); >> + return ret; >> + } >> + qdev->dsp_name = label; > > Why not just of_property_read_string(...., &qdev->dsp_name)? > >> + >> + ret = qda_register_device(qdev); > > return qda_register_device(); ack> >> + if (ret) >> + return ret; >> + >> + drm_info(&qdev->drm_dev, "QDA RPMsg probe complete for %s\n", qdev->dsp_name); >> + return 0; >> +} >> + >> +static const struct of_device_id qda_rpmsg_id_table[] = { >> + { .compatible = "qcom,fastrpc" }, >> + {}, >> +}; >> +MODULE_DEVICE_TABLE(of, qda_rpmsg_id_table); >> + >> +static struct rpmsg_driver qda_rpmsg_driver = { >> + .probe = qda_rpmsg_probe, >> + .remove = qda_rpmsg_remove, >> + .callback = qda_rpmsg_cb, >> + .drv = { >> + .name = "qcom,fastrpc", >> + .of_match_table = qda_rpmsg_id_table, >> + }, >> +}; >> + >> +int qda_rpmsg_register(void) >> +{ >> + int ret = register_rpmsg_driver(&qda_rpmsg_driver); >> + >> + if (ret) >> + pr_err("qda: Failed to register RPMsg driver: %d\n", ret); >> + >> + return ret; >> +} >> + >> +void qda_rpmsg_unregister(void) >> +{ >> + unregister_rpmsg_driver(&qda_rpmsg_driver); >> +} > > Just use module_rpmsg_driver(), drop all the wrappers and module_init() > / exit(). I'll check and update this.> >> diff --git a/drivers/accel/qda/qda_rpmsg.h b/drivers/accel/qda/qda_rpmsg.h >> new file mode 100644 >> index 000000000000..5229d834b34b >> --- /dev/null >> +++ b/drivers/accel/qda/qda_rpmsg.h >> @@ -0,0 +1,13 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. >> + */ >> + >> +#ifndef __QDA_RPMSG_H__ >> +#define __QDA_RPMSG_H__ >> + >> +/* RPMsg transport layer registration */ >> +int qda_rpmsg_register(void); >> +void qda_rpmsg_unregister(void); >> + >> +#endif /* __QDA_RPMSG_H__ */ >> >> -- >> 2.34.1 >> >> >