From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A640336EE7 for ; Mon, 23 Mar 2026 06:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774247792; cv=none; b=WWlqLkhjlLlBGj4AwLzJbPhrhvMhKPPfCDdqhcuZOu4hSEAjgu6GXYG5ecdloYCP2p8O+zUsT3eJWnlK1c+IReEoQut65Z+b2tSRJo8BoCrfF5kw3daxckGq7jFkxIIkH9caEQUvdGfUYLVeMTDlK5iHAHm9HyIzD7zFjHFOYd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774247792; c=relaxed/simple; bh=SG55dzYNEevyi4u6lpN3KXChXwdHwXvdMoHw+IIIM/c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gpulj85eNBiS3tO1RKproiNoLLXGfB5OrO+wBdFeddFb19QRygV5gL6McI7psZm85GWa5bSLNRc3gZpQw8HPNqJhFb9FeUhnUJ2k0L5g1pW1EC0b/fzfytzUW0MA7iQKfK6RoaRbRRF+1qVyBgSsNWN7F8pla15gbK8gAMFk7iE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S7JyucPJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Xb4dYcX/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S7JyucPJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Xb4dYcX/" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62MLrjok1001396 for ; Mon, 23 Mar 2026 06:36:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= i9H6sI3queRR62Obn9oreIe69+sv8Bk0hdBxZVqX1kA=; b=S7JyucPJ7OvtzENo 6c+ZxkU8+BWC7ClUvpvadwVGLUYf/CphfDcU5qMDJztIg5FKsearzB1NB8+gp2gP ftXWyj5lG9ZXb+tAFh7UPJAVTS24HfCklSH5DAHreuY8H16yShSHwZGNsVZBseQh UebdX/X87BmRQZlo1xLT+uZFeTig97XSo0mMSzTkYcv4u59fKQfBAA9honcZWJjj R5QMAaNhkjyflg1FGzzO7VL4LLYx2NWWBTp9M5yD0qKulX8u8yGpF5JvseVhAM94 DC5owU8bR3WrXFwGB2q8ObNaVdk6YZGmc7zO3hT2maAOaXVPWqYh0LpaBu/0+ZMz 4T2vmw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1j9rc2gd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 06:36:27 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35a0b51eb23so3601088a91.2 for ; Sun, 22 Mar 2026 23:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774247787; x=1774852587; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=i9H6sI3queRR62Obn9oreIe69+sv8Bk0hdBxZVqX1kA=; b=Xb4dYcX/NQu0sGKb41lVOXM1BaYvPycJS6EsDh1ZwzRgZqRtEgEsDNOMWHie9+yQnd 4dqmC1s1mjy2Jjf9dj1VA/hx6T2T/r485AHG+VWrVLyNOERrxQU0+1dGzfSE8iGFLs7h GkaDPUsXs9brkEfYmZiba3YVwFQ9BFaLNRItElbCT0UgyGsXEmY7X/l7xuq8BMoCDK5O ivdatgH+GIEUg5XiKE0bC2/AOscCIV3UsE5z4vGjrrDzenHsMZpN4L6TgKRfGaD0kry7 ieO9d968hGq8Q/NcDJCCLJaiaDdeOz4ArsFKp8AKSG5uISyv0OnN6YoYdg/V09uPPljc J9sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774247787; x=1774852587; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i9H6sI3queRR62Obn9oreIe69+sv8Bk0hdBxZVqX1kA=; b=RmQ+ewA5BO7eZifj5haQCAzMmX7NnkCV2ADNlyOz2nXW2T1lKJ/7etWcJNGO6UAhTJ odJMAk+HnV/zO6Jn+JJniaUlkV8yhKfK72dgjWI5zIzOfEX4fnYynEDNkZwKgB+LznU0 Ru2gn63/JQK2vFdGAyzgOZyT7pgjOlwy+hzmkUwAeV8qlYHdAI87I+OjQ/UJcyWAt6x2 Ncj06wneA8FoX1JHTGva7t/Rz5DhF9IxCPQmRImxLmmZTGgvzvTzBiqQOr1ufw1tRFJ8 GnPVeEotlv03ur5dzObTItDSDNt2DDRtetgZonsX7RVpVsHVlColytY0vMjNPGF0U4cH IiIw== X-Gm-Message-State: AOJu0YyiZFpFOR4V1q2h8CrOmp4GKJZ31IERmLsLB4TMCjR/S3/R6DIo mc+SjrbXBYrA5lrZxQOPL9tQjNpMbohxFMZD0DseZelrgxd5aL7ivIdxm+JXmPfWUAT3bSAjrWQ V/fIwelHGyEvZdv4hfUbXpJivwUUmYHleAEhPOG/cnUbUk+jRfGXuiaapkUjgT8QBMw== X-Gm-Gg: ATEYQzwfOFwfWO64iXuA93MD+OwvbRjPZ0Eqsqqt4dwA39pADjEWYgzWN2nfxfsoMlK LRTJ2vvHCwvECGA/pIeGe5QrJ59HHGhHonaPGVmbNUkc0jvz1e6On+ICF1Fb1dgixBFcIWBeHsp 6TSUtYKVRNPIv/8Om1ADbqTlc9MwXcQ8usAKHnTQY3EAysWG8wMbwh4XCBoPD8Bsi1keYoh9ubx kr7VaGeKxfZN7zTZYWBGLHE4Yz+oh2tkffGigIkhOk7l+CNkvUI+oXnJAkLtd9uiUl2YfxXqkKB Kbc1S+3ND29CkSEuIQTHRxnlc/Bq71iMR+jfiBjM2uzlT0ULvFGwr2lle2LbR3ZNu+r0hTs1p8Z c6cBaTI6AeM3mg8CCUnEb3mEZJyGeM2tAkCqqWEfto7A9/5RphiTbmQ== X-Received: by 2002:a17:902:c405:b0:2b0:4f82:74ce with SMTP id d9443c01a7336-2b0827bf173mr109718875ad.46.1774247786507; Sun, 22 Mar 2026 23:36:26 -0700 (PDT) X-Received: by 2002:a17:902:c405:b0:2b0:4f82:74ce with SMTP id d9443c01a7336-2b0827bf173mr109718645ad.46.1774247786017; Sun, 22 Mar 2026 23:36:26 -0700 (PDT) Received: from [10.0.0.3] ([106.222.233.113]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08366c4f1sm97059195ad.59.2026.03.22.23.36.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Mar 2026 23:36:25 -0700 (PDT) Message-ID: <8dc65781-9a0d-6c26-dae8-74bf6ec1854b@oss.qualcomm.com> Date: Mon, 23 Mar 2026 12:06:20 +0530 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v8 07/11] media: qcom: iris: drop hw_response_timeout_val from platform data Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260319-iris-platform-data-v8-0-55a9566ebf60@oss.qualcomm.com> <20260319-iris-platform-data-v8-7-55a9566ebf60@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260319-iris-platform-data-v8-7-55a9566ebf60@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: tCJYYdz18xRu5lu7XJmAMHTtKGsypIN8 X-Authority-Analysis: v=2.4 cv=ZPDaWH7b c=1 sm=1 tr=0 ts=69c0df6b cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=hbzS8gabZINpAvasuVNEhA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=ERqvkBjMsZt1UCBLgn8A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA0OSBTYWx0ZWRfXznMng+wHCPpz oS2RBQFXa+HI/px5z4qEUMsPfPizdtIRC1SEyNfGbsL0Q1xFJdNgKQ8SLil4C73U8gnMqLUd31K AperdjKIp9mgWb2XUQwG7myssVYWVrp6tIJiEUiIRw89C9WUwBtc3U3U4/L4kpJOimK1K6t3nD8 uSqDrVwiaMdbtcVJykc/u1aln8EHMknE5VWnAkjhYl+eP1FZ6IJEhAWciMymdTe/j8MZziPouOE +z4RS1JC4ydx/D12Svz+rR78A5/kP8E2AyetZX93kHVrQmLcxyAX3jihP7c7t+4X9xsErJhlG2Z G2M27LMnjJcbwJ5dt1/Hsplaa8RgvM3qORjCf2bF9otmqtdA1Sb42Bwt39LgaTOSVe3ioQB/nXi bH+MrL0Mb5pB3AalflkVQbc+TlJ9gi/5Qwx8REjUMmmnqBMJxbngn68Zm7V6fPWVHMblJCQpBP/ FYRBg/Ttd9mEINtXdIA== X-Proofpoint-GUID: tCJYYdz18xRu5lu7XJmAMHTtKGsypIN8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 impostorscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230049 On 3/19/2026 11:29 AM, Dmitry Baryshkov wrote: > The HW response time is a constant between platforms. Remove it from the > iris_platform_data structure and use it directly. > > Suggested-by: Vikash Garodia > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_core.c | 3 +-- > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - > drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 -- > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 4 ---- > drivers/media/platform/qcom/iris/iris_utils.c | 5 +---- > 5 files changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_core.c b/drivers/media/platform/qcom/iris/iris_core.c > index 8406c48d635b..e6141012cd3d 100644 > --- a/drivers/media/platform/qcom/iris/iris_core.c > +++ b/drivers/media/platform/qcom/iris/iris_core.c > @@ -28,14 +28,13 @@ void iris_core_deinit(struct iris_core *core) > > static int iris_wait_for_system_response(struct iris_core *core) > { > - u32 hw_response_timeout_val = core->iris_platform_data->hw_response_timeout; > int ret; > > if (core->state == IRIS_CORE_ERROR) > return -EIO; > > ret = wait_for_completion_timeout(&core->core_init_done, > - msecs_to_jiffies(hw_response_timeout_val)); > + msecs_to_jiffies(HW_RESPONSE_TIMEOUT_VALUE)); > if (!ret) { > core->state = IRIS_CORE_ERROR; > return -ETIMEDOUT; > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index d1daef2d874b..e8a219023aaa 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -232,7 +232,6 @@ struct iris_platform_data { > const struct tz_cp_config *tz_cp_config_data; > u32 tz_cp_config_data_size; > u32 core_arch; > - u32 hw_response_timeout; > u32 num_vpp_pipe; > bool no_aon; > u32 max_session_count; > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > index 9925a893b404..6ed4c4ae4056 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c > @@ -361,7 +361,6 @@ const struct iris_platform_data sm8250_data = { > .inst_fw_caps_enc_size = ARRAY_SIZE(inst_fw_cap_sm8250_enc), > .tz_cp_config_data = tz_cp_config_sm8250, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8250), > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 4, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K, > @@ -410,7 +409,6 @@ const struct iris_platform_data sc7280_data = { > .inst_fw_caps_enc_size = ARRAY_SIZE(inst_fw_cap_sm8250_enc), > .tz_cp_config_data = tz_cp_config_sm8250, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8250), > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 1, > .no_aon = true, > .max_session_count = 16, > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index 10a972f96cbe..abe523db45c2 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -936,7 +936,6 @@ const struct iris_platform_data sm8550_data = { > .tz_cp_config_data = tz_cp_config_sm8550, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8550), > .core_arch = VIDEO_ARCH_LX, > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 4, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K * 2, > @@ -1036,7 +1035,6 @@ const struct iris_platform_data sm8650_data = { > .tz_cp_config_data = tz_cp_config_sm8550, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8550), > .core_arch = VIDEO_ARCH_LX, > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 4, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K * 2, > @@ -1127,7 +1125,6 @@ const struct iris_platform_data sm8750_data = { > .tz_cp_config_data = tz_cp_config_sm8550, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8550), > .core_arch = VIDEO_ARCH_LX, > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 4, > .max_session_count = 16, > .max_core_mbpf = NUM_MBS_8K * 2, > @@ -1222,7 +1219,6 @@ const struct iris_platform_data qcs8300_data = { > .tz_cp_config_data = tz_cp_config_sm8550, > .tz_cp_config_data_size = ARRAY_SIZE(tz_cp_config_sm8550), > .core_arch = VIDEO_ARCH_LX, > - .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, > .num_vpp_pipe = 2, > .max_session_count = 16, > .max_core_mbpf = ((4096 * 2176) / 256) * 4, > diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c > index cfc5b576ec56..29b07d88507e 100644 > --- a/drivers/media/platform/qcom/iris/iris_utils.c > +++ b/drivers/media/platform/qcom/iris/iris_utils.c > @@ -55,16 +55,13 @@ void iris_helper_buffers_done(struct iris_inst *inst, unsigned int type, > > int iris_wait_for_session_response(struct iris_inst *inst, bool is_flush) > { > - struct iris_core *core = inst->core; > - u32 hw_response_timeout_val; > struct completion *done; > int ret; > > - hw_response_timeout_val = core->iris_platform_data->hw_response_timeout; > done = is_flush ? &inst->flush_completion : &inst->completion; > > mutex_unlock(&inst->lock); > - ret = wait_for_completion_timeout(done, msecs_to_jiffies(hw_response_timeout_val)); > + ret = wait_for_completion_timeout(done, msecs_to_jiffies(HW_RESPONSE_TIMEOUT_VALUE)); > mutex_lock(&inst->lock); > if (!ret) { > iris_inst_change_state(inst, IRIS_INST_ERROR); > Reviewed-by: Dikshita Agarwal Thanks, Dikshita