Re: [PATCH regression fixes for 6.19 0/5] media: ov02c10: h/vflip fixes

[Bryan O'Donoghue <bod@kernel.org>]

On 09/12/2025 16:06, Hans de Goede wrote:
> Hi All,
> 
> Commit 69fe27173396 ("media: ov02c10: Fix default vertical flip") which
> has been merged this merge window is causing various problems for
> laptops with a ov02c10 sensors:
> 
> 1. This changes the vflip default but does not update the bayer-order
>     leading to debayer artifacts and wrong colors
> 
> 2. The ov02c10 driver was originally developed on a XPS 16 9640 which
>     has its sensor upside down. Changing the vflip (and hflip) default
>     values fixes the image being upside down on other laptops, but will
>     cause a regression on Dell XPS models causing the image to be upside
>     down there.
> 
> 3. The mentioned commit only changes vflip, so the image now is upside-up,
>     but it is still mirrored.
> 
> Patches 1-4 of this series fixes these issues. Patch 5 is a follow-up
> cleanup patch.
> 
> Hans Verkuil, can you please queue these up as fixes for 6.19?
> 
> Regards,
> 
> Hans
> 
> 
> Hans de Goede (5):
>    media: ov02c10: Fix bayer-pattern change after default vflip change
>    media: ov02c10: Adjust x-win/y-win when changing flipping to preserve
>      bayer-pattern
>    media: ov02c10: Fix the horizontal flip control
>    media: ipu-bridge: Add DMI quirk for Dell XPS laptops with upside down
>      sensors
>    media: ov02c10: Remove unnecessary hflip and vflip pointers
> 
>   drivers/media/i2c/ov02c10.c          | 28 +++++++++++----------------
>   drivers/media/pci/intel/ipu-bridge.c | 29 ++++++++++++++++++++++++++++
>   2 files changed, 40 insertions(+), 17 deletions(-)
> 
> --
> 2.52.0
> 

I thought of this at the time but, assumed it was tested, on submission.

Should have asked.

---
bod