public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Sean Young <sean@mess.org>
Cc: dhowells@redhat.com,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Brad Love <brad@nextdimension.cc>,
	mchehab@kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dvb: Allow MAC addresses to be mapped to stable device names with udev
Date: Wed, 31 Oct 2018 19:10:00 +0000	[thread overview]
Message-ID: <9074.1541013000@warthog.procyon.org.uk> (raw)
In-Reply-To: <20181031161300.vzk6nsyyyvjukqxz@gofer.mess.org>

Sean Young <sean@mess.org> wrote:

> device_create() will register the device in sysfs and send uevent. So, your
> original udev rule/code will not work, since it always would read
> a mac address of 0, as proposed_mac is not populated when the device is
> announced. That is, unless udev is scheduled after the mac is read.

I guess that must be what is happening as it does seem to work for me.

> I think the device_add/device_create() which triggers the uevent should be
> delayed until everything is available.

Is it possible to switch vb2_dvb_register_bus() and dvb_register_ci_mac() in
dvb_register() in cx23885-dvb.c - or does that prevent the firmware from
loading?

And I'm guessing this change would have to be applied to all drivers?

David

      parent reply	other threads:[~2018-11-01  4:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24 10:10 [PATCH] dvb: Allow MAC addresses to be mapped to stable device names with udev David Howells
2018-10-30 14:03 ` Mauro Carvalho Chehab
2018-10-30 22:32   ` Sean Young
2018-10-31  0:35     ` Mauro Carvalho Chehab
2018-10-31  8:43       ` Sean Young
2018-10-31 10:57         ` David Howells
2018-10-31 10:36     ` David Howells
2018-10-31 10:49       ` Sean Young
2018-10-31 11:01         ` David Howells
2018-10-31 11:19         ` David Howells
2018-10-31 15:51           ` David Howells
2018-10-31 16:12             ` Mauro Carvalho Chehab
2018-10-31 16:13             ` Sean Young
2018-10-31 16:28               ` Mauro Carvalho Chehab
2018-10-31 19:10               ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9074.1541013000@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=brad@nextdimension.cc \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox