From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012005.outbound.protection.outlook.com [40.107.200.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C183947AF71; Wed, 21 Jan 2026 09:01:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.5 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768986110; cv=fail; b=OlnaD5VcBeWGS3zJgQtpeiuUnE6//MDsarIMkq2b7BhvxBdjkE/NCodf0HtBeW1WPpsKA41XWmgkqbFC50r3Ah3yDpxcLkYrmSyR41nX6VMyzz4QnthtEUqAEvLeDvnifVFVBRLpWK5FQMHf4huzB8dALpmxKIvRrAl6H/MdfIw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768986110; c=relaxed/simple; bh=wwVpHo0GrbgJHo1dqDuWG08282huCGleDayPm4UiwIM=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=SD2JlN+LrI+JEskXoIzOE078WYzexwpbq3Kd3kQ114M7w2mem4oVNKZaprsGbpYHh6PikRdeqRO/59LnV2V635VFSG5nDT53WjFcDSZZluLimPc7npKNOMRh6+9f2/L7XeB1bVQFusX7QatzPwzOn/g/UfBAZARx7pL5UTg2R8U= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=B7Qbkcvn; arc=fail smtp.client-ip=40.107.200.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="B7Qbkcvn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E/pp1dsI7FnP1J1VDRAfxOm0jBMEcPcfQ5A5E4IrDR4KKVXHG6PAfIX1YNStRbCVTsVLowlpRu0bB0xYbQFc9lxa4UISqhLMtT6TMLfDUF3tH9/aXgix4uFcood1033eDMtaKwqnZRVSMz9XxbV0cWvP6jnqQvEIwQJwDs2WHW/UYMGUTjTXWQcqseE+UsPlVcoF1PrPeKrViSCE2G3xXu5WLxy179dr64v+XErEyqnUnhVqDF/6f39I4065LxHlHzOYGN7wyirClcHTDWUXJeccBq66qsTAKO2R7u8Ww6YoKb9tfGNwpKftNX8AfG2eGus/PB17ggKuneOiBRkyOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sq7mmwL6JtxYkBLOcNDoLiu9EUefZauctDpm1irxEMU=; b=LE+R/255XHoSdGxDiZAh8G+Q+Eh2xwGu7305Gw+NZP3PtsT0nePVxgOsLm0/o/3vVb5rhqSWh6XmPa00Qf8Mg2GYXbH+zL3mZmgDw/UloWnYN488hXCKTn0+eP8JvBSopno9vonCqphCi87jVSKHuxoc1aElYJEXsalEe6QESXR0r/1UpXFVvARw51gvMYLzWnAWcX5Ck9oDKLhNDTTY43Ep4EHEzzYBqNMGsXRTFoM8DXUx2vWoxaz0wc+g102JnkuDq2emWdD7QMXD2/q6o7chSaF5PQ0p1iOr8IAJrITfzI0yP2oT9RdEZjBn3NPrwY4Wnt7BMZcjP2Ms/K9x9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sq7mmwL6JtxYkBLOcNDoLiu9EUefZauctDpm1irxEMU=; b=B7QbkcvnyPaUOpRae6161sxwv9SmAF8hP5f+VO09ToT3eGxdUUUBm3i3ZFHOS0MClEzcxXjgOOMLZHJPesVyEdZbPYMZI5niQYT04xgPX3/nXO1I5nfy6/B8Hk5R+31gCIbpB26zWc5YkYUGE64aplCwmEm4eeDQJ0o6lBGffqw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH7PR12MB5685.namprd12.prod.outlook.com (2603:10b6:510:13c::22) by SJ1PR12MB6361.namprd12.prod.outlook.com (2603:10b6:a03:455::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.9; Wed, 21 Jan 2026 09:01:43 +0000 Received: from PH7PR12MB5685.namprd12.prod.outlook.com ([fe80::46fb:96f2:7667:7ca5]) by PH7PR12MB5685.namprd12.prod.outlook.com ([fe80::46fb:96f2:7667:7ca5%4]) with mapi id 15.20.9542.008; Wed, 21 Jan 2026 09:01:43 +0000 Message-ID: <916dda3b-583f-42fb-bbaa-bcb664e6825e@amd.com> Date: Wed, 21 Jan 2026 10:01:34 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/7] iommufd: Pin dma-buf importer for revoke semantics To: Leon Romanovsky , Sumit Semwal , Alex Deucher , David Airlie , Simona Vetter , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Jason Gunthorpe , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Felix Kuehling , Alex Williamson , Ankit Agrawal , Vivek Kasireddy Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org References: <20260120-dmabuf-revoke-v3-0-b7e0b07b8214@nvidia.com> <20260120-dmabuf-revoke-v3-5-b7e0b07b8214@nvidia.com> Content-Language: en-US From: =?UTF-8?Q?Christian_K=C3=B6nig?= In-Reply-To: <20260120-dmabuf-revoke-v3-5-b7e0b07b8214@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0110.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::20) To PH7PR12MB5685.namprd12.prod.outlook.com (2603:10b6:510:13c::22) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB5685:EE_|SJ1PR12MB6361:EE_ X-MS-Office365-Filtering-Correlation-Id: 33cb938d-aa34-408e-7781-08de58cbb2de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dkVjTmFkQ3dKcStOZ3A5UEF5QjJXc2tSZXFOZnRyeGg0TllYUE54MHlBclBZ?= =?utf-8?B?S0o5ekxtY1N2MEx0Y29Zb01DeEFCWHd3ak0yNTE4N3ZUT2JZdGw5OEZaVHZn?= =?utf-8?B?RkNDRkg1a2twV3RxSWlKNEdwTjFvajJFcTJ0dlc4a214V3E5emo3K1I2U0FL?= =?utf-8?B?YzN1aldQdG0xTVFlcXZOZitMUEtRMGdRSllzb2p6bldaOXBydGZiSUcrU3Rj?= =?utf-8?B?TURLdDdiblpjdWdwbE5sKzE1MzhIZ0hKREEvZHVHYjBFNzhkTzJ0QzFoclZz?= =?utf-8?B?QzZOYmpuNXBLNmIwa3dnSlZhVnhDQ0NBRnB1dmpGanVwT2VsMmNieVRSU0xH?= =?utf-8?B?Z3QxN3ROSlFVclM0NW9weExRVmF3dzdOcU9CcDRFRlNrY29ic0dpS1RGcmVu?= =?utf-8?B?ekhXME8rTjBYMlE4ck94c1lCTW1EMU1NQWhXdjJMRjBFYXV2d21IVjEwVXo0?= =?utf-8?B?bHlERDJQeElOMGJJaVlqMXI3eVF5aUlQZVhraDNGZmxwVVZRcGs1d1pTSlNs?= =?utf-8?B?MnZndGJlbU5TeUhqNXhhNmFHNDN6RFZJTWRuME9TdCtpSmN4TWFDbExVUVY1?= =?utf-8?B?KzJweFp5eDNENCsrYXNnOUw1TEJtcnFzQmp2SVNLL0ZTekVVUW8wQU9nT25y?= =?utf-8?B?UVQwR1EyT3JRdG4yRUNXQTFmZ01OWFFKTkVTY3Rtb0hvR1pvN3BhQlVqMzMy?= =?utf-8?B?b2FEU3BnL0hOVVkxRDNiNDc2RnZIUDJPbTVPeUtXMXVQZFlkbXExT2RkNm9S?= =?utf-8?B?Y0ZKck83blg5T294dTFOTE45UDE0djNjVW9Bb3MraStENHBmQ0ovbU91Y2RO?= =?utf-8?B?akkyb0hnemJSWkxINlNrV3Z6V2IwVHY0d1RCQ0E3ZVNaQVdnUW5nS3UxaHdC?= =?utf-8?B?SlVtWm1iZEpPVk9vY1VyYkQ1THJ1enAyUFBJMmxtZCtCK1BrZW91UWpFTjBY?= =?utf-8?B?d1BIaVRZQTNVRFlRSTJYR2hCMWliYlQwcThTOVA1Y2UxQVhxYWVVZTM0NHpQ?= =?utf-8?B?eFNBOEdHK09ZYWtpSDlZRS9abkYzNS9RK0NTSHJVNGFQSG1ZTHhZbVEwTm1a?= =?utf-8?B?UkhJTmYyd0VibCtpK201Q0NYNHVTUTRQTURST1d3d1hsQ0hPTjM5Tm9Eckp2?= =?utf-8?B?dUtFaFF4SnQwa3N1c1NYL29DUGEvczFTUXVQQlNLd2RuY1pnRGc1WXI3Qlk0?= =?utf-8?B?WFdmLzhtZEJzbURRWTkzU1RLMzc5UWpPT3BqNk5kTzJ3YmNDSEY0TGI2T2Mx?= =?utf-8?B?bG44TnlZN3orazc4dVFrOWZWNHZOa2N1cy9CMkcxcnJ5UXJvVXNBM2IrS3Ir?= =?utf-8?B?Qml0WjF6TkNNaERESFFzdzFCTjVtOEZ2SXRvbVpGSy82cnVaNGtZUlZKOTg1?= =?utf-8?B?N1dkK082K0NUZ0NXem9lOHF2Vjl3eVBrUVFmRmcwVWk1QUh2blRNeGEzR0J4?= =?utf-8?B?c3lwc2p0WnUyS0ZkanRPd2x4VjVucW1QYlloRFNJYnoyMmRMcklCdDV3a2NN?= =?utf-8?B?UE5OWEc5UTVldDJGK0pia2JaNkllemI4NU5Za2dSLzNqMUJNL3VGNWtCN2dP?= =?utf-8?B?b1BTaWl5QmpDZXdIVzJDbW1za2ZDTXZyaUEvTUN4dU9iRU5xdHR4cnoxWGMr?= =?utf-8?B?YlpXNWl5dUE2WEZjbjg2b291L2pUdlY1U0FOeXJjNGlXd21zQ21kanN6RU5k?= =?utf-8?B?b3d6Y0V0VmhMZWdmQU9zUVVidVdaTUw3SlkzbzI5dFZXNC9HdnRHN2pUZkJC?= =?utf-8?B?YVgxV0VGcStpYXpFbFloRE1YbUFXaThmS3lpR3phQVYrTlI4bm1oclJzYUJp?= =?utf-8?B?YUFucDk0RDZVM2Q3SlMzWGw0aVdtK1plbXFDWHBSdk9GSUZTdDJmalJyZlR5?= =?utf-8?B?OVJJdG5Vait1OHNoNHNGQjR6bkwzeitqQjNXWVdhN0tZMnRXZEliWFh0c29I?= =?utf-8?B?WmdWZ2JBb2hWcUVEL2d1RmtackozeUpLUTJyL3F1L3ZZK05FRHl6cEtNOFVS?= =?utf-8?B?cUhFSXlxRnZHMzFMbFprS05MdTB1RkJVdmpaWitWd1c5WWZYY0ZHVmZDaEl3?= =?utf-8?B?dVVPNGV2aVpWSjl2OWo5R1pNdG8rRS9qaFdoNXhHY2FpT1RIRlgyVXNDRHJv?= =?utf-8?B?bzROYTgvWGUrTW4xMnlsTktSc0FSVHdIQnJoZVRFSmpWNUVhSWl4Y0dNNGVQ?= =?utf-8?B?M0E9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB5685.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1V6a2lXeWVVUWcvODJQczR0TGhmemVmTmtjS0FHV29ROE5TMEs0ZEpURmtJ?= =?utf-8?B?WDIxMm9NSmxHSU5tMU10ZTNxTGZkZkhaaExJY0tWMzRLdlRSL0FNdTBYQzVI?= =?utf-8?B?WWFNUlhnV1lmamh0eUpZaGFhcDlabTNuanpjNDk3b0NjUUEzTnFybkwyVE4v?= =?utf-8?B?a2Y1YnV1cGJSTTNFbFZsbnF4TXlWT2YxQzJxemlqQzd1UVNHNFF4dWdRN013?= =?utf-8?B?TGNGcUJGSDQwdnpLOUNXS2NSSk1RcDJWZWI3Y25kaGI1dzBCR08rQkRRMDcz?= =?utf-8?B?ZTBxaTdrQVg2Mis5V3p3aXdnTW44ZEF1NUhBWEc5Z0puQ2xHbnZ0aHk1b2N6?= =?utf-8?B?YkxJQ2xQNldTZGttSW9ENGYxYTE2RFZ6RjMrWHlCVnV1RjZvaXpyWTUvbWRr?= =?utf-8?B?b0RLTFk1aVBDRjNZWjkybkFhS3dubEp5dEpCM0cyRFdNK0RmOHNuZmZZYTgy?= =?utf-8?B?Y2tmWFpNcWo2MStXU0IveVhTRXJVK3VFSGJKOVFiMjBzWnRqdnVhQmExNGlz?= =?utf-8?B?WHRwUjBTUkpsd0xlN2pIL1I2Qm9PVFhCYlp0M2hMTXh6aDJsaEF1VXlJYUx6?= =?utf-8?B?M0wrYkxXM2NvSFJmdHAvMDNCMHJ1ZW41REdFaURCa2FUTTQvTkJHdEVqRHQw?= =?utf-8?B?N2FQWW9SS1h5MWFqaHgya3paWVRVN0c4eVRKQkZuUWowbnJrYzIrMnd0UCtu?= =?utf-8?B?ZVpoSlk0V1djS215bDhEVVhCdWFGejZBNmMzRFFqenFwTy9xSnJ4SE5iVVpq?= =?utf-8?B?TkRGNys4Zm84cWZqbWtoNHA0SnJ3dDhnNk9BUTVYMyttS0hPRDBzT2ZlTnIz?= =?utf-8?B?NzNhVVNKcTJOemRaeU11YW9rWEZaOVJ1dTlUaU92b2xhbFJEcU1PWFZ6Q2Jr?= =?utf-8?B?RVkzeW1vNE9OUm9seU1mckN2clp5eHpicThrQ2xkckxpUjhnYy9RZmdmMktH?= =?utf-8?B?ODlBV01yVUd3WktXWitmeDd4NEVTcEhmMkZWK3FWd1N2TVFGY2FtYTZJZVYx?= =?utf-8?B?c1JpUHA0RVRCVkY2TDNDb1dwK01oR1hOZXh1VDVub2VzOTlSbForejM1VG01?= =?utf-8?B?T1V1bmhBc2FYazNNa0NoZVgrTG1rdTgvajJxa1pYMnBKWjNnNU55SkJFbVJO?= =?utf-8?B?N1FaZjdaRzBnbjNPWk5tMXNqTUlhVGVOUEVyeW82ZU5iNnR3dXB3b1ZxUVYr?= =?utf-8?B?M09zNEZkQXVENXRVTmFtSzl4VUc5WnAvdWJYRDIwZmVtWTBjZmY3S01LY0sr?= =?utf-8?B?aWZUV3ExUDBqTUtTMksxYmRoazdIWWRBQ1JYamx4UE1Id2hrNy9zM1M1NklE?= =?utf-8?B?TEI5NmNyODd3UFhaeHUyUVhGaFJ4dnBqZlFFV0MybXptUjFsdXQxVWJmQnNq?= =?utf-8?B?WFhHV1hWY1dYOFVab3NuRUpCdStWQWNSZ2pselNrYVhab2F0WkVaVE01d3Nv?= =?utf-8?B?em1za2o0WGMyVDNwaWc1aFhDR3duUUdOL1JQa3hUVHBEeDVXV05vbjUzRWRv?= =?utf-8?B?THJJS0duM2JURkxrMWZUUFJjdXNXTW5ERFlFRitOY2EyZXAzUnd4aFF6dlZo?= =?utf-8?B?SnB6VTNCYUFXTWtnbkNNemI1MThCbGZqc1lPbHp1ajhnNHY3emlSMW9jY1FT?= =?utf-8?B?bThET1ZVYmNuSTZBYXRKM3FINnRlVHVTdFBRbmZQbmdoeDFtQUh4bUxYMXly?= =?utf-8?B?MnpYS244dU1weTA4d0VmeWtYdGc2cVhiNEk5dFlCTzc3MklaTDV3OUk1TXRW?= =?utf-8?B?MWEzaWtoTnJyTE1DTUd6WDNZQ3gwOHJGTmJ5Szg2cElYN014UVVmS0M1YlZU?= =?utf-8?B?aUpkOUtoNUYwZlg1dUlOeUFIckdIclVHSTh6MjVTV2NBNCt2T0c1OUhJQ3hZ?= =?utf-8?B?Y3dDUkhsUElhSzM2UmJYc2szb0o4TzVkRldvSU14VVpMRGFYL21hVlYzZ25B?= =?utf-8?B?RzlFTFkyUGpVb2U5cVFEOWJLYnIzaGxmeUc3eDhFNEI1OXZ6ZXpWUVNxcDZl?= =?utf-8?B?VlJXdDRKZGlwMGZWTVR0cEJXQXhwbGZVSUQzWmVhRnhsSUpvWGFnNXBsU2Yv?= =?utf-8?B?ZTE3em9IWndHWGZEUE9JNStZM1o2aDBSbjVLNjdEM3dkMG5Gck5YV2dRNHhq?= =?utf-8?B?TjZwTWRFRkRQSkxHZkMvdXF5R1NvUk02bHQ5UUFIMHc4MVNsYlRZQ0krdUtw?= =?utf-8?B?NDVPWVJSQnJkUER1NGlSQWNkR0owTndTSXc4Zlc5Qm1xdktuaXJDZktyQ2N2?= =?utf-8?B?U1pwZks1blcwK0hkU09RWjM0QmRwZiszaEU4aEs3WjVDYnZzcGNFK0xhcjUz?= =?utf-8?Q?xiQe79Zpe67B+5I+CO?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33cb938d-aa34-408e-7781-08de58cbb2de X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2026 09:01:43.8381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IgvmYVRuJtV7p6syBXVbcFRBtESgoUo0BvgMqViljvl6311SoHk3JUYxNAPseTSk X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6361 On 1/20/26 15:07, Leon Romanovsky wrote: > From: Leon Romanovsky > > IOMMUFD does not support page fault handling, and after a call to > .invalidate_mappings() all mappings become invalid. Ensure that > the IOMMUFD dma-buf importer is bound to a revoke‑aware dma-buf > exporter (for example, VFIO). > > Signed-off-by: Leon Romanovsky I don't know the code well enough for a review, but that looks totally reasonable to me. Acked-by: Christian König > --- > drivers/iommu/iommufd/pages.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/iommufd/pages.c b/drivers/iommu/iommufd/pages.c > index 76f900fa1687..a5eb2bc4ef48 100644 > --- a/drivers/iommu/iommufd/pages.c > +++ b/drivers/iommu/iommufd/pages.c > @@ -1501,16 +1501,22 @@ static int iopt_map_dmabuf(struct iommufd_ctx *ictx, struct iopt_pages *pages, > mutex_unlock(&pages->mutex); > } > > - rc = sym_vfio_pci_dma_buf_iommufd_map(attach, &pages->dmabuf.phys); > + rc = dma_buf_pin(attach); > if (rc) > goto err_detach; > > + rc = sym_vfio_pci_dma_buf_iommufd_map(attach, &pages->dmabuf.phys); > + if (rc) > + goto err_unpin; > + > dma_resv_unlock(dmabuf->resv); > > /* On success iopt_release_pages() will detach and put the dmabuf. */ > pages->dmabuf.attach = attach; > return 0; > > +err_unpin: > + dma_buf_unpin(attach); > err_detach: > dma_resv_unlock(dmabuf->resv); > dma_buf_detach(dmabuf, attach); > @@ -1656,6 +1662,7 @@ void iopt_release_pages(struct kref *kref) > if (iopt_is_dmabuf(pages) && pages->dmabuf.attach) { > struct dma_buf *dmabuf = pages->dmabuf.attach->dmabuf; > > + dma_buf_unpin(pages->dmabuf.attach); > dma_buf_detach(dmabuf, pages->dmabuf.attach); > dma_buf_put(dmabuf); > WARN_ON(!list_empty(&pages->dmabuf.tracker)); >