From: "Heiko Stübner" <heiko@sntech.de>
To: linux-kernel@vger.kernel.org,
Detlev Casanova <detlev.casanova@collabora.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
Jonas Karlman <jonas@kwiboo.se>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Niklas Cassel <cassel@kernel.org>,
Alexey Charkov <alchark@gmail.com>,
Dragan Simic <dsimic@manjaro.org>,
Jianfeng Liu <liujianfeng1994@gmail.com>,
Detlev Casanova <detlev.casanova@collabora.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Umang Jain <umang.jain@ideasonboard.com>,
Naushir Patuck <naush@raspberrypi.com>,
Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,
Dmitry Perchanov <dmitry.perchanov@intel.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, kernel@collabora.com
Subject: Re: [PATCH v4 6/6] arm64: dts: rockchip: Add rkvdec2 Video Decoder on rk3588(s)
Date: Tue, 08 Apr 2025 15:16:05 +0200 [thread overview]
Message-ID: <9432379.CDJkKcVGEf@diego> (raw)
In-Reply-To: <20250325213303.826925-7-detlev.casanova@collabora.com>
Hi Detlev,
Am Dienstag, 25. März 2025, 22:22:22 Mitteleuropäische Sommerzeit schrieb Detlev Casanova:
> Add the rkvdec2 Video Decoder to the RK3588s devicetree.
>
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---
> + vdec1_mmu: iommu@fdc40700 {
> + compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu";
> + reg = <0x0 0xfdc40700 0x0 0x40>, <0x0 0xfdc40740 0x0 0x40>;
> + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&cru ACLK_RKVDEC0>, <&cru HCLK_RKVDEC0>;
> + clock-names = "aclk", "iface";
> + power-domains = <&power RK3588_PD_RKVDEC0>;
> + #iommu-cells = <0>;
> + };
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
index 24ecbff06cd27..8bde8e257eac9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
@@ -1395,7 +1395,7 @@ vdec1_mmu: iommu@fdc40700 {
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH 0>;
clocks = <&cru ACLK_RKVDEC0>, <&cru HCLK_RKVDEC0>;
clock-names = "aclk", "iface";
- power-domains = <&power RK3588_PD_RKVDEC0>;
+ power-domains = <&power RK3588_PD_RKVDEC1>;
#iommu-cells = <0>;
};
Needs to use the correct power-domain, otherwise ends in SErrors on 6.15-rc1
Heiko
next prev parent reply other threads:[~2025-04-08 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 21:22 [PATCH v4 0/6] media: rockchip: Add rkvdec2 driver Detlev Casanova
2025-03-25 21:22 ` [PATCH v4 1/6] media: v4l2: Add NV15 and NV20 pixel formats Detlev Casanova
2025-03-28 23:09 ` Diederik de Haas
2025-04-08 21:08 ` Nicolas Dufresne
2025-03-25 21:22 ` [PATCH v4 2/6] media: v4l2-ctrls-core: Set frame_mbs_only_flag by default in h264 SPS Detlev Casanova
2025-03-25 21:22 ` [PATCH v4 3/6] media: rockchip: Move H264 CABAC table to header file Detlev Casanova
2025-03-25 21:22 ` [PATCH v4 4/6] media: rockchip: Introduce the rkvdec2 driver Detlev Casanova
2025-03-25 21:22 ` [PATCH v4 5/6] media: dt-bindings: rockchip: Document RK3588 Video Decoder bindings Detlev Casanova
2025-03-27 8:04 ` Krzysztof Kozlowski
2025-03-25 21:22 ` [PATCH v4 6/6] arm64: dts: rockchip: Add rkvdec2 Video Decoder on rk3588(s) Detlev Casanova
2025-04-08 13:16 ` Heiko Stübner [this message]
2025-04-08 18:34 ` Jonas Karlman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9432379.CDJkKcVGEf@diego \
--to=heiko@sntech.de \
--cc=alchark@gmail.com \
--cc=andrzej.p@collabora.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.perchanov@intel.com \
--cc=dsimic@manjaro.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jeanmichel.hautbois@ideasonboard.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=liujianfeng1994@gmail.com \
--cc=mchehab@kernel.org \
--cc=naush@raspberrypi.com \
--cc=nicolas.dufresne@collabora.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sebastian.reichel@collabora.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox