From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Linux USB <linux-usb@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [RFC/PATCH 30/45] media: usb: uvc: remove unnecessary & operation
Date: Thu, 29 Sep 2016 12:19:08 +0300 [thread overview]
Message-ID: <9458858.X6S0nte73o@avalon> (raw)
In-Reply-To: <20160928130554.29790-31-felipe.balbi@linux.intel.com>
Hi Felipe,
Thank you for the patch.
On Wednesday 28 Sep 2016 16:05:39 Felipe Balbi wrote:
> Now that usb_endpoint_maxp() only returns the lowest
> 11 bits from wMaxPacketSize, we can remove the &
> operation from this driver.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: <linux-media@vger.kernel.org>
> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/usb/uvc/uvc_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c
> b/drivers/media/usb/uvc/uvc_video.c index 11e0e5f4e1c2..f3c1c852e401 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -1553,7 +1553,7 @@ static int uvc_init_video_bulk(struct uvc_streaming
> *stream, u16 psize;
> u32 size;
>
> - psize = usb_endpoint_maxp(&ep->desc) & 0x7ff;
> + psize = usb_endpoint_maxp(&ep->desc);
> size = stream->ctrl.dwMaxPayloadTransferSize;
> stream->bulk.max_payload_size = size;
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2016-09-29 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160928130554.29790-1-felipe.balbi@linux.intel.com>
2016-09-28 13:05 ` [RFC/PATCH 13/45] media: usbtv: core: make use of new usb_endpoint_maxp_mult() Felipe Balbi
2016-09-28 13:05 ` [RFC/PATCH 14/45] media: usb: uvc: " Felipe Balbi
2016-09-29 9:18 ` Laurent Pinchart
2016-09-29 9:44 ` Felipe Balbi
2016-09-28 13:05 ` [RFC/PATCH 30/45] media: usb: uvc: remove unnecessary & operation Felipe Balbi
2016-09-29 9:19 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9458858.X6S0nte73o@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).