From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D37A4ECAAD8 for ; Thu, 1 Sep 2022 06:43:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233058AbiIAGnR (ORCPT ); Thu, 1 Sep 2022 02:43:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbiIAGnQ (ORCPT ); Thu, 1 Sep 2022 02:43:16 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2078.outbound.protection.outlook.com [40.107.96.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EC62EC4EF; Wed, 31 Aug 2022 23:43:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NlbEqlzIUryh4KgTo++IrToJsynFPu+IHOxrDSWVQbIzGFyJxJzl1D/QFs9czFgtVF/AcFlGdI2XuI2Tyu+p0O/7Vw3sjWlWY6dbgxStkMXOOoKH6GXb0SqODpEyNb+VFy64z6p09Kc5J08xRJ41bY/8DyZeI1hyCDpVWp1rj/juuF5IDCRfXuBQMfVNtpwf78+K23umkZtnMqpaG0EnLj0+ZpIHtI+R+hnGgu/eeJBk57Eokcq8gdbXMi4a4bV5k/vSczNGwb4IBqaLd6q4HmVgupdyKmG/8y4U2/9syR+AuXCq1ijuXeKZx4RbLB5GTr4Rv0BAVH1oQ7fVX3Gfig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jW/4dsfkyJHvzunZ8Qr1OE9RrXwjgietc84hD0UVTxs=; b=isB5tFA79gE6q/RLG4ASQjYXh3fcT/h842zLfGszPWm4UzXcGdWjA0FcLsGhfmzCNal9un3kGwtCVauRZrhqri3RtHidLSYtpM/msWxNdcRtRU7z3y05Fgklj6wD7mxn793uwYuls6MB6Z/XpaBvd2Z3xQ3LGa96eBIk3R4ugBtPXKVEhK4voMr7gGvxd2a59HI5SeF2fUN/rUbaIzy7VxbWqw/5c/vy85F++3wmil0oBbbJ+062VA3iFlS8p8K5ok7J4IspkSvXA1GBtVFwpSRqSoz7nmC3+E4uucs/2cERBTbsmhJc1Yb1xIvn/lYl0Dj91b969hccVM/QfXWzSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jW/4dsfkyJHvzunZ8Qr1OE9RrXwjgietc84hD0UVTxs=; b=W4XRsd5KBgPJ1nIoyCAitmJMegjrxnxlAwGvpwY+G5Gkl0CUX1FubXCsbavg5ZbN8qaOt1CclM0JbICo5BIE63bgRsLt1TGRZEY+rCr99e/FluBNfghEHiCj83RnOk7uDohP9CVb/3tp08uUyuFb1ZLq3bLqCSAHy1Mmr+6XphA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) by CH0PR12MB5156.namprd12.prod.outlook.com (2603:10b6:610:bb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 06:43:13 +0000 Received: from BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::4524:eda6:873a:8f94]) by BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::4524:eda6:873a:8f94%7]) with mapi id 15.20.5588.011; Thu, 1 Sep 2022 06:43:13 +0000 Message-ID: <94cdb302-98ea-2f8d-8bdf-cf81b45dddc1@amd.com> Date: Thu, 1 Sep 2022 08:43:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 05/21] drm/armada: Prepare to dynamic dma-buf locking specification Content-Language: en-US To: Dmitry Osipenko , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gert Wollny , Gustavo Padovan , Daniel Stone , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Sumit Semwal , "Pan, Xinhui" , Thierry Reding , Tomasz Figa , Marek Szyprowski , Mauro Carvalho Chehab , Alex Deucher , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , Qiang Yu , Srinivas Kandagatla , Amol Maheshwari , Jason Gunthorpe , Leon Romanovsky , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Tomi Valkeinen , Russell King , Lucas Stach , Christian Gmeiner Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Osipenko , linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kernel@collabora.com, virtualization@lists.linux-foundation.org, linux-rdma@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20220831153757.97381-1-dmitry.osipenko@collabora.com> <20220831153757.97381-6-dmitry.osipenko@collabora.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= In-Reply-To: <20220831153757.97381-6-dmitry.osipenko@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8P251CA0024.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::27) To BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25ae735a-7f2d-402d-ccc1-08da8be53e1e X-MS-TrafficTypeDiagnostic: CH0PR12MB5156:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7JUwmDosFFkFPrS256EHWy7zdlth6Ub+ZUrIpy3rH9uB7LnVNZZcMiWidd0zKEqsKe1zW/6cakddruWIbh0mHeLL9c8/VmsEIBsfvqFd0RWMswn2rGYvqF3Yw3ZvkLeu68oYTm9bbGp1WvcUPsjyAup7MPv24EonmOdHw7+oyk14D3xrJvG1GszW4R5+rc9KGozyw6q+ruqwo4r8M1O98o4ZqRsKaWCIJ0cKkwcjBJ3t8mygdeINgV0GMIrOtd2nilhNcBd9OzciPUYM5suaMp1rgYDA2//HYhNij4SdlRQUtryebgJgSyZqwt7jrcSCqk8rLSrZPyxZDKPLsv3Y1EpN845oAYRGshke5N603ACFp9V36hnNEcAD0X0vA8fey1SzGXlU29GK70JsOIUCf7X7qAm3S3OhWDho/opnRdvve16YqXGIC22JBjU/EBF5F+Ynm7DIBtyqshRsMHh173YAxwN+F1UNp2pPFVF7ho4Qr0xDxmucZLiKnZ/N6C1NtMuS9lHjp2BgF/EP6KuSHZhuSKs2PkLCDpuRaX4SdavoJe7goDCKf1GlJABzu3EADAJgGiZ8/G8AZkV5R9szqG3sydeZfIYlwhLrp1g7y4kHvLQvkWQusbX+P2k8lOzUzppL9+sgAHpgxL6dInc4yo1X0sntz9/qc+5+dz0yFbLTcr42+rxhm5V8F9n5ipf0gtAgvv3oSx3zo5pk4wNNnYVqw37gp+zn/hYC0rMucVrDI+LVXIbzsa3Xiz4h+nAqiMZVOW5wjkZGuHZhTBxwifmZ9WFZlIO3Au6jI5XLwUaqwXlFot0sW0VA5IBRhl1B X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN8PR12MB3587.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(376002)(136003)(346002)(396003)(39860400002)(5660300002)(83380400001)(36756003)(316002)(6666004)(31686004)(7406005)(7416002)(66574015)(110136005)(186003)(38100700002)(41300700001)(6512007)(86362001)(8936002)(31696002)(8676002)(2616005)(4326008)(6506007)(66476007)(66946007)(6486002)(478600001)(26005)(66556008)(921005)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVp4MEtkMmlDV3pHeUVEYU43azJndnpqNis5TGtKZThCbjRwVmUySzJrcGNB?= =?utf-8?B?YmNRbnlTR0tqV3FMSEtKLzN2M0l0T3U4eHZ1Nmw2RnN4ZGhHS0pXQUs0cVZR?= =?utf-8?B?ZGpmeFI0TldHaU43WWxJcVFoUDk3T1BaZFk3RUNpL1A0MjVteC93VmFsbjVT?= =?utf-8?B?Z1BTVjNkakMxZHFGSThNRUpEdG9wdWI4MVlwa2pzcjZUMDRXVFRUSlB1NHJq?= =?utf-8?B?RlM5U0h2THVQa2YrVStzMEtFTW9HUkxtMlRFWUNKQVJLTzBFQVFDNFBpd3lM?= =?utf-8?B?ajRhZmZIa3NzaVZoK3BUMjR6MmhSZ3FNdVVaVTRQb3RtWVNDVXBmT1FvMGU4?= =?utf-8?B?VDVmYmZvdnZiM3Rhd0R1ZkcvbUhVTi94RGFKZGRGZ3MvR2o4SFZmVG1qU2Fj?= =?utf-8?B?SFB6VWNnNFp0M1EvdGFrUDNFeWlZSEJmUExiWUJmVUVTYlVJQXNBeXU5Vjdy?= =?utf-8?B?Rnd0a2pSbE5BbFllcWxYTTdQbVRvN004bjc5QjdTYis2N3NudlFzRzlObTE3?= =?utf-8?B?dysyR2JNYXJsN1h6bzJhY3F3VDE1NUQ2QUlSM1k4dCtJenR5QXdhdEN4ZFNr?= =?utf-8?B?YnlwR0E3ME1oM0NzYkJRRVRIcDRPTU1uV3J4Tjl5SjZrNmlpczVIL2tXbFRW?= =?utf-8?B?dkpXMmNVSGdzMXQ3VHF3b2E0Vnc4WDhwYVB1WG81ai9pejBHM2JMR2liY05H?= =?utf-8?B?eUFqTjVOSWtBaGEwbmpUcnN1bndPWnJoV2tlSE9vSkthVkRHRGVzRDd2VStq?= =?utf-8?B?U0Vxd1BCZ08vVWc5aEROdXVvZkFjYmVwN3RoNFc2aEQ1K3d3MmprODErUk9I?= =?utf-8?B?UHRxdWZUYXYwMUxBaVRCQmxmclZhbG5QZ0hua1ZlcUVHdlY4cXJ6V2FqWVlI?= =?utf-8?B?dFRnWmU5Q05FM3RxTVFHcUV2RG5XZWt6MTd0cFZ0L1haN2xQZFZ5TVQ4U2xH?= =?utf-8?B?dWtYTjN0d2JhOHdsK1p6NkdYUWdYckdMS0JqNXBud2hieUJzTFZIQ2p6STRT?= =?utf-8?B?Q2sweTJjeVJqdjdUdTV4aWl6dmkrSWR0b01nRGJWYmtXY2ZCWHJqbWlML0ZI?= =?utf-8?B?dFVOU3Z0MWprd0tOSUUzT2lsNzVtVUs3R01icjZPQzY4eUFxcXNYbkdFRzRL?= =?utf-8?B?aUkyWVZZQWxqaU9KNXhPeDUwWkFxclhFSkhrcVVubmh3TUZGamJmT2FkaVl3?= =?utf-8?B?QisyTTlZckQ5bWIrWU1hc3ptaEM1SjJBQzZXVXVyYTcrRjJZZ3RYY1JqdHNM?= =?utf-8?B?MUVpQStxajVIMytyVHR1TWY3bSswRm5MNzRLVlpCWVZneG5ETWo1Ylh2R2Fa?= =?utf-8?B?Z2l1VEpyeUtUTWtGZ25xUDBqb1N6TkJ3bmlVSTd5RzdpQm9ZY3pjQVh2NDFI?= =?utf-8?B?L3FrczBDRy9NRm42SzNSZld6eGxEMWZ3bTFxRmFkSzZiWitmeEJWZFF0dHRa?= =?utf-8?B?M0dENFUwQllsK3Y5bEN3MmtBRGtFN1JLaGdwZmRkbmxlTUlNaVVSOWI2QzhB?= =?utf-8?B?bFJPVTJxWjV3c3ArWDRNUGhoK1NPM1lXU29sZHZVUDQwL3c4MDMzRmdBNGRT?= =?utf-8?B?RkdZeTAxQW5rTTc5OFVqRm5TN0l6Mlo2QXhYbjBmSXY1VWxhN29jZzB4TVNN?= =?utf-8?B?TktVdTk1eTVaV0d4RkFLTlo4cmRFZkZjVDdNR3cxYk1oRVFiekp0N1ZZenZ2?= =?utf-8?B?RlJ0RmR2ZWp3alZ2RkZQY1dxallQdEhWdkxTL01vWEFFeXBLdnNJRCtaaGNz?= =?utf-8?B?NmhkYTB0SGJHZlJ4MWh4bkRtdm9pQW9IcnhDZ3NUSVAxeUJRV0NneGxzdUpO?= =?utf-8?B?SjR4dGJaKzBQanYwU2pqeC9JUzdEUnkxeUtvL2pVdTN5MXBlcVRUcmZ3amF6?= =?utf-8?B?RE5PVzFuSjBTbmt0STZUajhUWGhNck5VOFBLcGFLQk1kZVlEd2JFTm9WMHBt?= =?utf-8?B?OHZhYWtWVzl2dFpCbk5jR2Urb1FKUWdGb05KYjJOUUJvaWQvQWI3YTZzMU54?= =?utf-8?B?eW5BcGRaTUdNdS9JN25VekZMeXN5WXFzdXJkOFVjZThERXhLdkRVemh3ckxs?= =?utf-8?B?dFJ0NWpsU0VxSE1wWkVaN1BNWXVrdEczbW03VGpzRnc2Vm1lZDk1Mkx6VmNQ?= =?utf-8?Q?trMV3gWCXJHC/iDBIP6nnjaJx?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25ae735a-7f2d-402d-ccc1-08da8be53e1e X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 06:43:13.4355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AulUexLYpzl72xOD6yOBuYcVnSKwfakmvRqXDY1U1BArPusLF1h2FYIRut6joxsX X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5156 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Am 31.08.22 um 17:37 schrieb Dmitry Osipenko: > Prepare Armada driver to the common dynamic dma-buf locking convention > by starting to use the unlocked versions of dma-buf API functions. > > Signed-off-by: Dmitry Osipenko Acked-by: Christian König > --- > drivers/gpu/drm/armada/armada_gem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c > index 5430265ad458..26d10065d534 100644 > --- a/drivers/gpu/drm/armada/armada_gem.c > +++ b/drivers/gpu/drm/armada/armada_gem.c > @@ -66,8 +66,8 @@ void armada_gem_free_object(struct drm_gem_object *obj) > if (dobj->obj.import_attach) { > /* We only ever display imported data */ > if (dobj->sgt) > - dma_buf_unmap_attachment(dobj->obj.import_attach, > - dobj->sgt, DMA_TO_DEVICE); > + dma_buf_unmap_attachment_unlocked(dobj->obj.import_attach, > + dobj->sgt, DMA_TO_DEVICE); > drm_prime_gem_destroy(&dobj->obj, NULL); > } > > @@ -539,8 +539,8 @@ int armada_gem_map_import(struct armada_gem_object *dobj) > { > int ret; > > - dobj->sgt = dma_buf_map_attachment(dobj->obj.import_attach, > - DMA_TO_DEVICE); > + dobj->sgt = dma_buf_map_attachment_unlocked(dobj->obj.import_attach, > + DMA_TO_DEVICE); > if (IS_ERR(dobj->sgt)) { > ret = PTR_ERR(dobj->sgt); > dobj->sgt = NULL;