public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Daniel Roschka <danielroschka@phoenitydawn.de>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] Quirk for webcam in MacBook Pro 2016
Date: Mon, 10 Apr 2017 13:52:21 +0300	[thread overview]
Message-ID: <9504811.tIhrXQ8rYn@avalon> (raw)
In-Reply-To: <2780663.rcqhCkWply@buzzard>

Hi Daniel,

On Sunday 09 Apr 2017 19:43:22 Daniel Roschka wrote:
> Hi Laurent,
> 
> I don't want to sound impatient, but I as I don't know what your usual
> reaction times to patches are and already waited three weeks without any
> reaction, I kindly want to ask, if you already had a chance to look into
> this patch and consider it for inclusion into your tree?

Thank you for pinging me, the patch was indeed buried under a pile of other e-
mails :-)

Your mail client (or server, I don't know) mangled the patch by replacing tabs 
with spaces. As the patch is short I've fixed this manually, but next time 
please try to fix the issue on your side.

Another small issue is that the commit message should be wrapped at 72 
columns. Depending on the text editor you use, git commit usually does that 
automatically for you.

I've also added a "uvcvideo: " prefix to the subject line, otherwise short git 
logs wouldn't be very clear. As a rule of thumb, your subject line should 
contain enough information to understand which driver the patch relates to, 
and what it does.

Your patch is now in my git tree, and I will push it upstream for v4.13 (v4.11 
will be released very soon, and given the pending pull requests for v4.12 in 
the Linux media tree I don't think I can add another one).

I collect USB descriptors for UVC devices. Could you please send me the output 
of

lsusb -d 05ac:8600

if possible running as root ?

Thank you for your contribution !

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2017-04-10 10:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-18 21:02 [PATCH] Quirk for webcam in MacBook Pro 2016 Daniel Roschka
2017-04-09 17:43 ` Daniel Roschka
2017-04-10 10:52   ` Laurent Pinchart [this message]
2017-04-10 18:01     ` Daniel Roschka
2017-04-11  5:07       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9504811.tIhrXQ8rYn@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=danielroschka@phoenitydawn.de \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox