Re: [PATCH/RFC 1/4] ipu_idmac: code clean-up and robustness improvements

[Agustin <gatoguan-os@yahoo.com>]

Guennadi,
> Guennadi Liakhovetski wrote:
> 
> From: Guennadi Liakhovetski 
> 
> General code clean-up: remove superfluous semicolons, update comments.
> Robustness improvements: add DMA error handling to the ISR, move common code
> fragments to functions, fix scatter-gather element queuing in the ISR, survive
> channel freeing and re-allocation in a quick succession.
> 
> Signed-off-by: Guennadi Liakhovetski 
> ---
> 
> As mentioned in PATCH 0/4 this one is only for completeness / testing 
> here, will be submitted separately to the dmaengine queue. Dan, would be 
> good if you could review it here to save time.
> 
> drivers/dma/ipu/ipu_idmac.c |  300 ++++++++++++++++++++++++++++---------------
> 1 files changed, 196 insertions(+), 104 deletions(-)
> 
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index 1f154d0..91e6e4e 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -28,6 +28,9 @@
> #define FS_VF_IN_VALID    0x00000002
> #define FS_ENC_IN_VALID    0x00000001
> 
> +static int ipu_disable_channel(struct idmac *idmac, struct idmac_channel 
> *ichan,
> +                   bool wait_for_stop);
> +
> /*
> ...

Thanks a lot for the patchset!

I am having some stoopid trouble while trying to apply this patch to 'mxc-master':
$ patch -p1 --dry-run < p1
patching file drivers/dma/ipu/ipu_idmac.c
patch: **** malformed patch at line 29: /*

Looks like your patches lost their format while on their way, specially every single line with a starting space has had it removed. Or is it my e-mail reader? I am trying to fix it manually, no luck.