From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471F7ECAAA1 for ; Mon, 24 Oct 2022 16:32:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233241AbiJXQcW (ORCPT ); Mon, 24 Oct 2022 12:32:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233506AbiJXQbj (ORCPT ); Mon, 24 Oct 2022 12:31:39 -0400 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02F081F611; Mon, 24 Oct 2022 08:18:15 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id ABA773200956; Mon, 24 Oct 2022 09:33:00 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Mon, 24 Oct 2022 09:33:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1666618380; x=1666704780; bh=yALotGF5gu 2PaCNV/egtd+i3//YX5Y+ckq5ZuUGJVS4=; b=CGcKm8uy7pXuNtC88a+pdrGRCB k/M0r+ucQbVt2z7aNyBAR6pRBZw8NJs567YzTVed5NyNRhbcaXHwOuocNqvkUY1Q a68YYRB/kKOAn6neyz323y+AY0jABRus/GKs6ZnMGGzadubtLbobFzYRkyDscYbS vCDMVPpfg0mJkMo0dt3BPbxS9ISz4UETtXdTTqolJieAxJBZprtuBBFW7KWzQNwq b5d2/2R5JPt36BEgIYG/7w5fVNQB93HfHaAuyuzY3F4k1bSM1mk78MlxBoq0794c po8uCvWJYEsV2IuHpET+tTXFgicOU5us4NP4Qu4j6pJoahsQAacmTync8TwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666618380; x=1666704780; bh=yALotGF5gu2PaCNV/egtd+i3//YX 5Y+ckq5ZuUGJVS4=; b=EYkrsuKQaLFIHyQdtqIYcx3apZCF9wBdNRpj+GJSpPB9 JkwjAsVrrY+8/LBhMLw2UdwaSO1W0CtV3JXA0M1ZcZjmWYGiVLpHXQ4TQ/N+Bs9+ FMO23IyPIUW5t2ttBK83GiHdDUQP5TYkVh0mAUKrMNBwg+uTrfY41l4PYZOuUU58 CHYsg0MyFCHjagA3vA8/qECW16h3s6jqrbPHqZZQKa3MsWPDCBNYL2GD7bnWj0K7 q/AAuW1ScFgFNBDiCUt6QRr+K76NWAMXWw+C94t+Udq1ws+LB/KWr+RXltGOJrqY EX9pCQ4ZjbGeCQ28d12waKezhvXypQmeT6IfOGlvlw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedtgedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 81B7CB60086; Mon, 24 Oct 2022 09:32:59 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1047-g9e4af4ada4-fm-20221005.001-g9e4af4ad Mime-Version: 1.0 Message-Id: <9912a1eb-ad12-4608-bf48-d74ac5f5805a@app.fastmail.com> In-Reply-To: References: <20221021202254.4142411-1-arnd@kernel.org> <20221021203329.4143397-5-arnd@kernel.org> Date: Mon, 24 Oct 2022 15:32:39 +0200 From: "Arnd Bergmann" To: "Krzysztof Kozlowski" , "Arnd Bergmann" , linux-arm-kernel@lists.infradead.org, "Mauro Carvalho Chehab" Cc: linux-kernel@vger.kernel.org, "Ben Dooks" , "Simtec Linux Team" , "Alim Akhtar" , "Mark Brown" , "Juerg Haefliger" , "Linus Walleij" , "Tomasz Figa" , =?UTF-8?Q?Heiko_St=C3=BCbner?= , linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 05/21] ARM: s3c: simplify platform code Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Oct 24, 2022, at 14:29, Krzysztof Kozlowski wrote: >> diff --git a/arch/arm/mach-s3c/Kconfig.s3c64xx b/arch/arm/mach-s3c/Kconfig.s3c64xx >> index c403d7642f0a..c52c7ce1d8fa 100644 >> --- a/arch/arm/mach-s3c/Kconfig.s3c64xx >> +++ b/arch/arm/mach-s3c/Kconfig.s3c64xx >> @@ -15,12 +15,9 @@ menuconfig ARCH_S3C64XX >> select HAVE_TCM >> select PLAT_SAMSUNG >> select PM_GENERIC_DOMAINS if PM >> - select S3C_DEV_NAND if ATAGS >> select S3C_GPIO_TRACK if ATAGS >> - select S3C2410_WATCHDOG > > This does not seem right. S3C2410_WATCHDOG is a driver used by all > (including Exynos) platforms. I don't remember why I removed this line, probably because I removed S3C_DEV_WDT after there are no references to that symbol left in board files. The watchdog driver is now DT-only with cragg6410 being the last remaining board file. Ideally we should not 'select' it from here but instead have it enabled in the defconfig file, but I agree that would be something to do in a separate patch, while the patch here should not change the behavior. I'll revert this part. >> @@ -121,10 +118,8 @@ config MACH_WLF_CRAGG_6410 >> select S3C_DEV_HSMMC1 >> select S3C_DEV_HSMMC2 >> select S3C_DEV_I2C1 >> - select S3C_DEV_RTC > > This as well. I'm fairly sure this can be removed along with S3C_DEV_WDT, S3C_DEV_I2C[2-7], S3C_DEV_NAND, and S3C_DEV_ONENAND as I remove the symbols due to the lack of references from cragg6410. I folded in this fixup now: --- a/arch/arm/mach-s3c/Kconfig.s3c64xx +++ b/arch/arm/mach-s3c/Kconfig.s3c64xx @@ -16,8 +16,10 @@ menuconfig ARCH_S3C64XX select PLAT_SAMSUNG select PM_GENERIC_DOMAINS if PM select S3C_GPIO_TRACK if ATAGS + select S3C2410_WATCHDOG select SAMSUNG_ATAGS if ATAGS select SAMSUNG_WAKEMASK if PM + select WATCHDOG help Samsung S3C64XX series based systems Arnd