From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9B6134F25C for ; Mon, 6 Apr 2026 06:01:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775455290; cv=none; b=UojTOtjBQAW4BqNUmZ9mqYtiiWDt1jnIl7muHytLElNufRF7BBJWKF0NfV6DLW/IBbaHAx5zXgTpOETceZ5QjCVamlUwiqR+DKdxm+YBaD2FIoJNoFbKUo8KezBOtYIBYJuFLUlhNk+afWLNk+QigxLL9xNpHl0YzrJR1w29O6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775455290; c=relaxed/simple; bh=JI5iBFaeeDL9bvBFn5OW16PUp/PhoYNUPLyuwYAhPbE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rwu0m5SS95RYJswKID1dcxB039BWQK3gj/P1zgvVeXMBn3+0SOR927YUGDAdNA6la9ujt3pyZqFOOQra+klp7LJeBu/FRmvG9GT11WMXt32aSBE+VyZrJ2e8AhvGYt69OyW+5XtdAjUxYEgxa9K4F8wJVa8gO5FSKlmCl+yCy18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U4x/P0HF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BXGJrD/t; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U4x/P0HF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BXGJrD/t" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6363blJY1017627 for ; Mon, 6 Apr 2026 06:01:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fwm+xGGl/6Zvyv3SDhLC4j3+IdrlWcFoiDrUY8cbwok=; b=U4x/P0HFUAUCmRM3 q8x0SX37jp4A47cWu4i+d33qO0pVFOhl2ngybzYjdNhCWHWKjwRhn4Mm5IMy4c8s TTY2cWqPwWDs+5ZYrUfU9bRtCdfv8y/nSy8sBIrmBqky0Vi/bRrIiZtL+GbV+mr7 3PYsH5Lb0W9iKNfpBn9vXx5K/VGNh0LFFN5Eo/Yh6lcu1gKomztUkEXuyqgGcslx Q3FUGfV7HRad8MVEb9VE2v63GoUxBSQrdFEHp3iWF0nHwuONRNLIRZd+2w3FPszT cpGGU+r3AGHdgwQr0XcpJS4e88JJ7yYUl6AnGWzwnp0gRh+T1V6ZVLlI7be3dVVV 7VXWFQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dat7uc1qr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Apr 2026 06:01:27 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35d90c7ec5aso9512176a91.2 for ; Sun, 05 Apr 2026 23:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775455286; x=1776060086; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fwm+xGGl/6Zvyv3SDhLC4j3+IdrlWcFoiDrUY8cbwok=; b=BXGJrD/tV23f4mVztm7ivkip28LkiV+88Udhb4MbDtVpPzzW3P1g2iKusrnObvivyk QDV9xm2MG7stTrkQYN1wrE8PAv71Ku7I1NQM+uViZlNERB26HuK9q/7xJgiPtfujebP8 SIrpl4XMakTvFO+CIfSDwrgAZNiiVPrdtshogMxj/9QZ+AoPf5noWrSQnAAzQQwcZem9 0huXD036E076AA4hQ7O0WR7VdCyyFudgVOtnVp0UQvy+gk19OqlcRBCMW1hDZswcKI8/ fQLfkQZyGROrj6sud7tHC40ZJHHdh4yjkGFRvvyJJ2KiXeOeta2nHeroKHENVWecA4ef St/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775455286; x=1776060086; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fwm+xGGl/6Zvyv3SDhLC4j3+IdrlWcFoiDrUY8cbwok=; b=aWYFJOX62VZC06BrT+lh0RCADlWd+nRS2OMUsDryePMvP1UOczLkalnQ9Xp6TSNWzr y8vdVIZWC+O50kJ4by8/3ObILDlCJJvIQn6dawvz0GEvQi+6XCIPH1y18xLeowvLc/9O qDCoGAT0mDtdFJWY6kDkS/CBzd7tpNf95R5wXfSfQqSwWLwsnviExfljjNvf4OOGF1sE m8/KvM9SBEYaXn4iaK7HU08wXvBJG04bzQbskuC8l9JCbceTBbw+CW/vVzI+XlO4sGLN eOjuWXPRMbUmAlDuyrftCRqFdKNLvt97BhrxSQFN7wc/PDLlxlhoD3wMgoAWZtB2P39X IRLA== X-Forwarded-Encrypted: i=1; AJvYcCVPfWJOM14FKFNj3LKaPDfA6CbYDLZcxkc3jmXawGGoA0a9ZkzaLqIFIaym5V7uPBdxILKpuHDlhg2A+g==@vger.kernel.org X-Gm-Message-State: AOJu0YwoBxcpDFXjAo8PI2QNnKDnWDZHBOFB8Wp/YsYbioB5IpI899OL 1Hh6c2CIv+AOLLmRQzzgMU1v9wmP1Ik/BPNgiw0NL+rU9AMU4zVdMoIqSOdbSX0Q3hegSmzBKcw Rhaven3wyM0yoyti/vxxY1WHS1KlT367vZ70tEKit2kQhGN+p7mheYMECkEqhyDhq3w== X-Gm-Gg: AeBDietmQtj54fvI2CKaEyxWOsxvRsb6l/aayHGrScjkY7wS6qvUnr7QPl060esOjai If7vuizidl5rB48NNqTzx6I5v6Gp7wIyX4KOS4d7seNxUYyHB/ocp6eyoVskILJ4JJHcy8C8SzI LUlCmo63NOqh9XGtiankkM+nBizdeY+EUvZptwTP+js66gc2HC0MkKTdgxi2L7Kgl+xOaHD7Be9 9mn5eBGnjbgcn3EPgkGjG3yhdEYU4wODwpR0uOEAyCn1ydDzWqAE7FMCZSIx/PH3v2+OMLjcin3 7U2v7ZKdFNfIl0v4hVdf51YOIgGuCO+JqIPxBKt7pQo0nM6Vft97s9VwHvfzo9jAD76LloVw9c7 yKRY+6AQLzFQnNoj9PzdK0Y7xQNES6WW6b7FA6TRjyAnrYaK9JCRgIA== X-Received: by 2002:a17:90b:4c11:b0:35c:936:d4cc with SMTP id 98e67ed59e1d1-35de691ac07mr10924891a91.14.1775455286500; Sun, 05 Apr 2026 23:01:26 -0700 (PDT) X-Received: by 2002:a17:90b:4c11:b0:35c:936:d4cc with SMTP id 98e67ed59e1d1-35de691ac07mr10924859a91.14.1775455285979; Sun, 05 Apr 2026 23:01:25 -0700 (PDT) Received: from [10.0.0.3] ([106.222.228.245]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe624756sm22179416a91.5.2026.04.05.23.01.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Apr 2026 23:01:25 -0700 (PDT) Message-ID: <9afa1b06-2b10-2b99-0918-a6add4632f96@oss.qualcomm.com> Date: Mon, 6 Apr 2026 11:31:20 +0530 Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/3] media: qcom: venus: relax encoder frame/blur dimension steps on v4 Content-Language: en-US To: Renjiang Han , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab , Alexandre Courbot , Stanimir Varbanov , Tomasz Figa , Hans Verkuil Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab References: <20260331-fix_venus_bug_issue-v1-0-e4ae7a1d8db2@oss.qualcomm.com> <20260331-fix_venus_bug_issue-v1-2-e4ae7a1d8db2@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260331-fix_venus_bug_issue-v1-2-e4ae7a1d8db2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA2MDA1NSBTYWx0ZWRfX7nrEVAIMdUyx P8eSPh3TrpyMGwpyhD3xneMi2TzPgq6oJJqFyFMRr+vccXnFRAZFItNS1K2XYMmaOkxmD33hLiy w7JpO8pXFtT79jUTSGTQKXzAnZXGQYySfteVMKoDaWLXOPPN8IjuDUtDjMXxOpYshF2J2ffHaq7 yexch1DPxJta0saHDdQGkq/7ygYTLD8GLKS551KToj/RJ7hpO9Iu0HK1z7OCYxZzgt+hZ9Q2BRe 8LfOxokDCo7KvvPkGX+Skgas7Rx2JmH6f/1hdXIYgtZKjAkBPipG3diDe1ITQC3raw37upRA0qY HHfx03OIIvICkBbMIZZnPKWj1j7+27yw7yMlWnazrWIra1bVzg2aNZn9fOtqW7To1BWy0BbdIjs 3Wk7gLpe4qdMNucmr43Bb0PoEbqJYAIqUY0/M7DvyXYqNp50V4lOU9uJyJXmEmOQc6P9QMQcBlb QLwommNMtlLUksqwVRw== X-Proofpoint-GUID: 4SWIWsk1SLeHrrCY3pmPu5_YO43U9hX9 X-Authority-Analysis: v=2.4 cv=RJ2+3oi+ c=1 sm=1 tr=0 ts=69d34c37 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=AZq5V9zQ+e7Vr/IEUKe0sw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=LJ3xZjtEJ-EMi3p6IU4A:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: 4SWIWsk1SLeHrrCY3pmPu5_YO43U9hX9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-06_01,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 adultscore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604060055 On 3/31/2026 10:07 AM, Renjiang Han wrote: > Encoder HFI capabilities on v4 advertise a 16-pixel step for frame and > blur dimensions. This is overly restrictive and can cause userspace caps > negotiation to fail even for valid resolutions. > > Relax the advertised step size to 1 and keep alignment enforcement in > buffer layout and size calculations. > > Fixes: 8b88cabef404e ("media: venus: hfi_plat_v4: Populate codecs and capabilities for v4") > Signed-off-by: Renjiang Han > --- > drivers/media/platform/qcom/venus/hfi_platform_v4.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/hfi_platform_v4.c b/drivers/media/platform/qcom/venus/hfi_platform_v4.c > index cda888b56b5d4806f10d062371b9a4969e27d9b4..e0b3652bb44093111ce610fb09366c38db516966 100644 > --- a/drivers/media/platform/qcom/venus/hfi_platform_v4.c > +++ b/drivers/media/platform/qcom/venus/hfi_platform_v4.c > @@ -136,8 +136,8 @@ static const struct hfi_plat_caps caps[] = { > .codec = HFI_VIDEO_CODEC_H264, > .domain = VIDC_SESSION_TYPE_ENC, > .cap_bufs_mode_dynamic = true, > - .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 96, 4096, 16}, > - .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 96, 4096, 16}, > + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 96, 4096, 1}, > + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 96, 4096, 1}, > .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 1, 36864, 1}, > .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 120000000, 1}, > .caps[4] = {HFI_CAPABILITY_SCALE_X, 8192, 65536, 1}, > @@ -173,8 +173,8 @@ static const struct hfi_plat_caps caps[] = { > .codec = HFI_VIDEO_CODEC_HEVC, > .domain = VIDC_SESSION_TYPE_ENC, > .cap_bufs_mode_dynamic = true, > - .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 96, 4096, 16}, > - .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 96, 4096, 16}, > + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 96, 4096, 1}, > + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 96, 4096, 1}, > .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 1, 36864, 1}, > .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 120000000, 1}, > .caps[4] = {HFI_CAPABILITY_SCALE_X, 8192, 65536, 1}, > @@ -195,8 +195,8 @@ static const struct hfi_plat_caps caps[] = { > .caps[19] = {HFI_CAPABILITY_RATE_CONTROL_MODES, 0x1000001, 0x1000005, 1}, > .caps[20] = {HFI_CAPABILITY_COLOR_SPACE_CONVERSION, 0, 2, 1}, > .caps[21] = {HFI_CAPABILITY_ROTATION, 1, 4, 90}, > - .caps[22] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 16}, > - .caps[23] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 16}, > + .caps[22] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 1}, > + .caps[23] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 1}, > .num_caps = 24, > .pl[0] = {HFI_HEVC_PROFILE_MAIN, HFI_HEVC_LEVEL_6 | HFI_HEVC_TIER_HIGH0}, > .pl[1] = {HFI_HEVC_PROFILE_MAIN10, HFI_HEVC_LEVEL_6 | HFI_HEVC_TIER_HIGH0}, > @@ -210,8 +210,8 @@ static const struct hfi_plat_caps caps[] = { > .codec = HFI_VIDEO_CODEC_VP8, > .domain = VIDC_SESSION_TYPE_ENC, > .cap_bufs_mode_dynamic = true, > - .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 96, 4096, 16}, > - .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 96, 4096, 16}, > + .caps[0] = {HFI_CAPABILITY_FRAME_WIDTH, 96, 4096, 1}, > + .caps[1] = {HFI_CAPABILITY_FRAME_HEIGHT, 96, 4096, 1}, > .caps[2] = {HFI_CAPABILITY_MBS_PER_FRAME, 1, 36864, 1}, > .caps[3] = {HFI_CAPABILITY_BITRATE, 1, 120000000, 1}, > .caps[4] = {HFI_CAPABILITY_SCALE_X, 8192, 65536, 1}, > @@ -229,8 +229,8 @@ static const struct hfi_plat_caps caps[] = { > .caps[16] = {HFI_CAPABILITY_P_FRAME_QP, 0, 127, 1}, > .caps[17] = {HFI_CAPABILITY_MAX_WORKMODES, 1, 2, 1}, > .caps[18] = {HFI_CAPABILITY_RATE_CONTROL_MODES, 0x1000001, 0x1000005, 1}, > - .caps[19] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 16}, > - .caps[20] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 16}, > + .caps[19] = {HFI_CAPABILITY_BLUR_WIDTH, 96, 4096, 1}, > + .caps[20] = {HFI_CAPABILITY_BLUR_HEIGHT, 96, 4096, 1}, > .caps[21] = {HFI_CAPABILITY_COLOR_SPACE_CONVERSION, 0, 2, 1}, > .caps[22] = {HFI_CAPABILITY_ROTATION, 1, 4, 90}, > .num_caps = 23, > Reviewed-by: Dikshita Agarwal Thanks, Dikshita