Linux Media Controller development
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: "Erikas Bitovtas" <xerikasxx@gmail.com>,
	"Vikash Garodia" <vikash.garodia@oss.qualcomm.com>,
	"Dikshita Agarwal" <dikshita.agarwal@oss.qualcomm.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"André Apitzsch" <git@apitzsch.eu>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney@redhat.com>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH v5 5/8] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
Date: Sat, 9 May 2026 15:31:51 +0100	[thread overview]
Message-ID: <9bf43e04-f834-45b6-8942-bcae2e480371@kernel.org> (raw)
In-Reply-To: <69f9a6b7-7431-442a-82a2-6305635a508a@gmail.com>

On 09/05/2026 13:00, Erikas Bitovtas wrote:
> across reboots, so when I reverted the patch, I was actually testing
> against decoder, not encoder.
> 
> So, the result is the same when the patch is applied, when it is
> reverted, and when testing against v1 where the cores are enabled only
> for decoding.

OK but this is testing encoding

v4l2-ctl --verbose
--set-fmt-video-out=width=1280,height=720,pixelformat=NV12
--set-selection-output target=crop,top=0,left=0,width=1280,height=720
--set-fmt-video=pixelformat=H26
4 --stream-mmap --stream-out-mmap
--stream-from=cyclists_1280x720_92frames.yuv
--stream-to=/tmp/cyclists_1280x720_92frames.h264 -d /dev/video1

I think the GDSC patch specifically isn't too much of a concern.

1. Core0 works as decoder
2. Core1 doesn't work right now.
    So what I'm trying to ask is if we could test it both
    as an encoder or as a decoder.

If decoder works when both cores are declared decoder, we know there's a 
problem with encoder and could potentially proceed with upstream decoder 
x 2.

OTOH if Core1 can't be coaxed into working in either mode, we are better 
off either holding off on this series until the breakages is root caused 
or leaving out Core1 entirely for now.

i.e. there is no utility in declaring an encoder or decoder to userspace 
that is known to be broken.

---
bod

  reply	other threads:[~2026-05-09 14:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07  8:32 [PATCH v5 0/8] media: qcom: venus: add MSM8939 support Erikas Bitovtas
2026-05-07  8:32 ` [PATCH v5 1/8] media: dt-bindings: venus: Add qcom,msm8939 schema Erikas Bitovtas
2026-05-07  8:53   ` Bryan O'Donoghue
2026-05-07  8:32 ` [PATCH v5 2/8] arm64: dts: qcom: msm8939: Add venus node Erikas Bitovtas
2026-05-07  8:54   ` Bryan O'Donoghue
2026-05-07  8:32 ` [PATCH v5 3/8] arm64: dts: qcom: msm8939-longcheer-l9100: Enable " Erikas Bitovtas
2026-05-07  8:54   ` Bryan O'Donoghue
2026-05-07  8:32 ` [PATCH v5 4/8] arm64: dts: qcom: msm8939-asus-z00t: add Venus Erikas Bitovtas
2026-05-07  8:54   ` Bryan O'Donoghue
2026-05-07  8:32 ` [PATCH v5 5/8] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled Erikas Bitovtas
2026-05-07  8:59   ` Bryan O'Donoghue
2026-05-07  9:53     ` Erikas Bitovtas
2026-05-07 10:06       ` Bryan O'Donoghue
2026-05-07 12:46         ` Erikas Bitovtas
2026-05-07 13:37           ` Bryan O'Donoghue
2026-05-07 15:51             ` Erikas Bitovtas
2026-05-08 15:55               ` Bryan O'Donoghue
2026-05-09 12:00                 ` Erikas Bitovtas
2026-05-09 14:31                   ` Bryan O'Donoghue [this message]
2026-05-09 14:43                     ` Erikas Bitovtas
2026-05-10 10:03                       ` Bryan O'Donoghue
2026-05-10 10:14                         ` Erikas Bitovtas
2026-05-11  3:21                           ` Dmitry Baryshkov
2026-05-07  8:32 ` [PATCH v5 6/8] media: qcom: venus: add power domain enable logic for Venus cores Erikas Bitovtas
2026-05-07  9:10   ` Bryan O'Donoghue
2026-05-07  8:32 ` [PATCH v5 7/8] media: qcom: venus: Add msm8939 resource struct Erikas Bitovtas
2026-05-07  9:11   ` Bryan O'Donoghue
2026-05-07  8:32 ` [PATCH v5 8/8] media: qcom: venus: Enable HEVC decoding for MSM8939 Erikas Bitovtas
2026-05-07  9:21   ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bf43e04-f834-45b6-8942-bcae2e480371@kernel.org \
    --to=bod@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=git@apitzsch.eu \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vikash.garodia@oss.qualcomm.com \
    --cc=xerikasxx@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox