[PATCH] media: cec: extron-da-hd-4k-plus: drop external-module make commands

[PATCH] media: cec: extron-da-hd-4k-plus: drop external-module make commands

[Randy Dunlap]

Delete the external-module style Makefile commands. They are not needed
for in-tree modules.

This is the only Makefile in the kernel tree (aside from tools/ and
samples/) that uses this Makefile style.

The same files are built with or without this patch.

Fixes: 056f2821b631 ("media: cec: extron-da-hd-4k-plus: add the Extron DA HD 4K Plus CEC driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Hans Verkuil <hverkuil@kernel.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linux-media@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>
---
 drivers/media/cec/usb/extron-da-hd-4k-plus/Makefile |    6 ------
 1 file changed, 6 deletions(-)

--- linux-next.orig/drivers/media/cec/usb/extron-da-hd-4k-plus/Makefile
+++ linux-next/drivers/media/cec/usb/extron-da-hd-4k-plus/Makefile
@@ -1,8 +1,2 @@
 extron-da-hd-4k-plus-cec-objs := extron-da-hd-4k-plus.o cec-splitter.o
 obj-$(CONFIG_USB_EXTRON_DA_HD_4K_PLUS_CEC) := extron-da-hd-4k-plus-cec.o
-
-all:
-	$(MAKE) -C $(KDIR) M=$(shell pwd) modules
-
-install:
-	$(MAKE) -C $(KDIR) M=$(shell pwd) modules_install

Re: media: cec: extron-da-hd-4k-plus: drop external-module make commands

[Randy Dunlap]

Hi,

On 7/18/25 7:11 PM, Patchwork Integration wrote:
> Dear Randy Dunlap:
> 
> Thanks for your patches! Unfortunately the Media CI robot detected some
> issues:
> 
> # Test media-patchstyle:./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch media style
> ERROR: Commit 056f2821b631df2b94d3b017fd1e1eef918ed98d found in the stable tree, but stable@vger.kernel.org not in Cc:

OK, will add that.

> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc hverkuil (Cc: Hans Verkuil <hverkuil@kernel.org>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>)
> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc mchehab (Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>)
> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc linux-media (Cc: linux-media@vger.kernel.org)

Why these complaints? In Docmentation/driver-api/media/maintainer-entry-profile.html
I see:

  Patches for the media subsystem must be sent to the media mailing list
  at linux-media@vger.kernel.org as plain text only e-mail. Emails with
  HTML will be automatically rejected by the mail server. It could be wise
  to also copy the sub-maintainer(s).

OK, so according to this, I can Cc: (or should that be To: ?)
hverkuil@kernel.org and drop the copy to hverkuil@xs4all.nl.
Is that correct? Should I send a copy to Hans or not?
It's unclear (conflicting advice).

And I can drop Mauro's email address since the delegated sub-maintainer
can take care of it.

Thanks for guidance.

> 
> 
> 
> Please fix your series, and upload a new version. If you have a patchwork
> account, do not forget to mark the current series as Superseded.
> 
> For more details, check the full report at:
> https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/80828975/artifacts/report.htm .
> 
> 
> 
> Best regards, and Happy Hacking!
> Media CI robot on behalf of the linux-media community.
> 
> ---
> Check the latest rules for contributing your patches at:
> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> 
> If you believe that the CI is wrong, kindly open an issue at
> https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> to this message.
> 

-- 
~Randy

Re: media: cec: extron-da-hd-4k-plus: drop external-module make commands

[Hans Verkuil]

On 19/07/2025 22:38, Randy Dunlap wrote:
> Hi,
> 
> On 7/18/25 7:11 PM, Patchwork Integration wrote:
>> Dear Randy Dunlap:
>>
>> Thanks for your patches! Unfortunately the Media CI robot detected some
>> issues:
>>
>> # Test media-patchstyle:./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch media style
>> ERROR: Commit 056f2821b631df2b94d3b017fd1e1eef918ed98d found in the stable tree, but stable@vger.kernel.org not in Cc:
> 
> OK, will add that.
> 
>> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc hverkuil (Cc: Hans Verkuil <hverkuil@kernel.org>
>> Cc: Hans Verkuil <hverkuil@xs4all.nl>)
>> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc mchehab (Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>)
>> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc linux-media (Cc: linux-media@vger.kernel.org)
> 
> Why these complaints? In Docmentation/driver-api/media/maintainer-entry-profile.html
> I see:
> 
>   Patches for the media subsystem must be sent to the media mailing list
>   at linux-media@vger.kernel.org as plain text only e-mail. Emails with
>   HTML will be automatically rejected by the mail server. It could be wise
>   to also copy the sub-maintainer(s).
> 
> OK, so according to this, I can Cc: (or should that be To: ?)
> hverkuil@kernel.org and drop the copy to hverkuil@xs4all.nl.
> Is that correct? Should I send a copy to Hans or not?
> It's unclear (conflicting advice).
> 
> And I can drop Mauro's email address since the delegated sub-maintainer
> can take care of it.

You can CC us in the mail header, but adding Cc: tags for the mailinglist and the media maintainers
is overkill. Calling it an ERROR is probably over the top as well, it's more a warning. We're
still fine-tuning those automatic messages.

In any case, thank you for the patch, I think it accidentally ended up in the Makefile because
for quite some time this driver was carried out-of-tree and I forgot to delete it when I
mainlined it.

Regards,

	Hans

> 
> Thanks for guidance.
> 
>>
>>
>>
>> Please fix your series, and upload a new version. If you have a patchwork
>> account, do not forget to mark the current series as Superseded.
>>
>> For more details, check the full report at:
>> https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/80828975/artifacts/report.htm .
>>
>>
>>
>> Best regards, and Happy Hacking!
>> Media CI robot on behalf of the linux-media community.
>>
>> ---
>> Check the latest rules for contributing your patches at:
>> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
>>
>> If you believe that the CI is wrong, kindly open an issue at
>> https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
>> to this message.
>>
> 

Re: media: cec: extron-da-hd-4k-plus: drop external-module make commands

[Randy Dunlap]

On 7/20/25 2:22 AM, Hans Verkuil wrote:
> On 19/07/2025 22:38, Randy Dunlap wrote:
>> Hi,
>>
>> On 7/18/25 7:11 PM, Patchwork Integration wrote:
>>> Dear Randy Dunlap:
>>>
>>> Thanks for your patches! Unfortunately the Media CI robot detected some
>>> issues:
>>>
>>> # Test media-patchstyle:./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch media style
>>> ERROR: Commit 056f2821b631df2b94d3b017fd1e1eef918ed98d found in the stable tree, but stable@vger.kernel.org not in Cc:
>>
>> OK, will add that.
>>
>>> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc hverkuil (Cc: Hans Verkuil <hverkuil@kernel.org>
>>> Cc: Hans Verkuil <hverkuil@xs4all.nl>)
>>> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc mchehab (Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>)
>>> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc linux-media (Cc: linux-media@vger.kernel.org)
>>
>> Why these complaints? In Docmentation/driver-api/media/maintainer-entry-profile.html
>> I see:
>>
>>   Patches for the media subsystem must be sent to the media mailing list
>>   at linux-media@vger.kernel.org as plain text only e-mail. Emails with
>>   HTML will be automatically rejected by the mail server. It could be wise
>>   to also copy the sub-maintainer(s).
>>
>> OK, so according to this, I can Cc: (or should that be To: ?)
>> hverkuil@kernel.org and drop the copy to hverkuil@xs4all.nl.
>> Is that correct? Should I send a copy to Hans or not?
>> It's unclear (conflicting advice).
>>
>> And I can drop Mauro's email address since the delegated sub-maintainer
>> can take care of it.
> 
> You can CC us in the mail header, but adding Cc: tags for the mailinglist and the media maintainers
> is overkill. Calling it an ERROR is probably over the top as well, it's more a warning. We're
> still fine-tuning those automatic messages.

Ah, so it's the tags that are the issue. Thanks for the explanation.

> In any case, thank you for the patch, I think it accidentally ended up in the Makefile because
> for quite some time this driver was carried out-of-tree and I forgot to delete it when I
> mainlined it.

Sure :)
Do I need to send a v2 of the patch?

Thanks.
-- 
~Randy

Re: media: cec: extron-da-hd-4k-plus: drop external-module make commands

[Hans Verkuil]

On 20/07/2025 18:50, Randy Dunlap wrote:
> 
> 
> On 7/20/25 2:22 AM, Hans Verkuil wrote:
>> On 19/07/2025 22:38, Randy Dunlap wrote:
>>> Hi,
>>>
>>> On 7/18/25 7:11 PM, Patchwork Integration wrote:
>>>> Dear Randy Dunlap:
>>>>
>>>> Thanks for your patches! Unfortunately the Media CI robot detected some
>>>> issues:
>>>>
>>>> # Test media-patchstyle:./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch media style
>>>> ERROR: Commit 056f2821b631df2b94d3b017fd1e1eef918ed98d found in the stable tree, but stable@vger.kernel.org not in Cc:
>>>
>>> OK, will add that.
>>>
>>>> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc hverkuil (Cc: Hans Verkuil <hverkuil@kernel.org>
>>>> Cc: Hans Verkuil <hverkuil@xs4all.nl>)
>>>> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc mchehab (Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>)
>>>> ERROR: ./0001-media-cec-extron-da-hd-4k-plus-drop-external-module-.patch: Don't Cc linux-media (Cc: linux-media@vger.kernel.org)

Ah, this error message isn't clear that it is about the Cc tag, that should be clarified.

>>>
>>> Why these complaints? In Docmentation/driver-api/media/maintainer-entry-profile.html
>>> I see:
>>>
>>>   Patches for the media subsystem must be sent to the media mailing list
>>>   at linux-media@vger.kernel.org as plain text only e-mail. Emails with
>>>   HTML will be automatically rejected by the mail server. It could be wise
>>>   to also copy the sub-maintainer(s).
>>>
>>> OK, so according to this, I can Cc: (or should that be To: ?)
>>> hverkuil@kernel.org and drop the copy to hverkuil@xs4all.nl.
>>> Is that correct? Should I send a copy to Hans or not?
>>> It's unclear (conflicting advice).
>>>
>>> And I can drop Mauro's email address since the delegated sub-maintainer
>>> can take care of it.
>>
>> You can CC us in the mail header, but adding Cc: tags for the mailinglist and the media maintainers
>> is overkill. Calling it an ERROR is probably over the top as well, it's more a warning. We're
>> still fine-tuning those automatic messages.
> 
> Ah, so it's the tags that are the issue. Thanks for the explanation.
> 
>> In any case, thank you for the patch, I think it accidentally ended up in the Makefile because
>> for quite some time this driver was carried out-of-tree and I forgot to delete it when I
>> mainlined it.
> 
> Sure :)
> Do I need to send a v2 of the patch?

Yes please.

Regards,

	Hans