* [PATCH 0/2] media: qcom: camss: Fix clock and IRQ configurations for 8775p platform
@ 2026-03-13 9:42 Wenmeng Liu
2026-03-13 9:42 ` [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p Wenmeng Liu
2026-03-13 9:42 ` [PATCH 2/2] media: qcom: camss: Add missing clocks for VFE lite on 8775p Wenmeng Liu
0 siblings, 2 replies; 6+ messages in thread
From: Wenmeng Liu @ 2026-03-13 9:42 UTC (permalink / raw)
To: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil,
Vikram Sharma, Suresh Vankadara, Wenmeng Liu
Cc: linux-media, linux-arm-msm, linux-kernel, Wenmeng Liu
This series contains two fixes for the Qualcomm Camera Subsystem driver
on 8775p platform:
1. Fix CSID clock configuration and IRQ offset. Simplify the lite CSID
clock requirements and correct the buffer done IRQ status offset
calculation.
2. Add missing clocks for VFE lite instances.
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
---
Wenmeng Liu (2):
media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p
media: qcom: camss: Add missing clocks for VFE lite on 8775p
.../media/platform/qcom/camss/camss-csid-gen3.c | 6 +-
drivers/media/platform/qcom/camss/camss.c | 80 ++++++++++++----------
2 files changed, 45 insertions(+), 41 deletions(-)
---
base-commit: 5c9e55fecf9365890c64f14761a80f9413a3b1d1
change-id: 20260313-vfelite_fix-00a36e8dccfd
Best regards,
--
Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p
2026-03-13 9:42 [PATCH 0/2] media: qcom: camss: Fix clock and IRQ configurations for 8775p platform Wenmeng Liu
@ 2026-03-13 9:42 ` Wenmeng Liu
2026-03-13 9:46 ` Bryan O'Donoghue
2026-03-13 9:42 ` [PATCH 2/2] media: qcom: camss: Add missing clocks for VFE lite on 8775p Wenmeng Liu
1 sibling, 1 reply; 6+ messages in thread
From: Wenmeng Liu @ 2026-03-13 9:42 UTC (permalink / raw)
To: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil,
Vikram Sharma, Suresh Vankadara, Wenmeng Liu
Cc: linux-media, linux-arm-msm, linux-kernel, Wenmeng Liu
Fix two issues in csid driver for 8775p platform:
1. Simplify clock configuration for csid lite by removing unused clocks
and correcting clock rates. Only vfe_lite_csid and vfe_lite_cphy_rx
clocks are actually needed.
2. Fix BUF_DONE_IRQ_STATUS_RDI_OFFSET calculation for csid lite on
sa8775p platform. The offset should be 0 for csid lite on sa8775p,
Fixes: ed03e99de0fa ("media: qcom: camss: Add support for CSID 690")
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
---
.../media/platform/qcom/camss/camss-csid-gen3.c | 6 ++--
drivers/media/platform/qcom/camss/camss.c | 40 +++++++++-------------
2 files changed, 20 insertions(+), 26 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen3.c b/drivers/media/platform/qcom/camss/camss-csid-gen3.c
index 664245cf6eb0cac662b02f8b920cd1c72db0aeb2..bd059243790edeb045080905eb76fef3b12caae1 100644
--- a/drivers/media/platform/qcom/camss/camss-csid-gen3.c
+++ b/drivers/media/platform/qcom/camss/camss-csid-gen3.c
@@ -48,9 +48,9 @@
#define IS_CSID_690(csid) ((csid->camss->res->version == CAMSS_8775P) \
|| (csid->camss->res->version == CAMSS_8300))
#define CSID_BUF_DONE_IRQ_STATUS 0x8C
-#define BUF_DONE_IRQ_STATUS_RDI_OFFSET (csid_is_lite(csid) ?\
- 1 : (IS_CSID_690(csid) ?\
- 13 : 14))
+#define BUF_DONE_IRQ_STATUS_RDI_OFFSET (csid_is_lite(csid) ? \
+ ((IS_CSID_690(csid) ? 0 : 1)) : \
+ ((IS_CSID_690(csid) ? 13 : 14)))
#define CSID_BUF_DONE_IRQ_MASK 0x90
#define CSID_BUF_DONE_IRQ_CLEAR 0x94
#define CSID_BUF_DONE_IRQ_SET 0x98
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index 00b87fd9afbd89871ffaee9cb2b2db6538e1d70d..4a0bf8acd7645f8cd8c1b4cb9b6ff6f3a54d42e8 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -3598,9 +3598,11 @@ static const struct camss_subdev_resources csid_res_8775p[] = {
/* CSID2 (lite) */
{
.regulators = {},
- .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
- "vfe_lite_csid", "vfe_lite_cphy_rx",
- "vfe_lite"},
+ .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx" },
+ .clock_rate = {
+ { 400000000, 480000000 },
+ { 400000000, 480000000 }
+ },
.clock_rate = {
{ 0, 0, 400000000, 400000000, 0},
{ 0, 0, 400000000, 480000000, 0}
@@ -3617,12 +3619,10 @@ static const struct camss_subdev_resources csid_res_8775p[] = {
/* CSID3 (lite) */
{
.regulators = {},
- .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
- "vfe_lite_csid", "vfe_lite_cphy_rx",
- "vfe_lite"},
+ .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx" },
.clock_rate = {
- { 0, 0, 400000000, 400000000, 0},
- { 0, 0, 400000000, 480000000, 0}
+ { 400000000, 480000000 },
+ { 400000000, 480000000 }
},
.reg = { "csid_lite1" },
.interrupt = { "csid_lite1" },
@@ -3636,12 +3636,10 @@ static const struct camss_subdev_resources csid_res_8775p[] = {
/* CSID4 (lite) */
{
.regulators = {},
- .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
- "vfe_lite_csid", "vfe_lite_cphy_rx",
- "vfe_lite"},
+ .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx" },
.clock_rate = {
- { 0, 0, 400000000, 400000000, 0},
- { 0, 0, 400000000, 480000000, 0}
+ { 400000000, 480000000 },
+ { 400000000, 480000000 }
},
.reg = { "csid_lite2" },
.interrupt = { "csid_lite2" },
@@ -3655,12 +3653,10 @@ static const struct camss_subdev_resources csid_res_8775p[] = {
/* CSID5 (lite) */
{
.regulators = {},
- .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
- "vfe_lite_csid", "vfe_lite_cphy_rx",
- "vfe_lite"},
+ .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx" },
.clock_rate = {
- { 0, 0, 400000000, 400000000, 0},
- { 0, 0, 400000000, 480000000, 0}
+ { 400000000, 480000000 },
+ { 400000000, 480000000 }
},
.reg = { "csid_lite3" },
.interrupt = { "csid_lite3" },
@@ -3674,12 +3670,10 @@ static const struct camss_subdev_resources csid_res_8775p[] = {
/* CSID6 (lite) */
{
.regulators = {},
- .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
- "vfe_lite_csid", "vfe_lite_cphy_rx",
- "vfe_lite"},
+ .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx" },
.clock_rate = {
- { 0, 0, 400000000, 400000000, 0},
- { 0, 0, 400000000, 480000000, 0}
+ { 400000000, 480000000 },
+ { 400000000, 480000000 }
},
.reg = { "csid_lite4" },
.interrupt = { "csid_lite4" },
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] media: qcom: camss: Add missing clocks for VFE lite on 8775p
2026-03-13 9:42 [PATCH 0/2] media: qcom: camss: Fix clock and IRQ configurations for 8775p platform Wenmeng Liu
2026-03-13 9:42 ` [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p Wenmeng Liu
@ 2026-03-13 9:42 ` Wenmeng Liu
2026-03-13 9:49 ` Bryan O'Donoghue
1 sibling, 1 reply; 6+ messages in thread
From: Wenmeng Liu @ 2026-03-13 9:42 UTC (permalink / raw)
To: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil,
Vikram Sharma, Suresh Vankadara, Wenmeng Liu
Cc: linux-media, linux-arm-msm, linux-kernel, Wenmeng Liu
Add missing required clocks (cpas_ahb and camnoc_axi) for VFE lite
instances on 8775p platform. These clocks are necessary for proper
VFE lite operation:
Fixes: e7b59e1d06fb ("media: qcom: camss: Add support for VFE 690")
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
---
drivers/media/platform/qcom/camss/camss.c | 40 +++++++++++++++++++------------
1 file changed, 25 insertions(+), 15 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index 4a0bf8acd7645f8cd8c1b4cb9b6ff6f3a54d42e8..d325539defbecc7f4fbcb9d20fb69884e109a459 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -3746,15 +3746,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
/* VFE2 (lite) */
{
.regulators = {},
- .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
+ .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
"vfe_lite_csid", "vfe_lite_cphy_rx",
- "vfe_lite"},
+ "vfe_lite", "camnoc_axi"},
.clock_rate = {
- { 0, 0, 0, 0 },
+ { 0 },
+ { 0 },
{ 300000000, 400000000, 400000000, 400000000 },
{ 400000000, 400000000, 400000000, 400000000 },
{ 400000000, 400000000, 400000000, 400000000 },
{ 480000000, 600000000, 600000000, 600000000 },
+ { 400000000 },
},
.reg = { "vfe_lite0" },
.interrupt = { "vfe_lite0" },
@@ -3769,15 +3771,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
/* VFE3 (lite) */
{
.regulators = {},
- .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
+ .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
"vfe_lite_csid", "vfe_lite_cphy_rx",
- "vfe_lite"},
+ "vfe_lite", "camnoc_axi"},
.clock_rate = {
- { 0, 0, 0, 0 },
+ { 0 },
+ { 0 },
{ 300000000, 400000000, 400000000, 400000000 },
{ 400000000, 400000000, 400000000, 400000000 },
{ 400000000, 400000000, 400000000, 400000000 },
{ 480000000, 600000000, 600000000, 600000000 },
+ { 400000000 },
},
.reg = { "vfe_lite1" },
.interrupt = { "vfe_lite1" },
@@ -3792,15 +3796,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
/* VFE4 (lite) */
{
.regulators = {},
- .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
+ .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
"vfe_lite_csid", "vfe_lite_cphy_rx",
- "vfe_lite"},
+ "vfe_lite", "camnoc_axi"},
.clock_rate = {
- { 0, 0, 0, 0 },
+ { 0 },
+ { 0 },
{ 300000000, 400000000, 400000000, 400000000 },
{ 400000000, 400000000, 400000000, 400000000 },
{ 400000000, 400000000, 400000000, 400000000 },
{ 480000000, 600000000, 600000000, 600000000 },
+ { 400000000 },
},
.reg = { "vfe_lite2" },
.interrupt = { "vfe_lite2" },
@@ -3815,15 +3821,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
/* VFE5 (lite) */
{
.regulators = {},
- .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
+ .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
"vfe_lite_csid", "vfe_lite_cphy_rx",
- "vfe_lite"},
+ "vfe_lite", "camnoc_axi"},
.clock_rate = {
- { 0, 0, 0, 0 },
+ { 0 },
+ { 0 },
{ 300000000, 400000000, 400000000, 400000000 },
{ 400000000, 400000000, 400000000, 400000000 },
{ 400000000, 400000000, 400000000, 400000000 },
{ 480000000, 600000000, 600000000, 600000000 },
+ { 400000000 },
},
.reg = { "vfe_lite3" },
.interrupt = { "vfe_lite3" },
@@ -3838,15 +3846,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
/* VFE6 (lite) */
{
.regulators = {},
- .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
+ .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
"vfe_lite_csid", "vfe_lite_cphy_rx",
- "vfe_lite"},
+ "vfe_lite", "camnoc_axi"},
.clock_rate = {
- { 0, 0, 0, 0 },
+ { 0 },
+ { 0 },
{ 300000000, 400000000, 400000000, 400000000 },
{ 400000000, 400000000, 400000000, 400000000 },
{ 400000000, 400000000, 400000000, 400000000 },
{ 480000000, 600000000, 600000000, 600000000 },
+ { 400000000 },
},
.reg = { "vfe_lite4" },
.interrupt = { "vfe_lite4" },
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p
2026-03-13 9:42 ` [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p Wenmeng Liu
@ 2026-03-13 9:46 ` Bryan O'Donoghue
2026-03-13 9:53 ` Wenmeng Liu
0 siblings, 1 reply; 6+ messages in thread
From: Bryan O'Donoghue @ 2026-03-13 9:46 UTC (permalink / raw)
To: Wenmeng Liu, Robert Foss, Todor Tomov, Vladimir Zapolskiy,
Mauro Carvalho Chehab, Hans Verkuil, Vikram Sharma,
Suresh Vankadara, Wenmeng Liu
Cc: linux-media, linux-arm-msm, linux-kernel
On 13/03/2026 09:42, Wenmeng Liu wrote:
> Fix two issues in csid driver for 8775p platform:
>
> 1. Simplify clock configuration for csid lite by removing unused clocks
> and correcting clock rates. Only vfe_lite_csid and vfe_lite_cphy_rx
> clocks are actually needed.
This should be its own patch and should that patch have a Fixes: ?
Simplification != fixing a bug.
> 2. Fix BUF_DONE_IRQ_STATUS_RDI_OFFSET calculation for csid lite on
> sa8775p platform. The offset should be 0 for csid lite on sa8775p,
>
> Fixes: ed03e99de0fa ("media: qcom: camss: Add support for CSID 690")
> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Yeah this should be standalone then.
My general rule here is if your patch requires line items to explain
various things being done, then those line-items deserve their own patch.
---
bod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] media: qcom: camss: Add missing clocks for VFE lite on 8775p
2026-03-13 9:42 ` [PATCH 2/2] media: qcom: camss: Add missing clocks for VFE lite on 8775p Wenmeng Liu
@ 2026-03-13 9:49 ` Bryan O'Donoghue
0 siblings, 0 replies; 6+ messages in thread
From: Bryan O'Donoghue @ 2026-03-13 9:49 UTC (permalink / raw)
To: Wenmeng Liu, Robert Foss, Todor Tomov, Vladimir Zapolskiy,
Mauro Carvalho Chehab, Hans Verkuil, Vikram Sharma,
Suresh Vankadara, Wenmeng Liu
Cc: linux-media, linux-arm-msm, linux-kernel
On 13/03/2026 09:42, Wenmeng Liu wrote:
> Add missing required clocks (cpas_ahb and camnoc_axi) for VFE lite
> instances on 8775p platform. These clocks are necessary for proper
> VFE lite operation:
>
> Fixes: e7b59e1d06fb ("media: qcom: camss: Add support for VFE 690")
> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/camss/camss.c | 40 +++++++++++++++++++------------
> 1 file changed, 25 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 4a0bf8acd7645f8cd8c1b4cb9b6ff6f3a54d42e8..d325539defbecc7f4fbcb9d20fb69884e109a459 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -3746,15 +3746,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
> /* VFE2 (lite) */
> {
> .regulators = {},
> - .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
> "vfe_lite_csid", "vfe_lite_cphy_rx",
> - "vfe_lite"},
> + "vfe_lite", "camnoc_axi"},
> .clock_rate = {
> - { 0, 0, 0, 0 },
> + { 0 },
> + { 0 },
> { 300000000, 400000000, 400000000, 400000000 },
> { 400000000, 400000000, 400000000, 400000000 },
> { 400000000, 400000000, 400000000, 400000000 },
> { 480000000, 600000000, 600000000, 600000000 },
> + { 400000000 },
> },
> .reg = { "vfe_lite0" },
> .interrupt = { "vfe_lite0" },
> @@ -3769,15 +3771,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
> /* VFE3 (lite) */
> {
> .regulators = {},
> - .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
> "vfe_lite_csid", "vfe_lite_cphy_rx",
> - "vfe_lite"},
> + "vfe_lite", "camnoc_axi"},
> .clock_rate = {
> - { 0, 0, 0, 0 },
> + { 0 },
> + { 0 },
> { 300000000, 400000000, 400000000, 400000000 },
> { 400000000, 400000000, 400000000, 400000000 },
> { 400000000, 400000000, 400000000, 400000000 },
> { 480000000, 600000000, 600000000, 600000000 },
> + { 400000000 },
> },
> .reg = { "vfe_lite1" },
> .interrupt = { "vfe_lite1" },
> @@ -3792,15 +3796,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
> /* VFE4 (lite) */
> {
> .regulators = {},
> - .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
> "vfe_lite_csid", "vfe_lite_cphy_rx",
> - "vfe_lite"},
> + "vfe_lite", "camnoc_axi"},
> .clock_rate = {
> - { 0, 0, 0, 0 },
> + { 0 },
> + { 0 },
> { 300000000, 400000000, 400000000, 400000000 },
> { 400000000, 400000000, 400000000, 400000000 },
> { 400000000, 400000000, 400000000, 400000000 },
> { 480000000, 600000000, 600000000, 600000000 },
> + { 400000000 },
> },
> .reg = { "vfe_lite2" },
> .interrupt = { "vfe_lite2" },
> @@ -3815,15 +3821,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
> /* VFE5 (lite) */
> {
> .regulators = {},
> - .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
> "vfe_lite_csid", "vfe_lite_cphy_rx",
> - "vfe_lite"},
> + "vfe_lite", "camnoc_axi"},
> .clock_rate = {
> - { 0, 0, 0, 0 },
> + { 0 },
> + { 0 },
> { 300000000, 400000000, 400000000, 400000000 },
> { 400000000, 400000000, 400000000, 400000000 },
> { 400000000, 400000000, 400000000, 400000000 },
> { 480000000, 600000000, 600000000, 600000000 },
> + { 400000000 },
> },
> .reg = { "vfe_lite3" },
> .interrupt = { "vfe_lite3" },
> @@ -3838,15 +3846,17 @@ static const struct camss_subdev_resources vfe_res_8775p[] = {
> /* VFE6 (lite) */
> {
> .regulators = {},
> - .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + .clock = { "cpas_ahb", "cpas_vfe_lite", "vfe_lite_ahb",
> "vfe_lite_csid", "vfe_lite_cphy_rx",
> - "vfe_lite"},
> + "vfe_lite", "camnoc_axi"},
> .clock_rate = {
> - { 0, 0, 0, 0 },
> + { 0 },
> + { 0 },
> { 300000000, 400000000, 400000000, 400000000 },
> { 400000000, 400000000, 400000000, 400000000 },
> { 400000000, 400000000, 400000000, 400000000 },
> { 480000000, 600000000, 600000000, 600000000 },
> + { 400000000 },
> },
> .reg = { "vfe_lite4" },
> .interrupt = { "vfe_lite4" },
>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
bod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p
2026-03-13 9:46 ` Bryan O'Donoghue
@ 2026-03-13 9:53 ` Wenmeng Liu
0 siblings, 0 replies; 6+ messages in thread
From: Wenmeng Liu @ 2026-03-13 9:53 UTC (permalink / raw)
To: Bryan O'Donoghue, Robert Foss, Todor Tomov,
Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil,
Vikram Sharma, Suresh Vankadara, Wenmeng Liu
Cc: linux-media, linux-arm-msm, linux-kernel
Hi Bryan,
On 3/13/2026 5:46 PM, Bryan O'Donoghue wrote:
> On 13/03/2026 09:42, Wenmeng Liu wrote:
>> Fix two issues in csid driver for 8775p platform:
>>
>> 1. Simplify clock configuration for csid lite by removing unused clocks
>> and correcting clock rates. Only vfe_lite_csid and vfe_lite_cphy_rx
>> clocks are actually needed.
>
> This should be its own patch and should that patch have a Fixes: ?
>
> Simplification != fixing a bug.
Sure, There is also an issue with the clock here, I will also modify the
description.
>
>> 2. Fix BUF_DONE_IRQ_STATUS_RDI_OFFSET calculation for csid lite on
>> sa8775p platform. The offset should be 0 for csid lite on sa8775p,
>>
>> Fixes: ed03e99de0fa ("media: qcom: camss: Add support for CSID 690")
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
>
> Yeah this should be standalone then.
>
> My general rule here is if your patch requires line items to explain
> various things being done, then those line-items deserve their own patch.
ACK.
>
> ---
> bod
Thanks,
Wenmeng
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-03-13 9:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 9:42 [PATCH 0/2] media: qcom: camss: Fix clock and IRQ configurations for 8775p platform Wenmeng Liu
2026-03-13 9:42 ` [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p Wenmeng Liu
2026-03-13 9:46 ` Bryan O'Donoghue
2026-03-13 9:53 ` Wenmeng Liu
2026-03-13 9:42 ` [PATCH 2/2] media: qcom: camss: Add missing clocks for VFE lite on 8775p Wenmeng Liu
2026-03-13 9:49 ` Bryan O'Donoghue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox