public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: "Daniel Scally" <dan.scally@ideasonboard.com>,
	"Barnabás Pőcze" <barnabas.pocze@ideasonboard.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Hans Verkuil" <hverkuil+cisco@kernel.org>,
	linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Jacopo Mondi" <jacopo.mondi+renesas@ideasonboard.com>,
	"Daniel Scally" <dan.scally+renesas@ideasonboard.com>,
	stable@vger.kernel.org,
	"Barnabás Pőcze" <barnabas.pocze+renesas@ideasonboard.com>
Subject: Re: [PATCH 0/7] media: renesas: rzv2h-ivc: Fix concurrent job scheduling
Date: Fri, 20 Mar 2026 17:16:51 +0000	[thread overview]
Message-ID: <CA+V-a8t0pskENYNhBiYCk=NtU7w9J1wr3TMtH2GQm_bz_-8thw@mail.gmail.com> (raw)
In-Reply-To: <20260313-mali-ivc-fixes-v7-0-v1-0-cb0714cd1279@ideasonboard.com>

Hi Jacopo,

Thank you for the patches.

On Fri, Mar 13, 2026 at 11:14 AM Jacopo Mondi
<jacopo.mondi@ideasonboard.com> wrote:
>
> We have been exercizing the RZ/V2H(P) IVC block quite intensly these
> last two months.
>
> Here it is a collection of fixes and improvements to the driver.
>
> The first 4 patches in the series address a few registers writes that
> do not respect the documentation.
>
> The 5th and 6th patches fixes concurrent access to the list of queued
> buffers and fix a WARN() visible under heavy system load conditions
> caused by concurrent buffer transfers.
>
> The last patch is actually up for discussion. It is my opinion that the
> trouble of setting up a workqueue item is not justified by the
> relatively small amount of work that has to be carried out in interrupt
> context. In any case, there shouldn't be any functional change
> introduced by this patch.
>
> Patch #7 makes patch #6 reduntant: if we use direct function
> calls, then the issue of concurrently running workqueue items cannot
> happen. However, I actually think patch #6 has value regardless as it
> makes the code more robust.
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
> ---
> Barnabás Pőcze (4):
>       media: rzv2h-ivc: Fix AXIRX_VBLANK register write
>       media: rzv2h-ivc: Write AXIRX_PIXFMT once
>       media: rzv2h-ivc: Fix FM_STOP register write
>       media: rzv2h-ivc: Fix concurrent buffer list access
>
> Daniel Scally (1):
>       media: rzv2h-ivc: Revise default VBLANK formula
>
> Jacopo Mondi (2):
>       media: rzv2h-ivc: Avoid double job scheduling
>       media: rzv2h-ivc: Replace workqueue with direct function call
>
Tested the patches on RZ/V2H EVK with IMX708 sensor on next-20260319.

Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> #
On RZ/V2H EVK

Cheers,
Prabhakar

      parent reply	other threads:[~2026-03-20 17:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 11:13 [PATCH 0/7] media: renesas: rzv2h-ivc: Fix concurrent job scheduling Jacopo Mondi
2026-03-13 11:13 ` [PATCH 1/7] media: rzv2h-ivc: Revise default VBLANK formula Jacopo Mondi
2026-03-13 11:13 ` [PATCH 2/7] media: rzv2h-ivc: Fix AXIRX_VBLANK register write Jacopo Mondi
2026-03-13 16:15   ` Dan Scally
2026-03-18  8:24   ` Barnabás Pőcze
2026-03-13 11:13 ` [PATCH 3/7] media: rzv2h-ivc: Write AXIRX_PIXFMT once Jacopo Mondi
2026-03-13 16:07   ` Dan Scally
2026-03-13 16:12     ` Jacopo Mondi
2026-03-13 16:14       ` Dan Scally
2026-03-13 11:14 ` [PATCH 4/7] media: rzv2h-ivc: Fix FM_STOP register write Jacopo Mondi
2026-03-13 20:39   ` Dan Scally
2026-03-13 11:14 ` [PATCH 5/7] media: rzv2h-ivc: Fix concurrent buffer list access Jacopo Mondi
2026-03-13 22:11   ` Dan Scally
2026-03-13 11:14 ` [PATCH 6/7] media: rzv2h-ivc: Avoid double job scheduling Jacopo Mondi
2026-03-18  8:00   ` Dan Scally
2026-03-18  8:18   ` Barnabás Pőcze
2026-03-13 11:14 ` [PATCH 7/7] media: rzv2h-ivc: Replace workqueue with direct function call Jacopo Mondi
2026-03-13 22:42   ` Dan Scally
2026-03-20 17:16 ` Lad, Prabhakar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+V-a8t0pskENYNhBiYCk=NtU7w9J1wr3TMtH2GQm_bz_-8thw@mail.gmail.com' \
    --to=prabhakar.csengg@gmail.com \
    --cc=barnabas.pocze+renesas@ideasonboard.com \
    --cc=barnabas.pocze@ideasonboard.com \
    --cc=dan.scally+renesas@ideasonboard.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=jacopo.mondi+renesas@ideasonboard.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox