From: Prabhakar Lad <prabhakar.csengg@gmail.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: manjunath.hadli@ti.com, prabhakar.lad@ti.com, mchehab@redhat.com,
yongjun_wei@trendmicro.com.cn,
davinci-linux-open-source@linux.davincidsp.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH -next] [media] davinci: vpbe: remove unused variable in vpbe_initialize()
Date: Mon, 3 Dec 2012 11:30:32 +0530 [thread overview]
Message-ID: <CA+V-a8t7w2TcyxO6ZPbpp3hV82e1592B7-32fOWt_tVLjvJWGw@mail.gmail.com> (raw)
In-Reply-To: <CAPgLHd_6Jnu5x0rEwVr-3Uw04f1MjB96AVQ1KAWFSoeCB2Gupg@mail.gmail.com>
Hi Wei,
Thanks for the patch.
On Mon, Dec 3, 2012 at 8:23 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The variable 'output_index' is initialized but never used
> otherwise, so remove the unused variable.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Prabhakar Lad <prabhakar.lad@ti.com>
Regards,
--Prabhakar
> ---
> drivers/media/platform/davinci/vpbe.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c
> index 7f5cf9b..e0c79c1 100644
> --- a/drivers/media/platform/davinci/vpbe.c
> +++ b/drivers/media/platform/davinci/vpbe.c
> @@ -584,7 +584,6 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
> struct v4l2_subdev **enc_subdev;
> struct osd_state *osd_device;
> struct i2c_adapter *i2c_adap;
> - int output_index;
> int num_encoders;
> int ret = 0;
> int err;
> @@ -731,7 +730,6 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)
> /* set the current encoder and output to that of venc by default */
> vpbe_dev->current_sd_index = 0;
> vpbe_dev->current_out_index = 0;
> - output_index = 0;
>
> mutex_unlock(&vpbe_dev->lock);
>
>
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
prev parent reply other threads:[~2012-12-03 6:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 2:53 [PATCH -next] [media] davinci: vpbe: remove unused variable in vpbe_initialize() Wei Yongjun
2012-12-03 6:00 ` Prabhakar Lad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8t7w2TcyxO6ZPbpp3hV82e1592B7-32fOWt_tVLjvJWGw@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-media@vger.kernel.org \
--cc=manjunath.hadli@ti.com \
--cc=mchehab@redhat.com \
--cc=prabhakar.lad@ti.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).