From: Tomasz Figa <tfiga@chromium.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: Re: [GIT PULL FOR v4.21] Add Rockchip VPU JPEG encoder
Date: Thu, 22 Nov 2018 19:32:06 +0900 [thread overview]
Message-ID: <CAAFQd5DGW1YAZ9bV8rOV+o_i3KNaCHrfHRDjos_Uu1dQtuxivA@mail.gmail.com> (raw)
In-Reply-To: <6fca8409-3c12-41fb-d5b9-95aa74fa6420@xs4all.nl>
On Thu, Nov 22, 2018 at 7:29 PM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> Hi Ezeguiel,
>
> Just saw Tomasz' in-depth review and decided to drop this pull request.
>
> He found a few too many issues and I prefer those are addressed first.
>
> Sorry, still more work for you, on to v11!
I'm really sorry for the late review. Hopefully I can do better from
now on. (Still have quite a big pile of backlog, though...)
Best regards,
Tomasz
>
> Regards,
>
> Hans
>
> On 11/22/2018 10:39 AM, Hans Verkuil wrote:
> > The following changes since commit 5200ab6a32d6055428896a49ec9e3b1652c1a100:
> >
> > media: vidioc_cropcap -> vidioc_g_pixelaspect (2018-11-20 13:57:21 -0500)
> >
> > are available in the Git repository at:
> >
> > git://linuxtv.org/hverkuil/media_tree.git tags/br-jpeg
> >
> > for you to fetch changes up to cbf7592cb57ec9986c4d1becfd80b85486fd318a:
> >
> > media: add Rockchip VPU JPEG encoder driver (2018-11-22 10:12:29 +0100)
> >
> > ----------------------------------------------------------------
> > Tag branch
> >
> > ----------------------------------------------------------------
> > Ezequiel Garcia (1):
> > media: add Rockchip VPU JPEG encoder driver
> >
> > MAINTAINERS | 7 +
> > drivers/staging/media/Kconfig | 2 +
> > drivers/staging/media/Makefile | 1 +
> > drivers/staging/media/rockchip/vpu/Kconfig | 13 +
> > drivers/staging/media/rockchip/vpu/Makefile | 10 +
> > drivers/staging/media/rockchip/vpu/TODO | 6 +
> > drivers/staging/media/rockchip/vpu/rk3288_vpu_hw.c | 118 ++++++++
> > drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 133 ++++++++
> > drivers/staging/media/rockchip/vpu/rk3288_vpu_regs.h | 442 +++++++++++++++++++++++++++
> > drivers/staging/media/rockchip/vpu/rk3399_vpu_hw.c | 118 ++++++++
> > drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c | 160 ++++++++++
> > drivers/staging/media/rockchip/vpu/rk3399_vpu_regs.h | 600 ++++++++++++++++++++++++++++++++++++
> > drivers/staging/media/rockchip/vpu/rockchip_vpu.h | 237 +++++++++++++++
> > drivers/staging/media/rockchip/vpu/rockchip_vpu_common.h | 29 ++
> > drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c | 535 +++++++++++++++++++++++++++++++++
> > drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c | 702 +++++++++++++++++++++++++++++++++++++++++++
> > drivers/staging/media/rockchip/vpu/rockchip_vpu_hw.h | 58 ++++
> > drivers/staging/media/rockchip/vpu/rockchip_vpu_jpeg.c | 290 ++++++++++++++++++
> > drivers/staging/media/rockchip/vpu/rockchip_vpu_jpeg.h | 14 +
> > 19 files changed, 3475 insertions(+)
> > create mode 100644 drivers/staging/media/rockchip/vpu/Kconfig
> > create mode 100644 drivers/staging/media/rockchip/vpu/Makefile
> > create mode 100644 drivers/staging/media/rockchip/vpu/TODO
> > create mode 100644 drivers/staging/media/rockchip/vpu/rk3288_vpu_hw.c
> > create mode 100644 drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c
> > create mode 100644 drivers/staging/media/rockchip/vpu/rk3288_vpu_regs.h
> > create mode 100644 drivers/staging/media/rockchip/vpu/rk3399_vpu_hw.c
> > create mode 100644 drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c
> > create mode 100644 drivers/staging/media/rockchip/vpu/rk3399_vpu_regs.h
> > create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu.h
> > create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_common.h
> > create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
> > create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c
> > create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_hw.h
> > create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_jpeg.c
> > create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_jpeg.h
> >
>
prev parent reply other threads:[~2018-11-22 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 9:39 [GIT PULL FOR v4.21] Add Rockchip VPU JPEG encoder Hans Verkuil
2018-11-22 10:29 ` Hans Verkuil
2018-11-22 10:32 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAFQd5DGW1YAZ9bV8rOV+o_i3KNaCHrfHRDjos_Uu1dQtuxivA@mail.gmail.com \
--to=tfiga@chromium.org \
--cc=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).