[PATCH v2] staging: atomisp: fix brace style and trailing whitespace in isp_param.c

[PATCH v2] staging: atomisp: fix brace style and trailing whitespace in isp_param.c

[Kalyani Patra]

Fix checkpatch errors related to brace placement and remove trailing
whitespace in isp_param.c.

Reported by scripts/checkpatch.pl.

Signed-off-by: Kalyani Patra <kalyanipatra2003@gmail.com>
---
 .../atomisp/pci/runtime/isp_param/src/isp_param.c    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c b/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c
index 251dd75a7613..f21797598cd5 100644
--- a/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c
+++ b/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c
@@ -97,13 +97,13 @@ int
 ia_css_isp_param_allocate_isp_parameters(
     struct ia_css_isp_param_host_segments *mem_params,
     struct ia_css_isp_param_css_segments *css_params,
-    const struct ia_css_isp_param_isp_segments *mem_initializers) {
+    const struct ia_css_isp_param_isp_segments *mem_initializers)
+{
 	int err = 0;
 	unsigned int mem, pclass;
 
 	pclass = IA_CSS_PARAM_CLASS_PARAM;
-	for (mem = 0; mem < IA_CSS_NUM_MEMORIES; mem++)
-	{
+	for (mem = 0; mem < IA_CSS_NUM_MEMORIES; mem++) {
 		for (pclass = 0; pclass < IA_CSS_NUM_PARAM_CLASSES; pclass++) {
 			u32 size = 0;
 
@@ -175,11 +175,11 @@ int
 ia_css_isp_param_copy_isp_mem_if_to_ddr(
     struct ia_css_isp_param_css_segments *ddr,
     const struct ia_css_isp_param_host_segments *host,
-    enum ia_css_param_class pclass) {
+    enum ia_css_param_class pclass)
+{
 	unsigned int mem;
 
-	for (mem = 0; mem < N_IA_CSS_ISP_MEMORIES; mem++)
-	{
+	for (mem = 0; mem < N_IA_CSS_ISP_MEMORIES; mem++) {
 		size_t       size	  = host->params[pclass][mem].size;
 		ia_css_ptr ddr_mem_ptr  = ddr->params[pclass][mem].address;
 		char	    *host_mem_ptr = host->params[pclass][mem].address;
-- 
2.43.0

Re: [PATCH v2] staging: atomisp: fix brace style and trailing whitespace in isp_param.c

[Daniel Baluta]

On 3/11/26 17:13, Kalyani Patra wrote:
> Fix checkpatch errors related to brace placement and remove trailing
> whitespace in isp_param.c.
>
> Reported by scripts/checkpatch.pl.
>
> Signed-off-by: Kalyani Patra <kalyanipatra2003@gmail.com>
> ---

Please keep in mint that when submitting a patch you need to start with version 1, 
saying [PATCH]... it is enough for people to understand is v1.

Now, even if we did an internal review until v2 community doesn't know that and you need

to reset your counting.

Otherwise, people will ask you where is v1 (plus where is the changelog for v1->v2).

As now this is clear, I hope community can ignore [PATCH v2] in the subject as git tools will do

when applying the patch.

With that,

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

Re: [PATCH v2] staging: atomisp: fix brace style and trailing whitespace in isp_param.c

[Kalyani patra]

Hi Daniel,
Thank you for the review and for the clarification about patch versioning.
I will keep that in mind for future submissions.

Thanks,
Kalyani

On Wed, Mar 11, 2026 at 8:47 PM Daniel Baluta <daniel.baluta@nxp.com> wrote:
>
> On 3/11/26 17:13, Kalyani Patra wrote:
> > Fix checkpatch errors related to brace placement and remove trailing
> > whitespace in isp_param.c.
> >
> > Reported by scripts/checkpatch.pl.
> >
> > Signed-off-by: Kalyani Patra <kalyanipatra2003@gmail.com>
> > ---
>
> Please keep in mint that when submitting a patch you need to start with version 1,
> saying [PATCH]... it is enough for people to understand is v1.
>
> Now, even if we did an internal review until v2 community doesn't know that and you need
>
> to reset your counting.
>
> Otherwise, people will ask you where is v1 (plus where is the changelog for v1->v2).
>
> As now this is clear, I hope community can ignore [PATCH v2] in the subject as git tools will do
>
> when applying the patch.
>
> With that,
>
> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
>
>

Re: [PATCH v2] staging: atomisp: fix brace style and trailing whitespace in isp_param.c

[Sakari Ailus]

Hi Kalyani,

On Wed, Mar 11, 2026 at 08:52:20PM +0530, Kalyani patra wrote:
> Hi Daniel,
> Thank you for the review and for the clarification about patch versioning.
> I will keep that in mind for future submissions.

Applied this one... please use "media: staging: atomisp: " prefix in the
future. It's usually a good idea to check what others have used in git log.

-- 
Regards,

Sakari Ailus

Re: [PATCH v2] staging: atomisp: fix brace style and trailing whitespace in isp_param.c

[Sakari Ailus]

Hi Kalyani,

On Tue, Mar 17, 2026 at 02:12:20PM +0530, Kalyani patra wrote:
> Hi Sakari,
> Noted. I’ll keep both of that in kind going forward.
> Thanks!

I first applied the patch to a different branch and it seems the issue the
patch addressed was already fixed by another patch in the atomisp branch.

Thanks.

-- 
Kind regards,

Sakari Ailus

Re: [PATCH v2] staging: atomisp: fix brace style and trailing whitespace in isp_param.c

[Kalyani patra]

On Tue, Mar 17, 2026 at 03:03:00PM +0530, Sakari Ailus wrote:
> I first applied the patch to a different branch and it seems the
> issue the patch addressed was already fixed by another patch in
> the atomisp branch.

Understood, thank you for checking.

-- 
Kalyani Patra

On Tue, Mar 17, 2026 at 3:03 PM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> Hi Kalyani,
>
> On Tue, Mar 17, 2026 at 02:12:20PM +0530, Kalyani patra wrote:
> > Hi Sakari,
> > Noted. I’ll keep both of that in kind going forward.
> > Thanks!
>
> I first applied the patch to a different branch and it seems the issue the
> patch addressed was already fixed by another patch in the atomisp branch.
>
> Thanks.
>
> --
> Kind regards,
>
> Sakari Ailus