* [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite
@ 2026-03-19 9:09 Wenmeng Liu
2026-03-19 10:13 ` Bryan O'Donoghue
2026-03-19 14:44 ` Loic Poulain
0 siblings, 2 replies; 7+ messages in thread
From: Wenmeng Liu @ 2026-03-19 9:09 UTC (permalink / raw)
To: Robert Foss, Todor Tomov, Bryan O'Donoghue,
Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil,
Gjorgji Rosikopulos, Radoslav Tsvetkov
Cc: linux-media, linux-arm-msm, linux-kernel, Wenmeng Liu
VFE lite hardware does not provide a functional PIX path, but after
the per sub-device type resource changes the PIX subdev name is still
assigned unconditionally.
Only assign the PIX subdev name on non-lite VFE variants to avoid
exposing a misleading device name.
Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources")
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
---
drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
index 5baf0e3d4bc461df28d8dcf97a98dec04fa17ceb..2ee4f9ae0ab50e22f916736f1d1664767bdb6a36 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe.c
@@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,
v4l2_subdev_init(sd, &vfe_v4l2_ops);
sd->internal_ops = &vfe_v4l2_internal_ops;
sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
- if (i == VFE_LINE_PIX)
+ if (i == VFE_LINE_PIX && vfe->res->is_lite == false)
snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s",
MSM_VFE_NAME, vfe->id, "pix");
else
---
base-commit: 8e42d2514a7e8eb8d740d0ba82339dd6c0b6463f
change-id: 20260319-camss_fix-506ae164a5dc
Best regards,
--
Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite 2026-03-19 9:09 [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite Wenmeng Liu @ 2026-03-19 10:13 ` Bryan O'Donoghue 2026-03-19 14:44 ` Loic Poulain 1 sibling, 0 replies; 7+ messages in thread From: Bryan O'Donoghue @ 2026-03-19 10:13 UTC (permalink / raw) To: Wenmeng Liu, Robert Foss, Todor Tomov, Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil, Gjorgji Rosikopulos, Radoslav Tsvetkov Cc: linux-media, linux-arm-msm, linux-kernel On 19/03/2026 09:09, Wenmeng Liu wrote: > VFE lite hardware does not provide a functional PIX path, but after > the per sub-device type resource changes the PIX subdev name is still > assigned unconditionally. > > Only assign the PIX subdev name on non-lite VFE variants to avoid > exposing a misleading device name. > > Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources") > Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> > --- > drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index 5baf0e3d4bc461df28d8dcf97a98dec04fa17ceb..2ee4f9ae0ab50e22f916736f1d1664767bdb6a36 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe, > v4l2_subdev_init(sd, &vfe_v4l2_ops); > sd->internal_ops = &vfe_v4l2_internal_ops; > sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > - if (i == VFE_LINE_PIX) > + if (i == VFE_LINE_PIX && vfe->res->is_lite == false) > snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s", > MSM_VFE_NAME, vfe->id, "pix"); > else > > --- > base-commit: 8e42d2514a7e8eb8d740d0ba82339dd6c0b6463f > change-id: 20260319-camss_fix-506ae164a5dc > > Best regards, Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite 2026-03-19 9:09 [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite Wenmeng Liu 2026-03-19 10:13 ` Bryan O'Donoghue @ 2026-03-19 14:44 ` Loic Poulain 2026-03-23 2:13 ` Wenmeng Liu 1 sibling, 1 reply; 7+ messages in thread From: Loic Poulain @ 2026-03-19 14:44 UTC (permalink / raw) To: Wenmeng Liu Cc: Robert Foss, Todor Tomov, Bryan O'Donoghue, Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil, Gjorgji Rosikopulos, Radoslav Tsvetkov, linux-media, linux-arm-msm, linux-kernel On Thu, Mar 19, 2026 at 10:11 AM Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> wrote: > > VFE lite hardware does not provide a functional PIX path, but after > the per sub-device type resource changes the PIX subdev name is still > assigned unconditionally. > > Only assign the PIX subdev name on non-lite VFE variants to avoid > exposing a misleading device name. > > Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources") > Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> > --- > drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index 5baf0e3d4bc461df28d8dcf97a98dec04fa17ceb..2ee4f9ae0ab50e22f916736f1d1664767bdb6a36 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe, > v4l2_subdev_init(sd, &vfe_v4l2_ops); > sd->internal_ops = &vfe_v4l2_internal_ops; > sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > - if (i == VFE_LINE_PIX) > + if (i == VFE_LINE_PIX && vfe->res->is_lite == false) > snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s", > MSM_VFE_NAME, vfe->id, "pix"); So the PIX path will be called RDI? Doesn’t that seem misleading as well? > else > > --- > base-commit: 8e42d2514a7e8eb8d740d0ba82339dd6c0b6463f > change-id: 20260319-camss_fix-506ae164a5dc > > Best regards, > -- > Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite 2026-03-19 14:44 ` Loic Poulain @ 2026-03-23 2:13 ` Wenmeng Liu 2026-03-23 9:55 ` Loic Poulain 0 siblings, 1 reply; 7+ messages in thread From: Wenmeng Liu @ 2026-03-23 2:13 UTC (permalink / raw) To: Loic Poulain Cc: Robert Foss, Todor Tomov, Bryan O'Donoghue, Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil, Gjorgji Rosikopulos, Radoslav Tsvetkov, linux-media, linux-arm-msm, linux-kernel On 3/19/2026 10:44 PM, Loic Poulain wrote: > On Thu, Mar 19, 2026 at 10:11 AM Wenmeng Liu > <wenmeng.liu@oss.qualcomm.com> wrote: >> >> VFE lite hardware does not provide a functional PIX path, but after >> the per sub-device type resource changes the PIX subdev name is still >> assigned unconditionally. >> >> Only assign the PIX subdev name on non-lite VFE variants to avoid >> exposing a misleading device name. >> >> Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources") >> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> >> --- >> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c >> index 5baf0e3d4bc461df28d8dcf97a98dec04fa17ceb..2ee4f9ae0ab50e22f916736f1d1664767bdb6a36 100644 >> --- a/drivers/media/platform/qcom/camss/camss-vfe.c >> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c >> @@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe, >> v4l2_subdev_init(sd, &vfe_v4l2_ops); >> sd->internal_ops = &vfe_v4l2_internal_ops; >> sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; >> - if (i == VFE_LINE_PIX) >> + if (i == VFE_LINE_PIX && vfe->res->is_lite == false) >> snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s", >> MSM_VFE_NAME, vfe->id, "pix"); > > So the PIX path will be called RDI? Doesn’t that seem misleading as well? when i == VFE_LINE_PIX and vfe->res->is_lite == false then vfe name is pix, not rdi. thanks, Wenmeng ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite 2026-03-23 2:13 ` Wenmeng Liu @ 2026-03-23 9:55 ` Loic Poulain 2026-03-24 13:10 ` Wenmeng Liu 0 siblings, 1 reply; 7+ messages in thread From: Loic Poulain @ 2026-03-23 9:55 UTC (permalink / raw) To: Wenmeng Liu Cc: Robert Foss, Todor Tomov, Bryan O'Donoghue, Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil, Gjorgji Rosikopulos, Radoslav Tsvetkov, linux-media, linux-arm-msm, linux-kernel On Mon, Mar 23, 2026 at 3:13 AM Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> wrote: > > > > On 3/19/2026 10:44 PM, Loic Poulain wrote: > > On Thu, Mar 19, 2026 at 10:11 AM Wenmeng Liu > > <wenmeng.liu@oss.qualcomm.com> wrote: > >> > >> VFE lite hardware does not provide a functional PIX path, but after > >> the per sub-device type resource changes the PIX subdev name is still > >> assigned unconditionally. > >> > >> Only assign the PIX subdev name on non-lite VFE variants to avoid > >> exposing a misleading device name. > >> > >> Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources") > >> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> > >> --- > >> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > >> index 5baf0e3d4bc461df28d8dcf97a98dec04fa17ceb..2ee4f9ae0ab50e22f916736f1d1664767bdb6a36 100644 > >> --- a/drivers/media/platform/qcom/camss/camss-vfe.c > >> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > >> @@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe, > >> v4l2_subdev_init(sd, &vfe_v4l2_ops); > >> sd->internal_ops = &vfe_v4l2_internal_ops; > >> sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > >> - if (i == VFE_LINE_PIX) > >> + if (i == VFE_LINE_PIX && vfe->res->is_lite == false) > >> snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s", > >> MSM_VFE_NAME, vfe->id, "pix"); > > > > So the PIX path will be called RDI? Doesn’t that seem misleading as well? > when i == VFE_LINE_PIX and vfe->res->is_lite == false then vfe name is > pix, not rdi. I mean when is_lite==true, we're going to name the PIX(lite) path RDI, whereas it's not a raw dump interface, I guess pix-lite includes minimal processing engine. Regards, Loic ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite 2026-03-23 9:55 ` Loic Poulain @ 2026-03-24 13:10 ` Wenmeng Liu 2026-03-24 14:09 ` Loic Poulain 0 siblings, 1 reply; 7+ messages in thread From: Wenmeng Liu @ 2026-03-24 13:10 UTC (permalink / raw) To: Loic Poulain Cc: Robert Foss, Todor Tomov, Bryan O'Donoghue, Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil, Gjorgji Rosikopulos, Radoslav Tsvetkov, linux-media, linux-arm-msm, linux-kernel On 3/23/2026 5:55 PM, Loic Poulain wrote: > On Mon, Mar 23, 2026 at 3:13 AM Wenmeng Liu > <wenmeng.liu@oss.qualcomm.com> wrote: >> >> >> >> On 3/19/2026 10:44 PM, Loic Poulain wrote: >>> On Thu, Mar 19, 2026 at 10:11 AM Wenmeng Liu >>> <wenmeng.liu@oss.qualcomm.com> wrote: >>>> >>>> VFE lite hardware does not provide a functional PIX path, but after >>>> the per sub-device type resource changes the PIX subdev name is still >>>> assigned unconditionally. >>>> >>>> Only assign the PIX subdev name on non-lite VFE variants to avoid >>>> exposing a misleading device name. >>>> >>>> Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources") >>>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> >>>> --- >>>> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c >>>> index 5baf0e3d4bc461df28d8dcf97a98dec04fa17ceb..2ee4f9ae0ab50e22f916736f1d1664767bdb6a36 100644 >>>> --- a/drivers/media/platform/qcom/camss/camss-vfe.c >>>> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c >>>> @@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe, >>>> v4l2_subdev_init(sd, &vfe_v4l2_ops); >>>> sd->internal_ops = &vfe_v4l2_internal_ops; >>>> sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; >>>> - if (i == VFE_LINE_PIX) >>>> + if (i == VFE_LINE_PIX && vfe->res->is_lite == false) >>>> snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s", >>>> MSM_VFE_NAME, vfe->id, "pix"); >>> >>> So the PIX path will be called RDI? Doesn’t that seem misleading as well? >> when i == VFE_LINE_PIX and vfe->res->is_lite == false then vfe name is >> pix, not rdi. > > I mean when is_lite==true, we're going to name the PIX(lite) path RDI, > whereas it's not a raw dump interface, I guess pix-lite includes minimal > processing engine. For VFE Lite, only RDI paths are supported. There is no PIX output. Thanks, Wenmeng ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite 2026-03-24 13:10 ` Wenmeng Liu @ 2026-03-24 14:09 ` Loic Poulain 0 siblings, 0 replies; 7+ messages in thread From: Loic Poulain @ 2026-03-24 14:09 UTC (permalink / raw) To: Wenmeng Liu Cc: Robert Foss, Todor Tomov, Bryan O'Donoghue, Vladimir Zapolskiy, Mauro Carvalho Chehab, Hans Verkuil, Gjorgji Rosikopulos, Radoslav Tsvetkov, linux-media, linux-arm-msm, linux-kernel On Tue, Mar 24, 2026 at 2:10 PM Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> wrote: > > > > On 3/23/2026 5:55 PM, Loic Poulain wrote: > > On Mon, Mar 23, 2026 at 3:13 AM Wenmeng Liu > > <wenmeng.liu@oss.qualcomm.com> wrote: > >> > >> > >> > >> On 3/19/2026 10:44 PM, Loic Poulain wrote: > >>> On Thu, Mar 19, 2026 at 10:11 AM Wenmeng Liu > >>> <wenmeng.liu@oss.qualcomm.com> wrote: > >>>> > >>>> VFE lite hardware does not provide a functional PIX path, but after > >>>> the per sub-device type resource changes the PIX subdev name is still > >>>> assigned unconditionally. > >>>> > >>>> Only assign the PIX subdev name on non-lite VFE variants to avoid > >>>> exposing a misleading device name. > >>>> > >>>> Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources") > >>>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> > >>>> --- > >>>> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > >>>> index 5baf0e3d4bc461df28d8dcf97a98dec04fa17ceb..2ee4f9ae0ab50e22f916736f1d1664767bdb6a36 100644 > >>>> --- a/drivers/media/platform/qcom/camss/camss-vfe.c > >>>> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > >>>> @@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe, > >>>> v4l2_subdev_init(sd, &vfe_v4l2_ops); > >>>> sd->internal_ops = &vfe_v4l2_internal_ops; > >>>> sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > >>>> - if (i == VFE_LINE_PIX) > >>>> + if (i == VFE_LINE_PIX && vfe->res->is_lite == false) > >>>> snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s", > >>>> MSM_VFE_NAME, vfe->id, "pix"); > >>> > >>> So the PIX path will be called RDI? Doesn’t that seem misleading as well? > >> when i == VFE_LINE_PIX and vfe->res->is_lite == false then vfe name is > >> pix, not rdi. > > > > I mean when is_lite==true, we're going to name the PIX(lite) path RDI, > > whereas it's not a raw dump interface, I guess pix-lite includes minimal > > processing engine. > > For VFE Lite, only RDI paths are supported. There is no PIX output. Ah ok, understood, this is RDI3. At some point we should clean up the code to avoid relying on statically defined RDI/PIX indices. Regards, Loic ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-03-24 14:09 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-03-19 9:09 [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite Wenmeng Liu 2026-03-19 10:13 ` Bryan O'Donoghue 2026-03-19 14:44 ` Loic Poulain 2026-03-23 2:13 ` Wenmeng Liu 2026-03-23 9:55 ` Loic Poulain 2026-03-24 13:10 ` Wenmeng Liu 2026-03-24 14:09 ` Loic Poulain
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox