From: Devin Heitmueller <dheitmueller@kernellabs.com>
To: Nigel Kettlewell <nigel.kettlewell@googlemail.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Support HVR-1200 analog video as a clone of HVR-1500. Tested, composite and s-video inputs.
Date: Mon, 18 Sep 2017 08:57:08 -0400 [thread overview]
Message-ID: <CAGoCfizQS3fg2Sqjtg2ypiCqa5cMQ=irMZ1nwEVJ8+TeBuAZCA@mail.gmail.com> (raw)
In-Reply-To: <59BEEC39.2030609@googlemail.com>
On Sun, Sep 17, 2017 at 5:42 PM, Nigel Kettlewell
<nigel.kettlewell@googlemail.com> wrote:
> I propose the following patch to support Hauppauge HVR-1200 analog video,
> nothing more than a clone of HVR-1500. Patch based on Linux 4.9 commit
> 69973b830859bc6529a7a0468ba0d80ee5117826
>
> I have tested composite and S-Video inputs.
>
> With the change, HVR-1200 devices have a /dev/video<n> entry which is
> accessible in the normal way.
>
> Let me know if you need anything more.
I'm not confident the tuner config for this board is correct. The
HVR-1200 is much closer to the HVR-1250 as opposed to the HVR-1500,
and IIRC it didn't have an xc3028.
I don't dispute that with the patch in question the composite/s-video
are probably working ok, but I wouldn't recommend accepting this patch
as-is until the tuner is verified for DVB-T and analog (ideally both).
Can you provide the output of dmesg on device load? If it's filled
with a bunch of errors showing xc3028 firmware load failures, that
would be a smoking gun that it doesn't have the xc3028.
Devin
--
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
next prev parent reply other threads:[~2017-09-18 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-17 21:42 [PATCH] Support HVR-1200 analog video as a clone of HVR-1500. Tested, composite and s-video inputs Nigel Kettlewell
2017-09-18 12:57 ` Devin Heitmueller [this message]
[not found] ` <59C1044E.8060805@googlemail.com>
2017-09-19 19:16 ` Nigel Kettlewell
2017-12-04 12:01 ` Hans Verkuil
2018-01-02 21:46 ` Nigel Kettlewell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGoCfizQS3fg2Sqjtg2ypiCqa5cMQ=irMZ1nwEVJ8+TeBuAZCA@mail.gmail.com' \
--to=dheitmueller@kernellabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nigel.kettlewell@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).