Re: [PATCH] platform/x86: int3472: Add GPIO type 0x02 (strobe) mapping

[Andy Shevchenko <andy.shevchenko@gmail.com>]

On Fri, Mar 20, 2026 at 11:35 AM Marco Nenciarini <mnencia@kcore.it> wrote:

You sent three emails without versioning (no new versions) and no
changelog. Please, slow down with that, it's quite confusing. The
recommended period between two sequential versions is 24h+. Also see
more comments below.

> Some ACPI tables on Intel Meteor Lake and Arrow Lake platforms define
> GPIO resources with type 0x02 for INT3472 camera sensor power control.
> This type is not currently handled, causing a "GPIO type 0x02 unknown;
> the sensor may not work" warning and preventing proper sensor power
> sequencing.
>
> Map GPIO type 0x02 (strobe) to the privacy LED handler, matching the
> approach used for similar illumination-related GPIOs. This is consistent
> with the original proposal by Hao Yao [1].
>
> Tested on a Dell Pro Max 16 Premium (Arrow Lake-H) with OmniVision
> OV08F4 sensor connected via Intel IPU6 and Synaptics SVP7500 USBIO
> bridge. With this patch applied, the int3472-discrete driver no longer
> warns about unknown GPIO type 0x02, and the sensor probes successfully.

> [1] https://lore.kernel.org/all/20231007021309.9332-1-hao.yao@intel.com/

This should be a Link tag in a form

Link: ...$URL... [1]

> Link: https://bugs.debian.org/1130114
> Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2138991

These are basically should be Closes: tags

...

> Cc: Hao Yao <hao.yao@intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Andy Shevchenko <andy@kernel.org>

These Cc's are better to be after the '---' line below. The Git
tooling will recognize them and use them in email as intended.

> Signed-off-by: Marco Nenciarini <mnencia@kcore.it>

...

> +       case INT3472_GPIO_TYPE_STROBE:
>         case INT3472_GPIO_TYPE_PRIVACY_LED:

Hmm... But strobe is usually used for LED flash... We probably need
Sakari and/or other Intel camera guys to elaborate on this.

>                 *con_id = "privacy-led";
>                 *gpio_flags = GPIO_ACTIVE_HIGH;

...

> +               case INT3472_GPIO_TYPE_STROBE:
>                 case INT3472_GPIO_TYPE_PRIVACY_LED:
>                         ret = skl_int3472_register_pled(int3472, gpio);

Ditto.

-- 
With Best Regards,
Andy Shevchenko