* [PATCH v2] arm64: dts: qcom: sm8550: Add support for camss
@ 2025-06-12 8:01 Wenmeng Liu
2025-06-12 11:11 ` Krzysztof Kozlowski
2025-06-18 4:09 ` Bjorn Andersson
0 siblings, 2 replies; 6+ messages in thread
From: Wenmeng Liu @ 2025-06-12 8:01 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, todor.too, rfoss, bryan.odonoghue
Cc: linux-arm-msm, devicetree, linux-kernel, linux-media, Depeng Shao,
Wenmeng Liu, Konrad Dybcio, Vladimir Zapolskiy
Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
SM8550 provides
- 3 x VFE, 3 RDI per VFE
- 2 x VFE Lite, 4 RDI per VFE
- 3 x CSID
- 2 x CSID Lite
- 8 x CSI PHY
Co-developed-by: Depeng Shao <quic_depengs@quicinc.com>
Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
Changes in v2:
- Change the isp label to camss
- Link to v1: https://lore.kernel.org/r/20250516072707.388332-1-quic_wenmliu@quicinc.com/
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 210 +++++++++++++++++++++++++++++++++++
1 file changed, 210 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 82cabf777cd2c1dc87457aeede913873e7322ec2..3c26a39011188fbcb0dad7105ebeaef55fbccbc2 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -3325,6 +3325,216 @@ cci2_i2c1: i2c-bus@1 {
};
};
+ camss: isp@acb7000 {
+ compatible = "qcom,sm8550-camss";
+
+ reg = <0x0 0x0acb7000 0x0 0x0d00>,
+ <0x0 0x0acb9000 0x0 0x0d00>,
+ <0x0 0x0acbb000 0x0 0x0d00>,
+ <0x0 0x0acca000 0x0 0x0a00>,
+ <0x0 0x0acce000 0x0 0x0a00>,
+ <0x0 0x0acb6000 0x0 0x1000>,
+ <0x0 0x0ace4000 0x0 0x2000>,
+ <0x0 0x0ace6000 0x0 0x2000>,
+ <0x0 0x0ace8000 0x0 0x2000>,
+ <0x0 0x0acea000 0x0 0x2000>,
+ <0x0 0x0acec000 0x0 0x2000>,
+ <0x0 0x0acee000 0x0 0x2000>,
+ <0x0 0x0acf0000 0x0 0x2000>,
+ <0x0 0x0acf2000 0x0 0x2000>,
+ <0x0 0x0ac62000 0x0 0xf000>,
+ <0x0 0x0ac71000 0x0 0xf000>,
+ <0x0 0x0ac80000 0x0 0xf000>,
+ <0x0 0x0accb000 0x0 0x1800>,
+ <0x0 0x0accf000 0x0 0x1800>;
+ reg-names = "csid0",
+ "csid1",
+ "csid2",
+ "csid_lite0",
+ "csid_lite1",
+ "csid_wrapper",
+ "csiphy0",
+ "csiphy1",
+ "csiphy2",
+ "csiphy3",
+ "csiphy4",
+ "csiphy5",
+ "csiphy6",
+ "csiphy7",
+ "vfe0",
+ "vfe1",
+ "vfe2",
+ "vfe_lite0",
+ "vfe_lite1";
+
+ clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>,
+ <&camcc CAM_CC_CPAS_AHB_CLK>,
+ <&camcc CAM_CC_CPAS_FAST_AHB_CLK>,
+ <&camcc CAM_CC_CPAS_IFE_LITE_CLK>,
+ <&camcc CAM_CC_CPAS_IFE_0_CLK>,
+ <&camcc CAM_CC_CPAS_IFE_1_CLK>,
+ <&camcc CAM_CC_CPAS_IFE_2_CLK>,
+ <&camcc CAM_CC_CSID_CLK>,
+ <&camcc CAM_CC_CSIPHY0_CLK>,
+ <&camcc CAM_CC_CSI0PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY1_CLK>,
+ <&camcc CAM_CC_CSI1PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY2_CLK>,
+ <&camcc CAM_CC_CSI2PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY3_CLK>,
+ <&camcc CAM_CC_CSI3PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY4_CLK>,
+ <&camcc CAM_CC_CSI4PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY5_CLK>,
+ <&camcc CAM_CC_CSI5PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY6_CLK>,
+ <&camcc CAM_CC_CSI6PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSIPHY7_CLK>,
+ <&camcc CAM_CC_CSI7PHYTIMER_CLK>,
+ <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>,
+ <&gcc GCC_CAMERA_HF_AXI_CLK>,
+ <&camcc CAM_CC_IFE_0_CLK>,
+ <&camcc CAM_CC_IFE_0_FAST_AHB_CLK>,
+ <&camcc CAM_CC_IFE_1_CLK>,
+ <&camcc CAM_CC_IFE_1_FAST_AHB_CLK>,
+ <&camcc CAM_CC_IFE_2_CLK>,
+ <&camcc CAM_CC_IFE_2_FAST_AHB_CLK>,
+ <&camcc CAM_CC_IFE_LITE_CLK>,
+ <&camcc CAM_CC_IFE_LITE_AHB_CLK>,
+ <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>,
+ <&camcc CAM_CC_IFE_LITE_CSID_CLK>;
+ clock-names = "camnoc_axi",
+ "cpas_ahb",
+ "cpas_fast_ahb_clk",
+ "cpas_ife_lite",
+ "cpas_vfe0",
+ "cpas_vfe1",
+ "cpas_vfe2",
+ "csid",
+ "csiphy0",
+ "csiphy0_timer",
+ "csiphy1",
+ "csiphy1_timer",
+ "csiphy2",
+ "csiphy2_timer",
+ "csiphy3",
+ "csiphy3_timer",
+ "csiphy4",
+ "csiphy4_timer",
+ "csiphy5",
+ "csiphy5_timer",
+ "csiphy6",
+ "csiphy6_timer",
+ "csiphy7",
+ "csiphy7_timer",
+ "csiphy_rx",
+ "gcc_axi_hf",
+ "vfe0",
+ "vfe0_fast_ahb",
+ "vfe1",
+ "vfe1_fast_ahb",
+ "vfe2",
+ "vfe2_fast_ahb",
+ "vfe_lite",
+ "vfe_lite_ahb",
+ "vfe_lite_cphy_rx",
+ "vfe_lite_csid";
+
+ interrupts = <GIC_SPI 601 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 603 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 431 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 605 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 376 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 122 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 89 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 278 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 277 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 602 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 606 IRQ_TYPE_EDGE_RISING>,
+ <GIC_SPI 377 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "csid0",
+ "csid1",
+ "csid2",
+ "csid_lite0",
+ "csid_lite1",
+ "csiphy0",
+ "csiphy1",
+ "csiphy2",
+ "csiphy3",
+ "csiphy4",
+ "csiphy5",
+ "csiphy6",
+ "csiphy7",
+ "vfe0",
+ "vfe1",
+ "vfe2",
+ "vfe_lite0",
+ "vfe_lite1";
+
+ interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_CAMERA_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
+ <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+ interconnect-names = "ahb",
+ "hf_0_mnoc";
+
+ iommus = <&apps_smmu 0x800 0x20>;
+
+ power-domains = <&camcc CAM_CC_IFE_0_GDSC>,
+ <&camcc CAM_CC_IFE_1_GDSC>,
+ <&camcc CAM_CC_IFE_2_GDSC>,
+ <&camcc CAM_CC_TITAN_TOP_GDSC>;
+ power-domain-names = "ife0",
+ "ife1",
+ "ife2",
+ "top";
+
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ };
+
+ port@1 {
+ reg = <1>;
+ };
+
+ port@2 {
+ reg = <2>;
+ };
+
+ port@3 {
+ reg = <3>;
+ };
+
+ port@4 {
+ reg = <4>;
+ };
+
+ port@5 {
+ reg = <5>;
+ };
+
+ port@6 {
+ reg = <6>;
+ };
+
+ port@7 {
+ reg = <7>;
+ };
+ };
+ };
+
camcc: clock-controller@ade0000 {
compatible = "qcom,sm8550-camcc";
reg = <0 0x0ade0000 0 0x20000>;
---
base-commit: ed61cb3d78d585209ec775933078e268544fe9a4
change-id: 20250516-sm8550-camss-221d7b4f98f7
Best regards,
--
Wenmeng Liu <quic_wenmliu@quicinc.com>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8550: Add support for camss
2025-06-12 8:01 [PATCH v2] arm64: dts: qcom: sm8550: Add support for camss Wenmeng Liu
@ 2025-06-12 11:11 ` Krzysztof Kozlowski
2025-06-12 11:12 ` Krzysztof Kozlowski
2025-06-18 4:09 ` Bjorn Andersson
1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-12 11:11 UTC (permalink / raw)
To: Wenmeng Liu, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, todor.too, rfoss,
bryan.odonoghue
Cc: linux-arm-msm, devicetree, linux-kernel, linux-media, Depeng Shao,
Konrad Dybcio, Vladimir Zapolskiy
On 12/06/2025 10:01, Wenmeng Liu wrote:
> Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
> includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
>
> SM8550 provides
> - 3 x VFE, 3 RDI per VFE
> - 2 x VFE Lite, 4 RDI per VFE
> - 3 x CSID
> - 2 x CSID Lite
> - 8 x CSI PHY
>
> Co-developed-by: Depeng Shao <quic_depengs@quicinc.com>
> Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Where did this happen? Please point specific email.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8550: Add support for camss
2025-06-12 11:11 ` Krzysztof Kozlowski
@ 2025-06-12 11:12 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-12 11:12 UTC (permalink / raw)
To: Wenmeng Liu, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, todor.too, rfoss,
bryan.odonoghue
Cc: linux-arm-msm, devicetree, linux-kernel, linux-media, Depeng Shao,
Konrad Dybcio, Vladimir Zapolskiy
On 12/06/2025 13:11, Krzysztof Kozlowski wrote:
> On 12/06/2025 10:01, Wenmeng Liu wrote:
>> Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
>> includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
>>
>> SM8550 provides
>> - 3 x VFE, 3 RDI per VFE
>> - 2 x VFE Lite, 4 RDI per VFE
>> - 3 x CSID
>> - 2 x CSID Lite
>> - 8 x CSI PHY
>>
>> Co-developed-by: Depeng Shao <quic_depengs@quicinc.com>
>> Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
>> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>
>
> Where did this happen? Please point specific email.
OK, I found, never mind.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8550: Add support for camss
2025-06-12 8:01 [PATCH v2] arm64: dts: qcom: sm8550: Add support for camss Wenmeng Liu
2025-06-12 11:11 ` Krzysztof Kozlowski
@ 2025-06-18 4:09 ` Bjorn Andersson
2025-07-03 20:19 ` Rob Herring
1 sibling, 1 reply; 6+ messages in thread
From: Bjorn Andersson @ 2025-06-18 4:09 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
todor.too, rfoss, bryan.odonoghue, Wenmeng Liu
Cc: linux-arm-msm, devicetree, linux-kernel, linux-media, Depeng Shao,
Konrad Dybcio, Vladimir Zapolskiy
On Thu, 12 Jun 2025 16:01:26 +0800, Wenmeng Liu wrote:
> Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
> includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
>
> SM8550 provides
> - 3 x VFE, 3 RDI per VFE
> - 2 x VFE Lite, 4 RDI per VFE
> - 3 x CSID
> - 2 x CSID Lite
> - 8 x CSI PHY
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sm8550: Add support for camss
commit: c5aeb681fcdd23d042d780f89ddcf908a13baee2
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8550: Add support for camss
2025-06-18 4:09 ` Bjorn Andersson
@ 2025-07-03 20:19 ` Rob Herring
2025-07-03 20:42 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2025-07-03 20:19 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, todor.too,
rfoss, bryan.odonoghue, Wenmeng Liu, linux-arm-msm, devicetree,
linux-kernel, linux-media, Depeng Shao, Konrad Dybcio,
Vladimir Zapolskiy
On Tue, Jun 17, 2025 at 11:09 PM Bjorn Andersson <andersson@kernel.org> wrote:
>
>
> On Thu, 12 Jun 2025 16:01:26 +0800, Wenmeng Liu wrote:
> > Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
> > includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
> >
> > SM8550 provides
> > - 3 x VFE, 3 RDI per VFE
> > - 2 x VFE Lite, 4 RDI per VFE
> > - 3 x CSID
> > - 2 x CSID Lite
> > - 8 x CSI PHY
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] arm64: dts: qcom: sm8550: Add support for camss
> commit: c5aeb681fcdd23d042d780f89ddcf908a13baee2
And adds warnings:
6 clock-controller@ade0000 (qcom,sm8550-camcc): required-opps:
[[33]] is too short
6 clock-controller@ade0000 (qcom,sm8550-camcc): power-domains:
[[56, 6]] is too short
6 clock-controller@ade0000 (qcom,sm8550-camcc): Unevaluated
properties are not allowed ('power-domains', 'required-opps' were
unexpected)
6 clock-controller@aaf0000 (qcom,sm8550-videocc):
required-opps: [[33]] is too short
6 clock-controller@aaf0000 (qcom,sm8550-videocc):
power-domains: [[56, 6]] is too short
6 clock-controller@aaf0000 (qcom,sm8550-videocc): Unevaluated
properties are not allowed ('power-domains', 'required-opps' were
unexpected)
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8550: Add support for camss
2025-07-03 20:19 ` Rob Herring
@ 2025-07-03 20:42 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2025-07-03 20:42 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Konrad Dybcio, Krzysztof Kozlowski, Conor Dooley, todor.too,
rfoss, bryan.odonoghue, Wenmeng Liu, linux-arm-msm, devicetree,
linux-kernel, linux-media, Depeng Shao, Konrad Dybcio,
Vladimir Zapolskiy
On Thu, Jul 3, 2025 at 3:19 PM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Jun 17, 2025 at 11:09 PM Bjorn Andersson <andersson@kernel.org> wrote:
> >
> >
> > On Thu, 12 Jun 2025 16:01:26 +0800, Wenmeng Liu wrote:
> > > Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
> > > includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
> > >
> > > SM8550 provides
> > > - 3 x VFE, 3 RDI per VFE
> > > - 2 x VFE Lite, 4 RDI per VFE
> > > - 3 x CSID
> > > - 2 x CSID Lite
> > > - 8 x CSI PHY
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] arm64: dts: qcom: sm8550: Add support for camss
> > commit: c5aeb681fcdd23d042d780f89ddcf908a13baee2
>
> And adds warnings:
>
> 6 clock-controller@ade0000 (qcom,sm8550-camcc): required-opps:
> [[33]] is too short
> 6 clock-controller@ade0000 (qcom,sm8550-camcc): power-domains:
> [[56, 6]] is too short
> 6 clock-controller@ade0000 (qcom,sm8550-camcc): Unevaluated
> properties are not allowed ('power-domains', 'required-opps' were
> unexpected)
> 6 clock-controller@aaf0000 (qcom,sm8550-videocc):
> required-opps: [[33]] is too short
> 6 clock-controller@aaf0000 (qcom,sm8550-videocc):
> power-domains: [[56, 6]] is too short
> 6 clock-controller@aaf0000 (qcom,sm8550-videocc): Unevaluated
> properties are not allowed ('power-domains', 'required-opps' were
> unexpected)
Actually, looks like we are waiting on "[PATCH v5 17/18] arm64: dts:
qcom: sm8550: Additionally manage MXC power domain in camcc" and
other patches in the series to be applied.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-07-03 20:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-12 8:01 [PATCH v2] arm64: dts: qcom: sm8550: Add support for camss Wenmeng Liu
2025-06-12 11:11 ` Krzysztof Kozlowski
2025-06-12 11:12 ` Krzysztof Kozlowski
2025-06-18 4:09 ` Bjorn Andersson
2025-07-03 20:19 ` Rob Herring
2025-07-03 20:42 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).