Re: [PATCH 30/32] media: rcar-vin: add Gen3 devicetree bindings documentation

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Wed, Nov 2, 2016 at 2:23 PM, Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Document the Gen3 devicetree bindings. The new bindings are all handled
> in the port@1 node, if a endpoint is described as on Gen2 in port@0 the

an endpoint

> driver will work in Gen2 mode and this is supported on Gen3. The new
> CSI-2 video sources are only supported on Gen3.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>  .../devicetree/bindings/media/rcar_vin.txt         | 116 +++++++++++++++++++--
>  1 file changed, 106 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index 6a4e61c..a51cf70 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -2,8 +2,12 @@ Renesas RCar Video Input driver (rcar_vin)
>  ------------------------------------------
>
>  The rcar_vin device provides video input capabilities for the Renesas R-Car
> -family of devices. The current blocks are always slaves and suppot one input
> -channel which can be either RGB, YUYV or BT656.
> +family of devices.
> +
> +On Gen2 the current blocks are always slaves and support one input channel
> +which can be either RGB, YUYV or BT656. On Gen3 the current blocks are
> +always slaves and support multiple input channels which can be ether RGB,

either

> +YUVU, BT656 or CSI-2.

> @@ -92,6 +105,89 @@ Board setup example (vin1 composite video input)
>          };
>  };
>
> +Device node example Gen3
> +------------------------
> +
> +        aliases {
> +                vin0 = &vin0;
> +        };
> +
> +        vin1: video@e6ef1000 {
> +                compatible = "renesas,vin-r8a7796";
> +                reg =  <0 0xe6ef1000 0 0x1000>;
> +                interrupts = <0 189 IRQ_TYPE_LEVEL_HIGH>;
> +                clocks = <&cpg CPG_MOD 810>;
> +                power-domains = <&cpg>;

Please update the power-domains property to match reality.

> +                status = "disabled";
> +
> +                ports {
> +                        #address-cells = <1>;
> +                        #size-cells = <0>;
> +
> +                        port@1 {
> +                                #address-cells = <1>;
> +                                #size-cells = <0>;
> +
> +                                reg = <1>;
> +
> +                                vin1csi20: endpoint@0 {
> +                                        reg = <0>;
> +                                        remote-endpoint= <&csi20vin1>;
> +                                };
> +                        };
> +                };
> +        };
> +
> +        csi20: csi2@fea80000 {
> +                compatible = "renesas,r8a7796-csi2";
> +                reg = <0 0xfea80000 0 0x10000>;
> +                interrupts = <0 184 IRQ_TYPE_LEVEL_HIGH>;
> +                clocks = <&cpg CPG_MOD 714>;
> +                power-domains = <&cpg>;

Likewise.

> +                status = "disabled";
> +
> +                ports {
> +                        #address-cells = <1>;
> +                        #size-cells = <0>;
> +
> +                        port@1 {
> +                                #address-cells = <1>;
> +                                #size-cells = <0>;
> +
> +                                reg = <1>;
> +
> +                                csi20vin1: endpoint@1 {
> +                                        reg = <1>;
> +                                        remote-endpoint = <&vin1csi20>;
> +                                };
> +                        };
> +                };
> +        };




-- 
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds