[PATCH 0/2] edid-decode: ARVR parsers and DisplayID sanity checks

[PATCH 0/2] edid-decode: ARVR parsers and DisplayID sanity checks

[HAYOU YASSINE]

[-- Attachment #1.1: Type: text/plain, Size: 1331 bytes --]

Hi,

This patch series includes two improvements to edid-decode:

Patch 1/2: Implements full parsing for DisplayID 2.1 AR/VR data blocks
- Tag 0x2c (ARVR_HMD): 79-byte block with optics, lens adjustment,
  field of view, center of projection, and streams per layer fields
- Tag 0x2d (ARVR_Layer): 20-byte block with HMD identification,
  layer configuration, lens distortion, and scaling support
- Includes comprehensive sanity checks for both blocks

Patch 2/2: Adds validation checks for DisplayID data blocks
- Tag 0x20 (Product ID): Validates payload length, week range, and model
year
- Tag 0x21 (Display Parameters v2): Validates pixel format, chromaticity
  coordinates, luminance information, and gamma EOTF range
- Tag 0x22 (Type VII Timing): Validates pixel clock max, image dimensions
max,
  and negative blanking periods
- Tag 0x24 (Type IX Timing): Validates image dimensions max and refresh
rate max
- Tag 0x25 (Dynamic Video Timing Range Limits): Validates pixel clock and
  refresh rate ranges with revision-specific limits

These patches improve edid-decode's ability to parse and validate DisplayID
data according to the VESA DisplayID Standard Version 2.1a, helping identify
corrupted or invalid EDID data early and providing better error reporting
for debugging display issues.

Please review.

Thanks,
Yassine

[-- Attachment #1.2: Type: text/html, Size: 1449 bytes --]

[-- Attachment #2: patch-0002-displayid-sanity-checks.patch --]
[-- Type: application/octet-stream, Size: 18352 bytes --]

[-- Attachment #3: patch-0001-edid-decode-arvr.patch --]
[-- Type: application/octet-stream, Size: 40258 bytes --]

Re: [PATCH 0/2] edid-decode: ARVR parsers and DisplayID sanity checks

[Hans Verkuil]

Hi Yassine,

On 23/01/2026 16:26, HAYOU YASSINE wrote:
> Hi,
> 
> This patch series includes two improvements to edid-decode:
> 
> Patch 1/2: Implements full parsing for DisplayID 2.1 AR/VR data blocks
> - Tag 0x2c (ARVR_HMD): 79-byte block with optics, lens adjustment,
>   field of view, center of projection, and streams per layer fields
> - Tag 0x2d (ARVR_Layer): 20-byte block with HMD identification,
>   layer configuration, lens distortion, and scaling support
> - Includes comprehensive sanity checks for both blocks
> 
> Patch 2/2: Adds validation checks for DisplayID data blocks
> - Tag 0x20 (Product ID): Validates payload length, week range, and model year
> - Tag 0x21 (Display Parameters v2): Validates pixel format, chromaticity
>   coordinates, luminance information, and gamma EOTF range
> - Tag 0x22 (Type VII Timing): Validates pixel clock max, image dimensions max,
>   and negative blanking periods
> - Tag 0x24 (Type IX Timing): Validates image dimensions max and refresh rate max
> - Tag 0x25 (Dynamic Video Timing Range Limits): Validates pixel clock and
>   refresh rate ranges with revision-specific limits
> 
> These patches improve edid-decode's ability to parse and validate DisplayID
> data according to the VESA DisplayID Standard Version 2.1a, helping identify
> corrupted or invalid EDID data early and providing better error reporting
> for debugging display issues.
> 
> Please review.

I've been going over these patches, and they look good to me. Nice to see
this implemented.

Do you have an EDID that has the ARVR data blocks? If you do, then that
might be a good one to add to the data directory with example EDIDs.

If possible, I'd like to check the output with such an EDID first before I commit
the first patch.

Regards,

	Hans

> 
> Thanks,
> Yassine

Re: [PATCH 0/2] edid-decode: ARVR parsers and DisplayID sanity checks

[HAYOU YASSINE]

[-- Attachment #1.1: Type: text/plain, Size: 2423 bytes --]

Hi Hans,

Thank you for the review.

Per your request, I have created and attached a sample EDID file that
contains the AR/VR data blocks. It includes both the AR/VR HMD (0x2c) and
AR/VR Layer (0x2d) tags, which should allow you to verify the output of the
first patch.

Feel free to add this file to the data directory for future reference.

Regards,

Yassine

Le ven. 30 janv. 2026 à 15:11, Hans Verkuil <hverkuil+cisco@kernel.org> a
écrit :

> Hi Yassine,
>
> On 23/01/2026 16:26, HAYOU YASSINE wrote:
> > Hi,
> >
> > This patch series includes two improvements to edid-decode:
> >
> > Patch 1/2: Implements full parsing for DisplayID 2.1 AR/VR data blocks
> > - Tag 0x2c (ARVR_HMD): 79-byte block with optics, lens adjustment,
> >   field of view, center of projection, and streams per layer fields
> > - Tag 0x2d (ARVR_Layer): 20-byte block with HMD identification,
> >   layer configuration, lens distortion, and scaling support
> > - Includes comprehensive sanity checks for both blocks
> >
> > Patch 2/2: Adds validation checks for DisplayID data blocks
> > - Tag 0x20 (Product ID): Validates payload length, week range, and model
> year
> > - Tag 0x21 (Display Parameters v2): Validates pixel format, chromaticity
> >   coordinates, luminance information, and gamma EOTF range
> > - Tag 0x22 (Type VII Timing): Validates pixel clock max, image
> dimensions max,
> >   and negative blanking periods
> > - Tag 0x24 (Type IX Timing): Validates image dimensions max and refresh
> rate max
> > - Tag 0x25 (Dynamic Video Timing Range Limits): Validates pixel clock and
> >   refresh rate ranges with revision-specific limits
> >
> > These patches improve edid-decode's ability to parse and validate
> DisplayID
> > data according to the VESA DisplayID Standard Version 2.1a, helping
> identify
> > corrupted or invalid EDID data early and providing better error reporting
> > for debugging display issues.
> >
> > Please review.
>
> I've been going over these patches, and they look good to me. Nice to see
> this implemented.
>
> Do you have an EDID that has the ARVR data blocks? If you do, then that
> might be a good one to add to the data directory with example EDIDs.
>
> If possible, I'd like to check the output with such an EDID first before I
> commit
> the first patch.
>
> Regards,
>
>         Hans
>
> >
> > Thanks,
> > Yassine
>
>

[-- Attachment #1.2: Type: text/html, Size: 2987 bytes --]

[-- Attachment #2: edid_displayid_arvr.bin --]
[-- Type: application/octet-stream, Size: 256 bytes --]

Re: [PATCH 0/2] edid-decode: ARVR parsers and DisplayID sanity checks

[Hans Verkuil]

Hi Yassine,

On 01/02/2026 19:46, HAYOU YASSINE wrote:
> Hi Hans,
> 
> Thank you for the review.
> 
> Per your request, I have created and attached a sample EDID file that contains the AR/VR data blocks. It includes both the AR/VR HMD (0x2c) and AR/VR Layer (0x2d) tags, which should allow you to
> verify the output of the first patch.

Just to confirm: this is not a real EDID (i.e. one used in an actual product), but
instead it is created to test these specific data blocks?

So this would go to the test directory, not the data directory.

Regards,

	Hans

> 
> Feel free to add this file to the data directory for future reference.
> 
> Regards,
> 
> Yassine
> 
> 
> Le ven. 30 janv. 2026 à 15:11, Hans Verkuil <hverkuil+cisco@kernel.org <mailto:hverkuil%2Bcisco@kernel.org>> a écrit :
> 
>     Hi Yassine,
> 
>     On 23/01/2026 16:26, HAYOU YASSINE wrote:
>     > Hi,
>     >
>     > This patch series includes two improvements to edid-decode:
>     >
>     > Patch 1/2: Implements full parsing for DisplayID 2.1 AR/VR data blocks
>     > - Tag 0x2c (ARVR_HMD): 79-byte block with optics, lens adjustment,
>     >   field of view, center of projection, and streams per layer fields
>     > - Tag 0x2d (ARVR_Layer): 20-byte block with HMD identification,
>     >   layer configuration, lens distortion, and scaling support
>     > - Includes comprehensive sanity checks for both blocks
>     >
>     > Patch 2/2: Adds validation checks for DisplayID data blocks
>     > - Tag 0x20 (Product ID): Validates payload length, week range, and model year
>     > - Tag 0x21 (Display Parameters v2): Validates pixel format, chromaticity
>     >   coordinates, luminance information, and gamma EOTF range
>     > - Tag 0x22 (Type VII Timing): Validates pixel clock max, image dimensions max,
>     >   and negative blanking periods
>     > - Tag 0x24 (Type IX Timing): Validates image dimensions max and refresh rate max
>     > - Tag 0x25 (Dynamic Video Timing Range Limits): Validates pixel clock and
>     >   refresh rate ranges with revision-specific limits
>     >
>     > These patches improve edid-decode's ability to parse and validate DisplayID
>     > data according to the VESA DisplayID Standard Version 2.1a, helping identify
>     > corrupted or invalid EDID data early and providing better error reporting
>     > for debugging display issues.
>     >
>     > Please review.
> 
>     I've been going over these patches, and they look good to me. Nice to see
>     this implemented.
> 
>     Do you have an EDID that has the ARVR data blocks? If you do, then that
>     might be a good one to add to the data directory with example EDIDs.
> 
>     If possible, I'd like to check the output with such an EDID first before I commit
>     the first patch.
> 
>     Regards,
> 
>             Hans
> 
>     >
>     > Thanks,
>     > Yassine
>