From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 701C537417B for ; Sat, 21 Mar 2026 06:54:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.218.46 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774076059; cv=pass; b=PGG8V/sHL8iDMEM6HQ3e6HyjqcOu0t8z9urLp0YTnXEu/9G1xP6e56t8Qp3zyGp676prZ1QF2EJj/AVIuUoXZNP7NcA2Bh4uUo7hKi/2R8eYaSuX6f4M5eTCEDFZKDNpqSpApSOeMYTwrytsvFQymHc4y5YpVVTRy+dS+L6nZgY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774076059; c=relaxed/simple; bh=MbIxk44fu2xuOaMBzYw8jG4/PPhvqs4IHRP9dDfBPzA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=gTZCMXIsPEqofzddSPVDzQ3mw3gzXBCKazIln0FPDvAgXFiGGRBuqoPSYkI0GAoGkDuHrLDY8aN9O35y62owGk4CrMDPOKHvmAiq+tqn6xlXJ77pXykv4DOc/uVC5ccfe4a44NIzqIc+hGvjJ49oAOgBkVdt2gKUiEHTabg4qS4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EOwZcgjF; arc=pass smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EOwZcgjF" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b9841aecf72so118592866b.2 for ; Fri, 20 Mar 2026 23:54:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774076057; cv=none; d=google.com; s=arc-20240605; b=EfJfmb77H4+pyiky8xhiv6P7MxLlwCnAk4phuq4JqMNUWJY4RojN9DfNKsAGpK3qll 3CR0Hj1UE10LcQNC6ZO4GjGy+jatRG1wh3OSGLfPGaVCKMoEKAfhoPaNnqRCV49T+Nsu 7e4nkdbkduNyfFQ3hGBtPgLjS2rrWIy/8reWBSD9le0DyU9HH+d5B4MpW97tWrNcFwIh X12wiNLLd1d4QuK6Qri+12Me6FPNjjMd46bR5QkgUE3wtHM/1xeC9pJd/XvSi7olOgVA NcBpYNUKYPJ5dj682fS95RvTKAjjDc4DNZ6xGI+l0oJRh+Yrg6iKryj7C6WwENC7hfLm +LBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Tbl+o0FBCsTBj4CkROI9ysmcgdS1EFqniJjzP33wZX4=; fh=b498syp5b5NuHg1tcMpA6qBJG5sv1B6UMN2VMYK0R80=; b=NyWBtOjpUu9jh8rj2Dx35Eo4tLFKjf5E7+bohJCqM3CJ9ZJwgTGNz8X9hhoSp/l1uh xzEV3P/zHOn1kHneFt2VF4JAfqsvJgMSm5VXGmOzr3T3MywLy4DBprBtEeWd1NlF6kQF wZLH5RFoDBwhtTCOgJCb5xeZjbsIpjAKPWyef8CgpOeO3IFVP5PUFlHb6c9KMEvSOMeH w9ugsdqnIH2dj37AMltj5oGrOrZ2KorosmecsQDX8TQGZvOsAmY3IvIOu9RPEJtjuiG5 nv8DYytNqz9b5F4P3Gz1uUi8J0kwOgbQMXeTGIdmg7aArnnmPheDvz0yl1XXiwzFxys3 uN0g==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774076057; x=1774680857; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Tbl+o0FBCsTBj4CkROI9ysmcgdS1EFqniJjzP33wZX4=; b=EOwZcgjFEDIXeV83SI4pzrh1Kl5XqLTwO+CVrdO4sK8Ftm+Bk6BGiLfHKr5YDaSPir 9n62+ZI7JDIUtCfmVjNNR35jSAMch2j6+GdKVj9AnI2zzc3m2jkhO3ndhj7IkRoh5mwu lCprau142HDxqSrxiZqPvKjBzU0UmuqrRVWQQK2OwGZfbanrQFr8ZmefFqQAfuX819c9 r3yIwjdZvjD4tOZVMr5yHOJvuHUsoit1QtcBzOervfLPiK8/DrI7zVMyicf2NXO7LW4A aeCqxC4ZObfSdFcLfutyHTPIscTuUfCAXSRRVBGONjkINixYq2uD3egO1p5UzqLcqk0B VzSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774076057; x=1774680857; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Tbl+o0FBCsTBj4CkROI9ysmcgdS1EFqniJjzP33wZX4=; b=TeVsGiQQAL9PPuGVUjFlIgTJhrovqLfRBFVc0EG+/ZP/dZozex3qOPqoXyuenaY+aU NhitvTeEzh3YSoKgOpsCWOfcpqXYicTfkBNT6uQ3BasWzaW625NVpVZYO7iuABwkJos3 8qGwXdrE3+rd2aywAGWcqxSAvuq6ZkAGEc4DtNusM/pP+KKCXthiweOfPXpWzmvT6YtS e707jYbZDLHGX9GgcUQOCkLFjk/M6SyAhk2yK9jdXdRM1M0UmBsxlsYG5/8kZOe9RQMx 8QzXC522WT/znl9LckCObsmV+49RCiEmujx09TEhudmSZlUPimifJbZyjvvcwcXbBOef ZZhg== X-Forwarded-Encrypted: i=1; AJvYcCW/rAQJndOtp3kFp7aSpFLgvbUE1qcdd1QMwSfN5sNnEkmF72o2UvYn5cAhWM9IPXotslm7mwfdOiSRqQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yydqxl4iTJGdu6Ug5MHtb20jcVRAI9libvz2qGm4vDpbikW88nQ VX2wGUhD+Edp2CCfJhQjUdO5yvyuPAbRaql+3AoIf/zn07FUfWiZoDEAWK+7D/0C9K6A30jgcr0 dLBQqUXX7PKAtFB0y+8B4Uy8d/OAfedk= X-Gm-Gg: ATEYQzy4HiG9JFhwQsT/rdeQ54avftX6kgLraCjUyxYOWH7gLPejjdfuVXHxjm4ULsz 8t6pGeUJMSGlWjhdOaEjWRUExkhOp4bxaP0gMENQY6QUlot8peNHaP6AAFChBTpK6ozklokS7ZC eX3J6+pe+PQDqVuQrW+gqN6WFQ/N/ea1Z1njMGXFGFv9dx/u9M0PDbcpvH+/uecfSjItXZHlqjV Apvc8UT7gogjkvhKX//3SN1e5V5+0UQPMxN8Sht8OlCTgzG+OdcuBkeehlSfpaJbCHY8fgKyaTJ rjIC4oIx3hR8a7wu X-Received: by 2002:a17:907:d109:b0:b96:f6f1:e7af with SMTP id a640c23a62f3a-b982f1ed7bdmr419710366b.9.1774076056402; Fri, 20 Mar 2026 23:54:16 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260304100557.126488-1-linux.amoon@gmail.com> <9db109a657e18d1e5ead67d7db06cfaf68f7fa84.camel@ndufresne.ca> In-Reply-To: <9db109a657e18d1e5ead67d7db06cfaf68f7fa84.camel@ndufresne.ca> From: Anand Moon Date: Sat, 21 Mar 2026 12:24:01 +0530 X-Gm-Features: AaiRm522SeNM1abZw4YAK4uXkmRkLpmLZXI60fMElcfZGsZpbYfOo6oOjvIO9yA Message-ID: Subject: Re: [PATCH v1] media: meson: vdec: Fix memory leak in error path of vdec_open To: Nicolas Dufresne Cc: Neil Armstrong , Mauro Carvalho Chehab , Greg Kroah-Hartman , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Maxime Jourdan , Hans Verkuil , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "open list:STAGING SUBSYSTEM" , "moderated list:ARM/Amlogic Meson SoC support" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Nicolas, Thanks for your review comments. On Fri, 20 Mar 2026 at 02:05, Nicolas Dufresne wrote= : > > Hi, > > Le mercredi 04 mars 2026 =C3=A0 15:35 +0530, Anand Moon a =C3=A9crit : > > If vdec_init_ctrls(sess) fails, or any subsequent initialization step > > during vdec_open fails, the control handler allocated for the session > > is not released. This causes a memory leak of the v4l2_ctrl_handler > > and its associated control objects. > > > > Add a call to v4l2_ctrl_handler_free() in the err_m2m_release error > > path to ensure resources are properly reclaimed. > > > > unreferenced object 0xffff0000205d6878 (size 8): > > comm "v4l_id", pid 5289, jiffies 4294938580 > > hex dump (first 8 bytes): > > 40 d2 49 18 00 00 ff ff @.I..... > > backtrace (crc d3204599): > > kmemleak_alloc+0xc8/0xf0 > > __kvmalloc_node_noprof+0x60c/0x850 > > v4l2_ctrl_handler_init_class+0x1b4/0x2e8 [videodev] > > vdec_open+0x1f4/0x788 [meson_vdec] > > v4l2_open+0x144/0x460 [videodev] > > chrdev_open+0x1ac/0x500 > > do_dentry_open+0x3f0/0xfe8 > > vfs_open+0x68/0x320 > > do_open+0x2d8/0x9a8 > > path_openat+0x1d0/0x4f0 > > do_filp_open+0x190/0x380 > > do_sys_openat2+0xf8/0x1b0 > > __arm64_sys_openat+0x13c/0x1e8 > > invoke_syscall+0xdc/0x268 > > el0_svc_common.constprop.0+0x178/0x258 > > do_el0_svc+0x4c/0x70 > > > > Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver") > > Signed-off-by: Anand Moon > > --- > > drivers/staging/media/meson/vdec/vdec.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/= media/meson/vdec/vdec.c > > index 4b77ec1af5a7..a5ab0c2390f5 100644 > > --- a/drivers/staging/media/meson/vdec/vdec.c > > +++ b/drivers/staging/media/meson/vdec/vdec.c > > @@ -914,6 +914,7 @@ static int vdec_open(struct file *file) > > return 0; > > > > err_m2m_release: > > This goto is used twice. The second time is when vdec_init_ctrls() fails,= and in > that case the v4l2_m2m_ctx is leaded. Can you add the missing label and c= all > v4l2_m2m_ctx_release() accordingly. This way we don't have to revisit aga= in. > Ok, understood, I will update this in the next version. Thanks -Anand