Re: [PATCH] media: imx: imx7-media-csi: Fix buffer return upon stream start failure

["Rui Miguel Silva" <rmfrfs@gmail.com>]

Hi Martin,
On Wed Jul 28, 2021 at 9:50 AM WEST, Martin Kepplinger wrote:

> Am Mittwoch, dem 19.05.2021 um 03:58 +0300 schrieb Laurent Pinchart:
> > When the stream fails to start, the first two buffers in the queue
> > have
> > been moved to the active_vb2_buf array and are returned to vb2 by
> > imx7_csi_dma_unsetup_vb2_buf(). The function is called with the
> > buffer
> > state set to VB2_BUF_STATE_ERROR unconditionally, which is correct
> > when
> > stopping the stream, but not when the start operation fails. In that
> > case, the state should be set to VB2_BUF_STATE_QUEUED. Fix it.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >  drivers/staging/media/imx/imx7-media-csi.c | 15 +++++++++------

<snip>

> > +               imx7_csi_deinit(csi, VB2_BUF_STATE_ERROR);
> >         }
> >  
> >         csi->is_streaming = !!enable;
>
>
> This patch has not yet been accepted. Any specific reason? I need it.

Good question, I gave my reviewed in May [0], maybe got lost in the
merge process somewhere. Mauro?

[0]: https://lore.kernel.org/linux-media/CBHA8BLTAJM1.1DIYC729ZMAYY@arch-thunder/

------
Cheers,
     Rui

>
> Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>
>
> thank you very much