Re: [RFC 1/3] media: tw9910: Allow to probe from device tree

["Rui Miguel Silva" <rui.silva@linaro.org>]

Oi Fabio,
On Thu Sep 16, 2021 at 9:52 PM WEST, Fabio Estevam wrote:

> Hi Rui,
>
> On Mon, Sep 13, 2021 at 7:12 PM Rui Miguel Silva <rui.silva@linaro.org> wrote:
>
> > Looking  at this code it looks like you are using an old tree, Laurent
> > meanwhile have sent a patch that change this function:
> >
> > a9512b261afd ("media: imx: capture: Simplify capture_validate_fmt() implementation")
> >
> > can you test with the latest code as see if you have the same
> > problems.
>
> I have just tested on 5.15-rc1 and this is what I get:
>
> # v4l2-ctl --device /dev/v4l-subdev1 --set-standard PAL
> Standard set to 000000ff
> # media-ctl -l "'tw9910 2-0044':0 -> 'csi':0[1]"
> # media-ctl -l "'csi':1 -> 'csi capture':0[1]"
> # media-ctl -v -V "'tw9910 2-0044':0 [fmt:UYVY8_2X8/720x576
> field:interlaced-bt]"
> Opening media device /dev/media0
> Enumerating entities
> Found 3 entities
> Enumerating pads and links
> Setting up format UYVY8_2X8 720x576 on pad tw9910 2-0044/0
> Format set: UYVY8_2X8 720x576
> Setting up format UYVY8_2X8 720x576 on pad csi/0
> Format set: UYVY8_2X8 720x576
>
> # v4l2-ctl --stream-mmap -d /dev/video1
> [   26.860654] priv->vdev.compose.width is 640

This looks like the default pix width (IMX_MEDIA_DEF_PIX_WIDTH)

> [   26.865419] fmt_src.format.width is 720
> [   26.869390] priv->vdev.compose.height is 480

and this the default pix height (IMX_MEDIA_DEF_PIX_HEIGHT)

> [   26.874268] compose.height is 576
> [   26.877716] imx7-csi 2214000.csi: capture format not valid
> VIDIOC_STREAMON returned -1 (Broken pipe)
> Do you know why I am getting such a width/height mismatch?

So, it seems like it is not configuring the pads, don't you need to do
a media-ctl -V in the csi:0?

or maybe dump the output of media-ctl -p and check the links and pads
configurations.

Hope this helps.

Cheers,
   Rui