Linux Media Controller development
 help / color / mirror / Atom feed
From: "Rui Miguel Silva" <rmfrfs@gmail.com>
To: "Jacopo Mondi" <jacopo@jmondi.org>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Steve Longerbeam" <slongerbeam@gmail.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	<linux-media@vger.kernel.org>
Subject: Re: [PATCH 0/2] staging: media: imx7-mipi-csis: Two small fixes
Date: Wed, 19 Jan 2022 16:21:15 +0000	[thread overview]
Message-ID: <CH9SE3SLDYEU.2M560Q0RQ0L3C@arch-thunder> (raw)
In-Reply-To: <20220119112024.11339-1-jacopo@jmondi.org>

Hey Jacopo,
both patches LGTM.

I only have one nit with them...

On Wed Jan 19, 2022 at 11:20 AM WET, Jacopo Mondi wrote:

> Two small fixes for the imx7-mipi-csis driver.
>
> The second patch is required to correctly capture in packed YUV422 formats
>
> Thanks
>    j
>
> Jacopo Mondi (2):
>   staging: media: imx: imx7-mipi-csic: Resume on debug
>   staging: media: imx: imx7-mipi-csic: Set PIXEL_MODE for YUV422
                                      ^
                   here should be s (imx7-mipi-csis) on both patches

Maybe Laurent could fix the typo on the pull, other than that:

Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>

Cheers,
   Rui

>
>  drivers/staging/media/imx/imx7-mipi-csis.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> --
> 2.34.1




  parent reply	other threads:[~2022-01-19 16:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 11:20 [PATCH 0/2] staging: media: imx7-mipi-csis: Two small fixes Jacopo Mondi
2022-01-19 11:20 ` [PATCH 1/2] staging: media: imx: imx7-mipi-csic: Resume on debug Jacopo Mondi
2022-01-19 14:24   ` Laurent Pinchart
2022-01-25  3:18     ` Laurent Pinchart
2022-01-25 10:22       ` Jacopo Mondi
2022-01-26  0:28         ` Laurent Pinchart
2022-01-19 11:20 ` [PATCH 2/2] staging: media: imx: imx7-mipi-csic: Set PIXEL_MODE for YUV422 Jacopo Mondi
2022-01-19 14:26   ` Laurent Pinchart
2022-01-19 16:21 ` Rui Miguel Silva [this message]
2022-01-21  8:29   ` [PATCH 0/2] staging: media: imx7-mipi-csis: Two small fixes Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH9SE3SLDYEU.2M560Q0RQ0L3C@arch-thunder \
    --to=rmfrfs@gmail.com \
    --cc=jacopo@jmondi.org \
    --cc=jbrunet@baylibre.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox