From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Akhil R" <akhilrajeev@nvidia.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Mikko Perttunen" <mperttunen@nvidia.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Sowjanya Komatineni" <skomatineni@nvidia.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: <linux-crypto@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>
Subject: Re: [PATCH 1/2] host1x: Make remove callback return void
Date: Wed, 31 Dec 2025 10:14:45 +0100 [thread overview]
Message-ID: <DFCAD4LVB5RF.3PI81T1E0OIID@bootlin.com> (raw)
In-Reply-To: <d364fd4ec043d36ee12e46eaef98c57658884f63.1765355236.git.u.kleine-koenig@baylibre.com>
Hello Uwe,
On Wed Dec 10, 2025 at 9:31 AM CET, Uwe Kleine-König wrote:
> The return value of struct device_driver::remove is ignored by the core
> (see device_remove() in drivers/base/dd.c). So it doesn't make sense to
> let the host1x remove callback return an int just to ignore it later.
>
> So make the callback return void. All current implementors return 0, so
> they are easily converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # tegra20 tegra-video
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-12-31 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 8:31 [PATCH 0/2] host1x: Convert to bus methods Uwe Kleine-König
2025-12-10 8:31 ` [PATCH 1/2] host1x: Make remove callback return void Uwe Kleine-König
2025-12-31 9:14 ` Luca Ceresoli [this message]
2025-12-10 8:31 ` [PATCH 2/2] host1x: Convert to bus methods Uwe Kleine-König
2025-12-31 9:14 ` Luca Ceresoli
2026-01-12 11:53 ` [PATCH 0/2] " Uwe Kleine-König
2026-01-13 12:33 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFCAD4LVB5RF.3PI81T1E0OIID@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=airlied@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jonathanh@nvidia.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mperttunen@nvidia.com \
--cc=simona@ffwll.ch \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox