From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Oskar Ray-Frayssinet" <rayfraytech@gmail.com>,
<hansg@kernel.org>, <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-media@vger.kernel.org>
Subject: Re: [PATCH] staging: atomisp: remove unnecessary else after return in atomisp_cmd.c
Date: Sun, 01 Mar 2026 15:46:22 -0600 [thread overview]
Message-ID: <DGRRXA8LOOOQ.2W7O8M9WU6GIM@gmail.com> (raw)
In-Reply-To: <20260301212047.3649-1-rayfraytech@gmail.com>
On Sun Mar 1, 2026 at 3:20 PM CST, Oskar Ray-Frayssinet wrote:
> Remove unnecessary else clause after return statement as the else
> branch is not needed when the if branch alsways returns.
Typo alsways.
>
> Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> ---
...
> if (from_user)
> return copy_from_user(to, (void __user *)from, n);
> - else
> - memcpy(to, from, n);
Put blank line here.
> + memcpy(to, from, n);
> return 0;
> }
>
Also from what I can tell your sending a few patches affecting the
same driver, typically you'd make it a patch series with a cover letter.
Thanks,
ET
prev parent reply other threads:[~2026-03-01 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 21:20 [PATCH] staging: atomisp: remove unnecessary else after return in atomisp_cmd.c Oskar Ray-Frayssinet
2026-03-01 21:46 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGRRXA8LOOOQ.2W7O8M9WU6GIM@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rayfraytech@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox