From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Ethan Tidmore" <ethantidmore06@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Hans Verkuil" <hverkuil+cisco@kernel.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Tomi Valkeinen" <tomi.valkeinen+renesas@ideasonboard.com>,
"Kees Cook" <kees@kernel.org>
Subject: Re: [PATCH] media: subdev: Fix error pointer dereference
Date: Fri, 13 Mar 2026 22:06:43 -0500 [thread overview]
Message-ID: <DH2693U3WV7A.3HE6S9RPAFP4E@gmail.com> (raw)
In-Reply-To: <20260314030228.1133429-1-ethantidmore06@gmail.com>
On Fri Mar 13, 2026 at 10:02 PM CDT, Ethan Tidmore wrote:
> The function media_pad_remote_pad_unique() returns an error pointer upon
> failure, not null.
>
> Add check for error pointer and extract the error code with PTR_ERR().
Detected by Smatch:
drivers/media/v4l2-core/v4l2-subdev.c:2588 v4l2_subdev_get_frame_desc_passthrough() warn:
'remote_source_pad' is an error pointer or valid
drivers/media/v4l2-core/v4l2-subdev.c:2595 v4l2_subdev_get_frame_desc_passthrough() error:
'remote_source_pad' dereferencing possible ERR_PTR()
>
> Fixes: a564839e630c1 ("media: subdev: Add v4l2_subdev_get_frame_desc_passthrough helper")
> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
> ---
Forgot to add the Smatch warnings, if this version is good please add
this to the commit message.
Thanks,
ET
next prev parent reply other threads:[~2026-03-14 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 3:02 [PATCH] media: subdev: Fix error pointer dereference Ethan Tidmore
2026-03-14 3:06 ` Ethan Tidmore [this message]
2026-03-16 7:33 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH2693U3WV7A.3HE6S9RPAFP4E@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=hverkuil+cisco@kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kees@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen+renesas@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox