* [PATCH v3] staging: media: av7110: replace C++ comments with C style comments in sp8870.c
[not found] <20260314-sp8870-cleanup-v3-1-3ec367f13aa9.ref@yahoo.pl>
@ 2026-03-14 7:47 ` Tomasz Unger
2026-03-15 1:43 ` Ethan Tidmore
2026-03-16 15:24 ` Hans Verkuil
0 siblings, 2 replies; 3+ messages in thread
From: Tomasz Unger @ 2026-03-14 7:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-media, linux-staging, linux-kernel, Tomasz Unger
Replace C++ style comments (//) with C style comments (/* */) in
sp8870.c to conform to the kernel coding style.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Changes in v3:
- Convert two consecutive single-line comments to a multi-line comment as suggested by Ethan Tidmore
- Link to v2: https://lore.kernel.org/r/20260313-sp8870-cleanup-v2-1-ca679e62f9b7@yahoo.pl
Changes in v2:
- Add changelog text to commit message as requested by Greg Kroah-Hartman
- Link to v1: https://lore.kernel.org/r/20260313-sp8870-cleanup-v1-1-2d5069c4eec5@yahoo.pl
---
drivers/staging/media/av7110/sp8870.c | 54 ++++++++++++++++++-----------------
1 file changed, 28 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c
index 29fb4934c039..73500f8702d3 100644
--- a/drivers/staging/media/av7110/sp8870.c
+++ b/drivers/staging/media/av7110/sp8870.c
@@ -109,21 +109,21 @@ static int sp8870_firmware_upload(struct sp8870_state *state, const struct firmw
if (fw->size < SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET)
return -EINVAL;
- // system controller stop
+ /* system controller stop */
sp8870_writereg(state, 0x0F00, 0x0000);
- // instruction RAM register hiword
+ /* instruction RAM register hiword */
sp8870_writereg(state, 0x8F08, ((SP8870_FIRMWARE_SIZE / 2) & 0xFFFF));
- // instruction RAM MWR
+ /* instruction RAM MWR */
sp8870_writereg(state, 0x8F0A, ((SP8870_FIRMWARE_SIZE / 2) >> 16));
- // do firmware upload
+ /* do firmware upload */
fw_pos = SP8870_FIRMWARE_OFFSET;
while (fw_pos < SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET) {
tx_len = (fw_pos <= SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET - 252) ? 252 :
SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET - fw_pos;
- // write register 0xCF0A
+ /* write register 0xCF0A */
tx_buf[0] = 0xCF;
tx_buf[1] = 0x0A;
memcpy(&tx_buf[2], fw_buf + fw_pos, tx_len);
@@ -149,7 +149,7 @@ static void sp8870_microcontroller_stop(struct sp8870_state *state)
sp8870_writereg(state, 0x0F08, 0x000);
sp8870_writereg(state, 0x0F09, 0x000);
- // microcontroller STOP
+ /* microcontroller STOP */
sp8870_writereg(state, 0x0F00, 0x000);
}
@@ -158,10 +158,12 @@ static void sp8870_microcontroller_start(struct sp8870_state *state)
sp8870_writereg(state, 0x0F08, 0x000);
sp8870_writereg(state, 0x0F09, 0x000);
- // microcontroller START
+ /* microcontroller START */
sp8870_writereg(state, 0x0F00, 0x001);
- // not documented but if we don't read 0x0D01 out here
- // we don't get a correct data valid signal
+ /*
+ * not documented but if we don't read 0x0D01 out here
+ * we don't get a correct data valid signal
+ */
sp8870_readreg(state, 0x0D01);
}
@@ -243,7 +245,7 @@ static int configure_reg0xc05(struct dtv_frontend_properties *p, u16 *reg0xc05)
static int sp8870_wake_up(struct sp8870_state *state)
{
- // enable TS output and interface pins
+ /* enable TS output and interface pins */
return sp8870_writereg(state, 0xC18, 0x00D);
}
@@ -258,29 +260,29 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
if (err)
return err;
- // system controller stop
+ /* system controller stop */
sp8870_microcontroller_stop(state);
- // set tuner parameters
+ /* set tuner parameters */
if (fe->ops.tuner_ops.set_params) {
fe->ops.tuner_ops.set_params(fe);
if (fe->ops.i2c_gate_ctrl)
fe->ops.i2c_gate_ctrl(fe, 0);
}
- // sample rate correction bit [23..17]
+ /* sample rate correction bit [23..17] */
sp8870_writereg(state, 0x0319, 0x000A);
- // sample rate correction bit [16..0]
+ /* sample rate correction bit [16..0] */
sp8870_writereg(state, 0x031A, 0x0AAB);
- // integer carrier offset
+ /* integer carrier offset */
sp8870_writereg(state, 0x0309, 0x0400);
- // fractional carrier offset
+ /* fractional carrier offset */
sp8870_writereg(state, 0x030A, 0x0000);
- // filter for 6/7/8 Mhz channel
+ /* filter for 6/7/8 Mhz channel */
if (p->bandwidth_hz == 6000000)
sp8870_writereg(state, 0x0311, 0x0002);
else if (p->bandwidth_hz == 7000000)
@@ -288,7 +290,7 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
else
sp8870_writereg(state, 0x0311, 0x0000);
- // scan order: 2k first = 0x0000, 8k first = 0x0001
+ /* scan order: 2k first = 0x0000, 8k first = 0x0001 */
if (p->transmission_mode == TRANSMISSION_MODE_2K)
sp8870_writereg(state, 0x0338, 0x0000);
else
@@ -296,12 +298,12 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
sp8870_writereg(state, 0xc05, reg0xc05);
- // read status reg in order to clear pending irqs
+ /* read status reg in order to clear pending irqs */
err = sp8870_readreg(state, 0x200);
if (err < 0)
return err;
- // system controller start
+ /* system controller start */
sp8870_microcontroller_start(state);
return 0;
@@ -337,16 +339,16 @@ static int sp8870_init(struct dvb_frontend *fe)
/* enable TS output and interface pins */
sp8870_writereg(state, 0xc18, 0x00d);
- // system controller stop
+ /* system controller stop */
sp8870_microcontroller_stop(state);
- // ADC mode
+ /* ADC mode */
sp8870_writereg(state, 0x0301, 0x0003);
- // Reed Solomon parity bytes passed to output
+ /* Reed Solomon parity bytes passed to output */
sp8870_writereg(state, 0x0C13, 0x0001);
- // MPEG clock is suppressed if no valid data
+ /* MPEG clock is suppressed if no valid data */
sp8870_writereg(state, 0x0C14, 0x0001);
/* bit 0x010: enable data valid signal */
@@ -490,7 +492,7 @@ static int sp8870_set_frontend(struct dvb_frontend *fe)
return err;
for (check_count = 0; check_count < MAXCHECKS; check_count++) {
-// valid = ((sp8870_readreg(i2c, 0x0200) & 4) == 0);
+ /* valid = ((sp8870_readreg(i2c, 0x0200) & 4) == 0); */
valid = sp8870_read_data_valid_signal(state);
if (valid) {
dprintk("delay = %i usec\n", check_count * 10);
@@ -526,7 +528,7 @@ static int sp8870_sleep(struct dvb_frontend *fe)
{
struct sp8870_state *state = fe->demodulator_priv;
- // tristate TS output and disable interface pins
+ /* tristate TS output and disable interface pins */
return sp8870_writereg(state, 0xC18, 0x000);
}
---
base-commit: 0257f64bdac7fdca30fa3cae0df8b9ecbec7733a
change-id: 20260313-sp8870-cleanup-c6552094e4c9
Best regards,
--
Tomasz Unger <tomasz.unger@yahoo.pl>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] staging: media: av7110: replace C++ comments with C style comments in sp8870.c
2026-03-14 7:47 ` [PATCH v3] staging: media: av7110: replace C++ comments with C style comments in sp8870.c Tomasz Unger
@ 2026-03-15 1:43 ` Ethan Tidmore
2026-03-16 15:24 ` Hans Verkuil
1 sibling, 0 replies; 3+ messages in thread
From: Ethan Tidmore @ 2026-03-15 1:43 UTC (permalink / raw)
To: Tomasz Unger, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-media, linux-staging, linux-kernel
On Sat Mar 14, 2026 at 2:47 AM CDT, Tomasz Unger wrote:
> Replace C++ style comments (//) with C style comments (/* */) in
> sp8870.c to conform to the kernel coding style.
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] staging: media: av7110: replace C++ comments with C style comments in sp8870.c
2026-03-14 7:47 ` [PATCH v3] staging: media: av7110: replace C++ comments with C style comments in sp8870.c Tomasz Unger
2026-03-15 1:43 ` Ethan Tidmore
@ 2026-03-16 15:24 ` Hans Verkuil
1 sibling, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2026-03-16 15:24 UTC (permalink / raw)
To: Tomasz Unger, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-media, linux-staging, linux-kernel
Hi Tomasz,
Since C99 comments are allowed these days I'm not going to apply this patch.
It's not worth the effort.
Sorry,
Hans
On 14/03/2026 08:47, Tomasz Unger wrote:
> Replace C++ style comments (//) with C style comments (/* */) in
> sp8870.c to conform to the kernel coding style.
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Changes in v3:
> - Convert two consecutive single-line comments to a multi-line comment as suggested by Ethan Tidmore
> - Link to v2: https://lore.kernel.org/r/20260313-sp8870-cleanup-v2-1-ca679e62f9b7@yahoo.pl
>
> Changes in v2:
> - Add changelog text to commit message as requested by Greg Kroah-Hartman
> - Link to v1: https://lore.kernel.org/r/20260313-sp8870-cleanup-v1-1-2d5069c4eec5@yahoo.pl
> ---
> drivers/staging/media/av7110/sp8870.c | 54 ++++++++++++++++++-----------------
> 1 file changed, 28 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c
> index 29fb4934c039..73500f8702d3 100644
> --- a/drivers/staging/media/av7110/sp8870.c
> +++ b/drivers/staging/media/av7110/sp8870.c
> @@ -109,21 +109,21 @@ static int sp8870_firmware_upload(struct sp8870_state *state, const struct firmw
> if (fw->size < SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET)
> return -EINVAL;
>
> - // system controller stop
> + /* system controller stop */
> sp8870_writereg(state, 0x0F00, 0x0000);
>
> - // instruction RAM register hiword
> + /* instruction RAM register hiword */
> sp8870_writereg(state, 0x8F08, ((SP8870_FIRMWARE_SIZE / 2) & 0xFFFF));
>
> - // instruction RAM MWR
> + /* instruction RAM MWR */
> sp8870_writereg(state, 0x8F0A, ((SP8870_FIRMWARE_SIZE / 2) >> 16));
>
> - // do firmware upload
> + /* do firmware upload */
> fw_pos = SP8870_FIRMWARE_OFFSET;
> while (fw_pos < SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET) {
> tx_len = (fw_pos <= SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET - 252) ? 252 :
> SP8870_FIRMWARE_SIZE + SP8870_FIRMWARE_OFFSET - fw_pos;
> - // write register 0xCF0A
> + /* write register 0xCF0A */
> tx_buf[0] = 0xCF;
> tx_buf[1] = 0x0A;
> memcpy(&tx_buf[2], fw_buf + fw_pos, tx_len);
> @@ -149,7 +149,7 @@ static void sp8870_microcontroller_stop(struct sp8870_state *state)
> sp8870_writereg(state, 0x0F08, 0x000);
> sp8870_writereg(state, 0x0F09, 0x000);
>
> - // microcontroller STOP
> + /* microcontroller STOP */
> sp8870_writereg(state, 0x0F00, 0x000);
> }
>
> @@ -158,10 +158,12 @@ static void sp8870_microcontroller_start(struct sp8870_state *state)
> sp8870_writereg(state, 0x0F08, 0x000);
> sp8870_writereg(state, 0x0F09, 0x000);
>
> - // microcontroller START
> + /* microcontroller START */
> sp8870_writereg(state, 0x0F00, 0x001);
> - // not documented but if we don't read 0x0D01 out here
> - // we don't get a correct data valid signal
> + /*
> + * not documented but if we don't read 0x0D01 out here
> + * we don't get a correct data valid signal
> + */
> sp8870_readreg(state, 0x0D01);
> }
>
> @@ -243,7 +245,7 @@ static int configure_reg0xc05(struct dtv_frontend_properties *p, u16 *reg0xc05)
>
> static int sp8870_wake_up(struct sp8870_state *state)
> {
> - // enable TS output and interface pins
> + /* enable TS output and interface pins */
> return sp8870_writereg(state, 0xC18, 0x00D);
> }
>
> @@ -258,29 +260,29 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
> if (err)
> return err;
>
> - // system controller stop
> + /* system controller stop */
> sp8870_microcontroller_stop(state);
>
> - // set tuner parameters
> + /* set tuner parameters */
> if (fe->ops.tuner_ops.set_params) {
> fe->ops.tuner_ops.set_params(fe);
> if (fe->ops.i2c_gate_ctrl)
> fe->ops.i2c_gate_ctrl(fe, 0);
> }
>
> - // sample rate correction bit [23..17]
> + /* sample rate correction bit [23..17] */
> sp8870_writereg(state, 0x0319, 0x000A);
>
> - // sample rate correction bit [16..0]
> + /* sample rate correction bit [16..0] */
> sp8870_writereg(state, 0x031A, 0x0AAB);
>
> - // integer carrier offset
> + /* integer carrier offset */
> sp8870_writereg(state, 0x0309, 0x0400);
>
> - // fractional carrier offset
> + /* fractional carrier offset */
> sp8870_writereg(state, 0x030A, 0x0000);
>
> - // filter for 6/7/8 Mhz channel
> + /* filter for 6/7/8 Mhz channel */
> if (p->bandwidth_hz == 6000000)
> sp8870_writereg(state, 0x0311, 0x0002);
> else if (p->bandwidth_hz == 7000000)
> @@ -288,7 +290,7 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
> else
> sp8870_writereg(state, 0x0311, 0x0000);
>
> - // scan order: 2k first = 0x0000, 8k first = 0x0001
> + /* scan order: 2k first = 0x0000, 8k first = 0x0001 */
> if (p->transmission_mode == TRANSMISSION_MODE_2K)
> sp8870_writereg(state, 0x0338, 0x0000);
> else
> @@ -296,12 +298,12 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
>
> sp8870_writereg(state, 0xc05, reg0xc05);
>
> - // read status reg in order to clear pending irqs
> + /* read status reg in order to clear pending irqs */
> err = sp8870_readreg(state, 0x200);
> if (err < 0)
> return err;
>
> - // system controller start
> + /* system controller start */
> sp8870_microcontroller_start(state);
>
> return 0;
> @@ -337,16 +339,16 @@ static int sp8870_init(struct dvb_frontend *fe)
> /* enable TS output and interface pins */
> sp8870_writereg(state, 0xc18, 0x00d);
>
> - // system controller stop
> + /* system controller stop */
> sp8870_microcontroller_stop(state);
>
> - // ADC mode
> + /* ADC mode */
> sp8870_writereg(state, 0x0301, 0x0003);
>
> - // Reed Solomon parity bytes passed to output
> + /* Reed Solomon parity bytes passed to output */
> sp8870_writereg(state, 0x0C13, 0x0001);
>
> - // MPEG clock is suppressed if no valid data
> + /* MPEG clock is suppressed if no valid data */
> sp8870_writereg(state, 0x0C14, 0x0001);
>
> /* bit 0x010: enable data valid signal */
> @@ -490,7 +492,7 @@ static int sp8870_set_frontend(struct dvb_frontend *fe)
> return err;
>
> for (check_count = 0; check_count < MAXCHECKS; check_count++) {
> -// valid = ((sp8870_readreg(i2c, 0x0200) & 4) == 0);
> + /* valid = ((sp8870_readreg(i2c, 0x0200) & 4) == 0); */
> valid = sp8870_read_data_valid_signal(state);
> if (valid) {
> dprintk("delay = %i usec\n", check_count * 10);
> @@ -526,7 +528,7 @@ static int sp8870_sleep(struct dvb_frontend *fe)
> {
> struct sp8870_state *state = fe->demodulator_priv;
>
> - // tristate TS output and disable interface pins
> + /* tristate TS output and disable interface pins */
> return sp8870_writereg(state, 0xC18, 0x000);
> }
>
>
> ---
> base-commit: 0257f64bdac7fdca30fa3cae0df8b9ecbec7733a
> change-id: 20260313-sp8870-cleanup-c6552094e4c9
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-16 15:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260314-sp8870-cleanup-v3-1-3ec367f13aa9.ref@yahoo.pl>
2026-03-14 7:47 ` [PATCH v3] staging: media: av7110: replace C++ comments with C style comments in sp8870.c Tomasz Unger
2026-03-15 1:43 ` Ethan Tidmore
2026-03-16 15:24 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox