[PATCH v2] staging: media: atomisp: Fix indentation and styling in output kernel code

[PATCH v2] staging: media: atomisp: Fix indentation and styling in output kernel code

[Darshan R.]

From: Darshan R <rathod.darshan.0896@gmail.com>

Update formatting of function definitions and if statements to match kernel
coding standards. This improves readability and ensures consistency across
the codebase.

These are non-functional changes intended to address common checkpatch
warnings and prepare the driver for eventual mainline inclusion.

Signed-off-by: Darshan R. <rathod.darshan.0896@gmail.com>
---
 .../output/output_1.0/ia_css_output.host.c    | 22 ++++++++++---------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
index d09365e0c471..4f84c6d3622a 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
@@ -34,9 +34,9 @@ static const struct ia_css_output1_configuration default_output1_configuration
 
 void
 ia_css_output_encode(
-    struct sh_css_isp_output_params *to,
-    const struct ia_css_output_config *from,
-    unsigned int size)
+	struct sh_css_isp_output_params *to,
+	const struct ia_css_output_config *from,
+	unsigned int size)
 {
 	(void)size;
 	to->enable_hflip = from->enable_hflip;
@@ -74,7 +74,7 @@ int ia_css_output0_config(struct sh_css_isp_output_isp_config       *to,
 }
 
 int ia_css_output1_config(struct sh_css_isp_output_isp_config       *to,
-		          const struct ia_css_output1_configuration *from,
+			  const struct ia_css_output1_configuration *from,
 			  unsigned int size)
 {
 	return ia_css_output_config(to, (const struct ia_css_output_configuration *)from, size);
@@ -95,7 +95,7 @@ int ia_css_output_configure(const struct ia_css_binary     *binary,
 }
 
 int ia_css_output0_configure(const struct ia_css_binary    *binary,
-			    const struct ia_css_frame_info *info)
+			     const struct ia_css_frame_info *info)
 {
 	if (info) {
 		struct ia_css_output0_configuration config =
@@ -124,10 +124,12 @@ int ia_css_output1_configure(const struct ia_css_binary     *binary,
 
 void
 ia_css_output_dump(
-    const struct sh_css_isp_output_params *output,
-    unsigned int level)
+	const struct sh_css_isp_output_params *output,
+	unsigned int level)
 {
-	if (!output) return;
+	if (!output)
+		return;
+
 	ia_css_debug_dtrace(level, "Horizontal Output Flip:\n");
 	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
 			    "enable", output->enable_hflip);
@@ -138,8 +140,8 @@ ia_css_output_dump(
 
 void
 ia_css_output_debug_dtrace(
-    const struct ia_css_output_config *config,
-    unsigned int level)
+	const struct ia_css_output_config *config,
+	unsigned int level)
 {
 	ia_css_debug_dtrace(level,
 			    "config.enable_hflip=%d",
-- 
2.43.0

Re: [PATCH v2] staging: media: atomisp: Fix indentation and styling in output kernel code

[Tarang Raval]

> Update formatting of function definitions and if statements to match kernel
> coding standards. This improves readability and ensures consistency across
> the codebase.
> 
> These are non-functional changes intended to address common checkpatch
> warnings and prepare the driver for eventual mainline inclusion.
> 
> Signed-off-by: Darshan R. <rathod.darshan.0896@gmail.com>
> ---

Whenever you send a new version of the patch, you should include a changelog
below the --- line. This helps reviewers easily see what has changed from v1
to v2.

I think the following document will be useful for you.
Link: https://www.kernel.org/doc/Documentation/process/submitting-patches.rst
  
>  .../output/output_1.0/ia_css_output.host.c    | 22 ++++++++++---------
>  1 file changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
> index d09365e0c471..4f84c6d3622a 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
> @@ -34,9 +34,9 @@ static const struct ia_css_output1_configuration default_output1_configuration
> 
>  void
>  ia_css_output_encode(
> -    struct sh_css_isp_output_params *to,
> -    const struct ia_css_output_config *from,
> -    unsigned int size)
> +       struct sh_css_isp_output_params *to,
> +       const struct ia_css_output_config *from,
> +       unsigned int size)

It would be better formatted like this:

void ia_css_output_encode(struct sh_css_isp_output_params *to,
                    const struct ia_css_output_config *from,
                    unsigned int size)

>  {
>         (void)size;
>         to->enable_hflip = from->enable_hflip;
> @@ -74,7 +74,7 @@ int ia_css_output0_config(struct sh_css_isp_output_isp_config       *to,
>  }
> 
>  int ia_css_output1_config(struct sh_css_isp_output_isp_config       *to,
> -                         const struct ia_css_output1_configuration *from,
> +                         const struct ia_css_output1_configuration *from,
>                           unsigned int size)
>  {
>         return ia_css_output_config(to, (const struct ia_css_output_configuration *)from, size);
> @@ -95,7 +95,7 @@ int ia_css_output_configure(const struct ia_css_binary     *binary,
>  }
> 
>  int ia_css_output0_configure(const struct ia_css_binary    *binary,
> -                           const struct ia_css_frame_info *info)
> +                            const struct ia_css_frame_info *info)
>  {
>         if (info) {
>                 struct ia_css_output0_configuration config =
> @@ -124,10 +124,12 @@ int ia_css_output1_configure(const struct ia_css_binary     *binary,
> 
>  void
>  ia_css_output_dump(
> -    const struct sh_css_isp_output_params *output,
> -    unsigned int level)
> +       const struct sh_css_isp_output_params *output,
> +       unsigned int level)

Same way here

>  {
> -       if (!output) return;
> +       if (!output)
> +               return;
> +
>         ia_css_debug_dtrace(level, "Horizontal Output Flip:\n");
>         ia_css_debug_dtrace(level, "\t%-32s = %d\n",
>                             "enable", output->enable_hflip);
> @@ -138,8 +140,8 @@ ia_css_output_dump(
> 
>  void
>  ia_css_output_debug_dtrace(
> -    const struct ia_css_output_config *config,
> -    unsigned int level)
> +       const struct ia_css_output_config *config,
> +       unsigned int level)

Same way here

Best Regards,
Tarang

Re: [PATCH v2] staging: media: atomisp: Fix indentation and styling in output kernel code

[Tarang Raval]

> > Update formatting of function definitions and if statements to match kernel
> > coding standards. This improves readability and ensures consistency across
> > the codebase.
> > 
> > These are non-functional changes intended to address common checkpatch
> > warnings and prepare the driver for eventual mainline inclusion.
> > 
> > Signed-off-by: Darshan R. <rathod.darshan.0896@gmail.com>
> > ---
> 
> Whenever you send a new version of the patch, you should include a changelog
> below the --- line. This helps reviewers easily see what has changed from v1
> to v2.
> 
> I think the following document will be useful for you.
> Link: https://www.kernel.org/doc/Documentation/process/submitting-patches.rst
>   
> >  .../output/output_1.0/ia_css_output.host.c    | 22 ++++++++++---------
> >  1 file changed, 12 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c 
> b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
> > index d09365e0c471..4f84c6d3622a 100644
> > --- a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
> > +++ b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
> > @@ -34,9 +34,9 @@ static const struct ia_css_output1_configuration default_output1_configuration
> > 
> >  void
> >  ia_css_output_encode(
> > -    struct sh_css_isp_output_params *to,
> > -    const struct ia_css_output_config *from,
> > -    unsigned int size)
> > +       struct sh_css_isp_output_params *to,
> > +       const struct ia_css_output_config *from,
> > +       unsigned int size)
> 
> It would be better formatted like this:
> 
> void ia_css_output_encode(struct sh_css_isp_output_params *to,
> 			  const struct ia_css_output_config *from,
> 			  unsigned int size)

Sorry — the indentation got messed up in my last message, probably due to
the mail client.

Correct format:
void ia_css_output_encode(struct sh_css_isp_output_params *to,
                          const struct ia_css_output_config *from,
                          unsigned int size)

Best Regards,
Tarang