Re: [v4l-utils] [PATCH v9 3/7] Add support for meson building

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Hans,

On Tue, Feb 21, 2023 at 03:43:12PM +0100, Hans Verkuil wrote:
> On 2/21/23 15:32, Laurent Pinchart wrote:
> > From: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
> > 
> > Supports building libraries and tools found in contrib/, lib/ and
> > utils/ directories, along with the implemented gettext translations.
> > 
> > Co-developed-by: Ezequiel Garcia <ezequiel@collabora.com>
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > Acked-by: Gregor Jasny <gjasny@googlemail.com>
> > [Gregor: Control symbol visibility]
> > Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
> > Tested-by: Gregor Jasny <gjasny@googlemail.com>
> > Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> > Tested-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> > ---
> > Changes since v8:
> > 
> > - Fix LIBTRACER_PATH
> > - Update project version to 1.22.0
> 
> I don't think this is right: 1.22.0 has already been released, see the
> tags in the git repo: https://git.linuxtv.org/v4l-utils.git/
> 
> The current development version number is 1.23.0 (releases are even,
> development has odd version numbers).

Indeed, my bad. I'll fix that.

> I wonder if we shouldn't make a 1.24 stable release first without this patch
> series, then introduce meson with version 1.25. Besides, the last stable release
> was 16 months ago, so I think it is high time for a new stable anyway.

Works for me.

> Gregor, any opinion?
> 
> > - Update installation documentation to specify build directory in
> >   command lines
> > - Move '-I.' from common_arguments to v4l2_utils_incdir_arr

-- 
Regards,

Laurent Pinchart