Re: [PATCH v10 1/8] i2c: add I2C Address Translator (ATR) support

Andy Shevchenko
2023-03-17T13:44:09Z

On Fri, Mar 17, 2023 at 02:36:25PM +0200, Tomi Valkeinen wrote:
> On 17/03/2023 11:16, Luca Ceresoli wrote:
> > On Wed, 22 Feb 2023 15:29:00 +0200
> > Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> wrote:

...

> > > + /* lock for the I2C bus segment (see struct i2c_lock_operations) */
> >
> > This comment is identical to the one in the kerneldoc comments just
> > above, I'd just remove it.
>
> checkpatch wants an explicit comment for each lock.

Checkpatch is a recommendation tool and not obligation.

What it does correctly is sending message that lock should be described.
The kernel doc is good format for that, checkpatch has to gain support
for this type of lock descriptions.

> > > + struct mutex lock;

--
With Best Regards,
Andy Shevchenko