From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A76D3C43219 for ; Tue, 11 Oct 2022 09:07:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229840AbiJKJHf (ORCPT ); Tue, 11 Oct 2022 05:07:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbiJKJHe (ORCPT ); Tue, 11 Oct 2022 05:07:34 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0417E57273; Tue, 11 Oct 2022 02:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665479253; x=1697015253; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=U6Q0eqDO5XKNfPO1gS4tfAxW8aSXRLRmUbuizVaigrU=; b=KJ1hWgUoJueGsT1kB1BMADWZ8TRSmMH1lULOu9izZcMoVET1iuLdebxx Bq/AqfXXoXuXSEKosgnnknH51Z2HbEij4dZC9wezdAi2VK3Bep2nPVF5g N+oYMPF9x//YONE+dXuRmRcnpBWRPNrM4kplR4Lk/G0iV2U5ojQehGJkc JBGCcweO/x7i4UcaJS+fmuMwxlaPAI9TTobTByovbEtXa8l7QYVvoRIPs j/16B9+YqU51mJsvQG5GJGf15y15vuuDXi6gGeFejf1uk8AnPpUr9jZp+ j+Sc2fqGM5CtQFM/7AYRbHnR5fPT/Kn8NjDUzRo7wd3RU2oEbYIcPp58r A==; X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="330928651" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="330928651" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 02:07:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="871436201" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="871436201" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 11 Oct 2022 02:07:11 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oiBEA-005EiK-07; Tue, 11 Oct 2022 12:07:06 +0300 Date: Tue, 11 Oct 2022 12:07:05 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Basavaraj Natikar , Marc Zyngier , Bartosz Golaszewski , Kent Gibson , Mauro Carvalho Chehab , Billy Tsai , Thomas Gleixner , Linus Walleij , Mika Westerberg , AngeloGioacchino Del Regno , Chen-Yu Tsai , Claudiu Beznea , Samuel Holland , Horatiu Vultur , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Bjorn Andersson , Dmitry Baryshkov , Geert Uytterhoeven , Lad Prabhakar , Phil Edworthy , Krzysztof Kozlowski , Fabien Dessenne , Prathamesh Shete , Basavaraj Natikar , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-actions@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Thierry Reding , Jonathan Hunter , Patrice Chotard , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Andrew Jeffery , Joel Stanley , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Charles Keepax , Richard Fitzgerald , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Sean Wang , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Chen-Yu Tsai , Paul Cercueil , Damien Le Moal , Tony Lindgren , Haojian Zhuang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Andy Gross , Konrad Dybcio , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang , Emil Renner Berthing , Kunihiko Hayashi , Masami Hiramatsu Subject: Re: [PATCH v2 36/36] pinctrl: Clean up headers Message-ID: References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-37-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Oct 11, 2022 at 10:46:30AM +0200, Geert Uytterhoeven wrote: > On Tue, Oct 11, 2022 at 9:31 AM Basavaraj Natikar wrote: > > On 10/11/2022 1:44 AM, Andy Shevchenko wrote: > > > +++ b/drivers/pinctrl/core.h > > > -#include > > > > Removing pinconf.h from the core.h may cause build failure in other files > > because where-ever core.h is included to use “struct pinconf_ops”, there > > is a need to include pinconf.h. > > I can confirm adding > > #include > > to drivers/pinctrl/renesas/pinctrl-rzn1.c and drivers/pinctrl/pinctrl-single.c > fixes the issues I was seeing with shmobile_defconfig and (out-of-tree) > renesas_defconfig. I will add this, thank you for reporting. -- With Best Regards, Andy Shevchenko