From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2919AC4321E for ; Wed, 12 Oct 2022 13:30:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbiJLNaX (ORCPT ); Wed, 12 Oct 2022 09:30:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbiJLNaP (ORCPT ); Wed, 12 Oct 2022 09:30:15 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9270430F52; Wed, 12 Oct 2022 06:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665581413; x=1697117413; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tV/ZvJGYw4mf000OleNKwCzv+JZQjAKj+4wcxHqkOco=; b=KBAP1bzGYBopo76rIC6lrcKVeErWW3djiYCE+y19TFQ0KVRhKEKGUUwT Jh6E2QG5ET8AjdIk+8eqEoC8ELx/D8P8h7BXu12xY9y8dO/1VOOFOpa62 mT/JMANpA/P1/h6H2z7nCVvH5bfQVSW7V/W0yDt5ZhUi3zZ+HdOc8sE4U VzOf4Oy2cuyhJFvDdpnCqwu96fn1TNI32kUIx+aH00uIXh9Ps/MMFttyZ DAGQlbK9KVC4ktS9/wm0mhonD0zddiFEWckekW66H+J2efVjW+Ai8DY1u XW3q4Gzgl9WY44mfxxdAmFecGYxX5feCqFQyDASBM8tQh8qYYxYoVcTaa w==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="331285190" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="331285190" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 06:30:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="626766256" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="626766256" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 12 Oct 2022 06:30:07 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oiboD-005qlS-1e; Wed, 12 Oct 2022 16:30:05 +0300 Date: Wed, 12 Oct 2022 16:30:05 +0300 From: Andy Shevchenko To: Kent Gibson Cc: Bartosz Golaszewski , Geert Uytterhoeven , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-actions@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 02/36] gpiolib: cdev: Add missed header(s) Message-ID: References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Oct 11, 2022 at 08:01:27AM +0800, Kent Gibson wrote: > On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote: ... > > -#include > > #include > > +#include > But moving the gpio subsystem header after the gpio/driver is not > alphabetical ('.' precedes '/') and it read better and made more sense > to me the way it was. Okay, I will move it back. ... > > +#include > > I wasn't aware that we use anything from seq_file. > What am I missing? Eventually I can answer to your question: the commit 0ae3109a8391 ("gpiolib: cdev: add fdinfo output for line request file descriptors") is what you are missing. That said, we need this patch. -- With Best Regards, Andy Shevchenko