Re: [PATCH v5] media: s5k4ecgx: Switch to GPIO descriptors

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Linus,

On Mon, Oct 24, 2022 at 01:15:23PM +0200, Linus Walleij wrote:
> diff --git a/include/media/i2c/s5k4ecgx.h b/include/media/i2c/s5k4ecgx.h
> deleted file mode 100644
> index 92202eb35249..000000000000
> --- a/include/media/i2c/s5k4ecgx.h
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> -/*
> - * S5K4ECGX image sensor header file
> - *
> - * Copyright (C) 2012, Linaro
> - * Copyright (C) 2012, Samsung Electronics Co., Ltd.
> - */
> -
> -#ifndef S5K4ECGX_H
> -#define S5K4ECGX_H
> -
> -/**
> - * struct s5k4ecgx_gpio - data structure describing a GPIO
> - * @gpio: GPIO number
> - * @level: indicates active state of the @gpio
> - */
> -struct s5k4ecgx_gpio {
> -	int gpio;
> -	int level;
> -};
> -
> -/**
> - * struct s5k4ecgx_platform_data - s5k4ecgx driver platform data
> - * @gpio_reset:	 GPIO driving RESET pin
> - * @gpio_stby:	 GPIO driving STBY pin
> - */
> -
> -struct s5k4ecgx_platform_data {
> -	struct s5k4ecgx_gpio gpio_reset;
> -	struct s5k4ecgx_gpio gpio_stby;
> -};
> -
> -#endif /* S5K4ECGX_H */

If you are removing support for the platform data (since there are no
users in mainline) and the driver does not have OF support maybe it
should be removed altogether?

Thanks.

-- 
Dmitry