Re: [PATCH 04/11] media: cedrus: Add helper for checking capabilities

Dan Carpenter
2022-10-25T06:31:09Z

On Mon, Oct 24, 2022 at 10:15:08PM +0200, Jernej Skrabec wrote:
> There is several different Cedrus cores with varying capabilities, so
> some operations like listing formats depends on checks if feature is
> supported or not.
>
> Currently check for capabilities is only in format enumeration helper,
> but it will be used also elsewhere later. Let's convert this check to
> helper and while at it, also simplify it. There is no need to check if
> capability mask is zero, condition will still work properly.

Sure. That's true. Out of curiousity, can cedrus_formats[i].capabilities
be zero? Because it feels like that's what should be checked.

regards,
dan carpenter