From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Subject: Re: [PATCH v7] media: s5k4ecgx: Switch to GPIO descriptors
Date: Tue, 8 Nov 2022 09:42:38 -0800 [thread overview]
Message-ID: <Y2qVDvcDIoc1Fb0L@google.com> (raw)
In-Reply-To: <20221108121623.1510131-1-linus.walleij@linaro.org>
On Tue, Nov 08, 2022 at 01:16:23PM +0100, Linus Walleij wrote:
> The driver has an option to pass in GPIO numbers from platform
> data but this is not used in the kernel so delete this and the
> whole platform data mechanism.
>
> Get GPIO descriptors using the standard API and simplify the code,
> gpiolib will handle any inversions.
I think we should simply delete the driver. It does not currently
support OF, and I see no traces of any boards present in mainline using
it, so why to keep it?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-11-08 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 12:16 [PATCH v7] media: s5k4ecgx: Switch to GPIO descriptors Linus Walleij
2022-11-08 17:42 ` Dmitry Torokhov [this message]
2022-11-08 19:43 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2qVDvcDIoc1Fb0L@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=andrzej.hajda@intel.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tommaso.merciai@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox