From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A71C433FE for ; Sat, 12 Nov 2022 21:08:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234850AbiKLVH7 (ORCPT ); Sat, 12 Nov 2022 16:07:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230147AbiKLVH5 (ORCPT ); Sat, 12 Nov 2022 16:07:57 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F1691054B; Sat, 12 Nov 2022 13:07:51 -0800 (PST) Received: from pendragon.ideasonboard.com (d5152d7bc.static.telenet.be [81.82.215.188]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7849B8B; Sat, 12 Nov 2022 22:07:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668287268; bh=ZaYh9eHgQVK+WBWjruqSYdo/L+zdfpMZQnqTUAH2uEU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CAwBUy9Zf3Mx3HoScLoOikOy+vtQUMocS6hQ0UGekOZrGPZQwqzJnWefmZTE+EDIg B+2zQGncx8s0OTHDvT6MPt/SqBgl5aWGkEOFdHJ3lygYUtJ/tkqlRqntXh96ToDeGv HAFbl5NL8INO9d1BHrfwlTQlGkL1ozzzhP3HFmP4= Date: Sat, 12 Nov 2022 23:07:28 +0200 From: Laurent Pinchart To: Bryan O'Donoghue Cc: robert.foss@linaro.org, todor.too@gmail.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, dmitry.baryshkov@linaro.org, vladimir.zapolskiy@linaro.org, sakari.ailus@iki.fi, hverkuil@xs4all.nl, quic_mmitkov@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 5/6] arm64: dts: qcom: sm8250: camss: Define ports address/size cells Message-ID: References: <20221112172650.127280-1-bryan.odonoghue@linaro.org> <20221112172650.127280-6-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221112172650.127280-6-bryan.odonoghue@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Bryan, Thank you for the patch. On Sat, Nov 12, 2022 at 05:26:49PM +0000, Bryan O'Donoghue wrote: > The ports {} address and size cells definition is the same for every > derived 8250 board so, we should define it in the core sm8250.dtsi. You should also define the individual ports there. Endpoints are board-specific as they represent connections, but ports are intrinsic properties of the IP core integration in the SoC. > Suggested-by: Konrad Dybcio > Reviewed-by: Vladimir Zapolskiy > Signed-off-by: Bryan O'Donoghue > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index d517d6a80bdcb..f28a8893d00d7 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -3412,6 +3412,11 @@ camss: camss@ac6a000 { > "cam_hf_0_mnoc", > "cam_sf_0_mnoc", > "cam_sf_icp_mnoc"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + }; > }; > > camcc: clock-controller@ad00000 { -- Regards, Laurent Pinchart