public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: robert.foss@linaro.org, todor.too@gmail.com, agross@kernel.org,
	andersson@kernel.org, konrad.dybcio@somainline.org,
	mchehab@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, dmitry.baryshkov@linaro.org,
	vladimir.zapolskiy@linaro.org, sakari.ailus@iki.fi,
	hverkuil@xs4all.nl, quic_mmitkov@quicinc.com,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH v5 1/6] arm64: dts: qcom: sdm845-db845c: Drop redundant address-cells, size-cells declaration
Date: Sat, 12 Nov 2022 23:12:52 +0200	[thread overview]
Message-ID: <Y3AMVCfJlxyMpXrJ@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221112172650.127280-2-bryan.odonoghue@linaro.org>

Hi Bryan,

Thank you for the patch.

On Sat, Nov 12, 2022 at 05:26:45PM +0000, Bryan O'Donoghue wrote:
> sdm845.dtsi camss already defines the address-cells and size-cells for
> camss, no need to replicate in sdm845-db845c.dts.
> 
> Reported-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index 3e7ceb0861eb0..7c88312333c22 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -1185,8 +1185,6 @@ &camss {
>  	status = "ok";
>  
>  	ports {
> -		#address-cells = <1>;
> -		#size-cells = <0>;
>  		port@0 {
>  			reg = <0>;
>  			csiphy0_ep: endpoint {

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2022-11-12 21:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12 17:26 [PATCH v5 0/6] Switch on IMX577 on RB5 Bryan O'Donoghue
2022-11-12 17:26 ` [PATCH v5 1/6] arm64: dts: qcom: sdm845-db845c: Drop redundant address-cells, size-cells declaration Bryan O'Donoghue
2022-11-12 21:12   ` Laurent Pinchart [this message]
2022-11-12 17:26 ` [PATCH v5 2/6] arm64: dts: qcom: sdm845-db845c: Use okay not ok for status Bryan O'Donoghue
2022-11-12 21:14   ` Laurent Pinchart
2022-11-14  9:46   ` Konrad Dybcio
2022-11-14 10:00   ` Krzysztof Kozlowski
2022-11-12 17:26 ` [PATCH v5 3/6] arm64: dts: qcom: sdm845-db845c: Use status disabled not disable Bryan O'Donoghue
2022-11-12 21:14   ` Laurent Pinchart
2022-11-14  9:46   ` Konrad Dybcio
2022-11-14 10:01   ` Krzysztof Kozlowski
2022-11-12 17:26 ` [PATCH v5 4/6] arm64: dts: qcom: sdm845-db845c-navigation-mezzanine: Add navigation mezzanine dts Bryan O'Donoghue
2022-11-12 21:20   ` Laurent Pinchart
2022-11-12 21:46     ` Bryan O'Donoghue
2022-11-14  9:48   ` Konrad Dybcio
2022-11-14 10:01   ` Krzysztof Kozlowski
2022-11-12 17:26 ` [PATCH v5 5/6] arm64: dts: qcom: sm8250: camss: Define ports address/size cells Bryan O'Donoghue
2022-11-12 21:07   ` Laurent Pinchart
2022-11-12 17:26 ` [PATCH v5 6/6] arm64: dts: qcom: qrb5165-rb5-vision-mezzanine: Add vision mezzanine Bryan O'Donoghue
2022-11-12 21:45   ` Laurent Pinchart
2022-11-12 22:06     ` Bryan O'Donoghue
2022-11-14  9:49   ` Konrad Dybcio
2022-11-14 14:45     ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3AMVCfJlxyMpXrJ@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=hverkuil@xs4all.nl \
    --cc=konrad.dybcio@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_mmitkov@quicinc.com \
    --cc=robert.foss@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@iki.fi \
    --cc=todor.too@gmail.com \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox