From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D7FC4332F for ; Sat, 19 Nov 2022 17:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235221AbiKSRpu (ORCPT ); Sat, 19 Nov 2022 12:45:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235231AbiKSRps (ORCPT ); Sat, 19 Nov 2022 12:45:48 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 610881AD92; Sat, 19 Nov 2022 09:45:47 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C1B09749; Sat, 19 Nov 2022 18:45:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668879946; bh=Pub3niZDGi+TZSFRiO3u9PNhZsYR4f+5+Yth2wlyHhM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Plm5aFeDDeX98yC484lpdzNsalDG7h5piuZxCSTfwSvg7mkOI3lIEu0pF9KB582NN IAMFGJQh0aj/Qc0pjlFvCOmyvGTX2DWBoIjfoMjHOEzQimYdXbjMQQdw1VpsXnBaQk OuThf9jli9AJBOetWt7Q9NqO96k8f6lvUtiCYr2I= Date: Sat, 19 Nov 2022 19:45:30 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Mauro Carvalho Chehab , Peter Rosin , Heikki Krogerus , Greg Kroah-Hartman , linux-i2c@vger.kernel.org, kernel@pengutronix.de, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 348/606] media: i2c/ml86v7667: Convert to i2c's .probe_new() Message-ID: References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-349-uwe@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221118224540.619276-349-uwe@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Nov 18, 2022 at 11:41:22PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/ml86v7667.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/ml86v7667.c b/drivers/media/i2c/ml86v7667.c > index 49ec59b0ca43..dbd2f0bd3651 100644 > --- a/drivers/media/i2c/ml86v7667.c > +++ b/drivers/media/i2c/ml86v7667.c > @@ -359,8 +359,7 @@ static int ml86v7667_init(struct ml86v7667_priv *priv) > return ret; > } > > -static int ml86v7667_probe(struct i2c_client *client, > - const struct i2c_device_id *did) > +static int ml86v7667_probe(struct i2c_client *client) > { > struct ml86v7667_priv *priv; > int ret; > @@ -434,7 +433,7 @@ static struct i2c_driver ml86v7667_i2c_driver = { > .driver = { > .name = DRV_NAME, > }, > - .probe = ml86v7667_probe, > + .probe_new = ml86v7667_probe, > .remove = ml86v7667_remove, > .id_table = ml86v7667_id, > }; > -- > 2.38.1 > -- Regards, Laurent Pinchart