From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EEFBC4708C for ; Tue, 6 Dec 2022 02:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232537AbiLFCNG (ORCPT ); Mon, 5 Dec 2022 21:13:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232604AbiLFCMx (ORCPT ); Mon, 5 Dec 2022 21:12:53 -0500 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E83018356 for ; Mon, 5 Dec 2022 18:12:52 -0800 (PST) Received: by mail-pf1-x42e.google.com with SMTP id d82so4466777pfd.11 for ; Mon, 05 Dec 2022 18:12:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c14cpbENCYZNKC7u3nvm/pV+pN6D09fmQR9Vg77kP7E=; b=Puf5KmAloTMG82ul7mVb3DjfNsyo5ylLf2c86JaNIj0DRSwnbqyT5dFPV5PV62+JZv bWODrmKHzlDHCPGWqUP5k+aupZxoY6qnjBb/JMpfwTeSmalwdqJjDqS6pGSwICU2I0PE IvvvpZHbv68ZWDXW/N+OQrvHMtrHx98Ghjdz4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c14cpbENCYZNKC7u3nvm/pV+pN6D09fmQR9Vg77kP7E=; b=YLzPq1GYI42S2YBBOdg/LoWDJMQDb+GoDSm+2mS6fom8UV5q64JSsV+AK/N5NOyiQc 16h1HKFrvSCesKbE7UJvjWFCfhsztSjTOB9Rhki+CJOqlMsIfeL/5Xs9UXExNkgvjpvn kddBc+JnA+VTF2HiZS4ep02eRVGfN81AYQfayy4//hxthP+0EzGrTVUou0mv9omFbKiz heNXHMXd/pPvhzb/AttqD2GIov3XRAHyPSUBaS815VcneuClPAaegXhPw3bSKe0djbaI j95JT2FeChnVW/GOnpmqkaeX0tiIg/uL7nHINzcot/g1p8JnqcUjRfBc7S1lJuzj7BQg iH+A== X-Gm-Message-State: ANoB5pkCurLUAJX2z44e1Ab5T0pFoBqn6zhbDFUiKAAKqUJP+OVagH2y 9iw/HtvzT+kEDEpSAM/lO0WOsw== X-Google-Smtp-Source: AA0mqf6aQacPSyfFiQzOm8CXVaSz1VIVy23ZQ5+/FZE57I15VEUSYLEjwQxOATQTdC4VkXC8I9/f5Q== X-Received: by 2002:a63:c46:0:b0:476:ed2a:6228 with SMTP id 6-20020a630c46000000b00476ed2a6228mr60063696pgm.137.1670292771791; Mon, 05 Dec 2022 18:12:51 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id u6-20020a170902e80600b0017849a2b56asm11337097plg.46.2022.12.05.18.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 18:12:51 -0800 (PST) Date: Tue, 6 Dec 2022 11:12:46 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, Yunke Cao , Max Staudt , Hans Verkuil , Laurent Pinchart , Tomasz Figa , Guenter Roeck , Sergey Senozhatsky , Alan Stern , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] media: uvcvideo: Refactor streamon/streamoff Message-ID: References: <20220920-resend-powersave-v4-0-47484ae40761@chromium.org> <20220920-resend-powersave-v4-1-47484ae40761@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920-resend-powersave-v4-1-47484ae40761@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On (22/12/02 18:19), Ricardo Ribalda wrote: > @@ -840,13 +840,19 @@ static int uvc_ioctl_streamon(struct file *file, void *fh, [..] > + handle->is_streaming = !ret; > @@ -857,15 +863,22 @@ static int uvc_ioctl_streamoff(struct file *file, void *fh, [..] > + handle->is_streaming = !!ret; Had uvc_ioctl_streamABC() be 3 functions we would have seen handle->is_streaming = !!!ret; :) [..] A nit: > struct uvc_fh { > struct v4l2_fh vfh; > + bool is_streaming; That's a lot of padding. > struct uvc_video_chain *chain; > struct uvc_streaming *stream; > enum uvc_handle_state state; I guess is_streaming better be next to enum uvc_handle_state, in which case is_streaming should not change sizeof(uvc_fh) (at least so on 64-bit).