From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACBBFC4332F for ; Fri, 25 Nov 2022 14:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230021AbiKYOkm (ORCPT ); Fri, 25 Nov 2022 09:40:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbiKYOkl (ORCPT ); Fri, 25 Nov 2022 09:40:41 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20BD6326F6; Fri, 25 Nov 2022 06:40:40 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 36E25496; Fri, 25 Nov 2022 15:40:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669387238; bh=0bnjZSYznGywN/B8Q+QDx8ueVlaptdItSScK7DR+rfM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LjbzNtFcie9qDAnfR3e6TjEWJewfY2JUbUtROQ7jnfRoMbgGEdxZI4Zq4gnjTX7ug FTB3Gn/QaShPvuvWQmeJazEDv9CUdioLr45/prJrjIRA95mLaWvtm2YJjPCGQGv6Mn Yd8fntuInqF9mx6N8RKoaaFjn9OQHU2x8Rx6b4lE= Date: Fri, 25 Nov 2022 16:40:22 +0200 From: Laurent Pinchart To: Hans de Goede Cc: Mark Gross , Andy Shevchenko , Daniel Scally , platform-driver-x86@vger.kernel.org, Sakari Ailus , Kate Hsuan , linux-media@vger.kernel.org Subject: Re: [PATCH 0/3] platform/x86: int3472/discrete: Make it work with IPU6 Message-ID: References: <20221124200007.390901-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221124200007.390901-1-hdegoede@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Nov 24, 2022 at 09:00:04PM +0100, Hans de Goede wrote: > Hi All, > > Here is a small set of patches to make the int3472/discrete code > work with the sensor drivers bundled with the (unfortunately out of tree) > IPU6 driver. > > There are parts of the out of tree IPU6 code, like the sensor drivers, > which can be moved to the mainline and I do plan to work on this at some > point and then some of this might need to change. But for now the goal is > to make the out of tree driver work with standard mainline distro kernels > through e.g. dkms. Otherwise users need to run a patched kernel just for > a couple of small differences. > > This is basically a rewrite of this patch: > https://github.com/intel/ipu6-drivers/blob/master/patch/int3472-support-independent-clock-and-LED-gpios-5.17%2B.patch > > Wich users who want to use the IPU6 driver so far have had to manually > apply to their kernels which is quite inconvenient. > > This rewrite makes 2 significant changes: > > 1. Don't break things on IPU3 platforms > > 2. Instead of extending the int3472_sensor_configs[] quirks table for each > model which needs "clken" and "pled" GPIOs, do this based on matching > the ACPI HID of the ACPI device describing the sensor. How can we be sure that a given sensor model will always be wired to the same GPIOs on all platforms that integrate it with an IPU6 (or IPU3) ? > The need for these GPIOs is a property of the specific sensor driver which > binds using this same HID, so by using this we avoid having to extend the > int3472_sensor_configs[] quirks table all the time. > > This allows roling back the behavior to at least use a clk-framework > clk instead of clken GPIO on a per sensor(-driver) basis as we mainline > the sensor drivers, assuming that the drivers are switched over to the > clk framework as part of their mainlining. > > A bigger question is what to do with the privacy-led GPIO on IPU3 > we so far have turned the LED on/off at the same as te clock, > but at least on some IPU6 models this won't work, because they only > have a privacy-led GPIO and no clk_en GPIO (there is no sensor > clk-control at all on some models). Can we turn it on at the same time as the power then ? > I think we should maybe move all models, including IPU3 based > models over to using a normal GPIO for controlling the privacy-led > to make things consistent. > > And likewise (eventually) completely drop the "clken" GPIO this > patch series introduces (with some sensors) and instead always model > this through the clk-framework. > > Regards, > > Hans > > > Hans de Goede (3): > platform/x86: int3472/discrete: Refactor GPIO to sensor mapping > platform/x86: int3472/discrete: Get the polarity from the _DSM entry > platform/x86: int3472/discrete: Add support for sensor-drivers which > expect clken + pled GPIOs > > drivers/platform/x86/intel/int3472/common.h | 2 +- > drivers/platform/x86/intel/int3472/discrete.c | 92 ++++++++++++++++--- > 2 files changed, 78 insertions(+), 16 deletions(-) -- Regards, Laurent Pinchart