From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3172C43219 for ; Fri, 25 Nov 2022 15:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229753AbiKYPGF (ORCPT ); Fri, 25 Nov 2022 10:06:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiKYPGE (ORCPT ); Fri, 25 Nov 2022 10:06:04 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C23EF27B0C for ; Fri, 25 Nov 2022 07:06:01 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id f7so6755898edc.6 for ; Fri, 25 Nov 2022 07:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=melexis.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fvqdmTUWT2xrEs7EUWyBWddANF1nz9rdB64JipOk+bQ=; b=cKJf3Bor2OFyZBLIh0WUIq1HVFaLOp8T+qsYxprqyKEje6jbdKS5tr0Ispl0lzki8+ eO68hXpM864fW6bAHaGIIHbdBl+uDyfgnL87ijgZ0DBK3SD9/pOoHp2jkm3hQn15VHpC XUR5sIORuhBpojVHBk/MUzudQmIVFofNi27nD1iWr69LbR/BQ+mmfdEpaE8IJPTVEU5v MLETBzIGr5VyEpxcNIlgalItSWgl+ppASZxNcVR9Gslse7i7ndlxZCNljDX4zT5/pAJi 6kJZyMPFHp8zZT/DGaIG5YQAVbUsNm59+5UAJWwuXz4Nv5Eel01AxYo6yRLkzUde6e4r nhGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fvqdmTUWT2xrEs7EUWyBWddANF1nz9rdB64JipOk+bQ=; b=7Mtts4yFZ8ogdyCYoqZhbSlYAcbVEZaPsjZ79rwPvMIRoax4220s6RLCCMSuiQ3tOa HES45mwWl1EdnprKupuJ5ikmQFroXg56rOOnTa5ofaFetKUOK25Q0ZES6BdU0biJqXbq imGQWq2Gvd6P5+109KUycXVgESlJqywNQhhzrJ2qkTp58eqZPiWO9QJISouuL6+2a1A4 ZU3qvJGnwoU6cver9g6YWKaXYlw+ydca0HK4Am9li78xUmr4rWyZqwgm2jGPaBMPHU5T oE97CDJCiPJ9UiekVLBSuqHPyofEEeIlIOLFVGfPdi44jQfOdmi4jcA1R6ZznwDTsz08 bbcw== X-Gm-Message-State: ANoB5ploxg7qshtqKcdSjkDTretKWLqK+FUxa5+MtL4tqzza56Xjxd9z unuvQf0ewpzL9xIMnp6T6AZ8jg== X-Google-Smtp-Source: AA0mqf7jgt3PeWxJilXyfbPsUkqudms+cGCl/vYbtk8bV0e8nB2mna5DtYQj/DkP+VgItJb8UpTsZg== X-Received: by 2002:aa7:c6da:0:b0:469:172:1f38 with SMTP id b26-20020aa7c6da000000b0046901721f38mr33411953eds.195.1669388760077; Fri, 25 Nov 2022 07:06:00 -0800 (PST) Received: from melexis.com ([2a02:2378:1085:b41d:bec4:93fd:8998:6d7a]) by smtp.gmail.com with ESMTPSA id f24-20020a170906495800b007bb32e2d6f5sm1637452ejt.207.2022.11.25.07.05.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 07:05:59 -0800 (PST) Date: Fri, 25 Nov 2022 17:05:55 +0200 From: Volodymyr Kharuk To: Hans Verkuil Cc: linux-media@vger.kernel.org, Andrii Kyselov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Laurent Pinchart , devicetree@vger.kernel.org, Sakari Ailus , Benjamin Mugnier Subject: Re: [PATCH v3 1/8] media: uapi: ctrls: Add Time of Flight class controls Message-ID: References: <8819951fe1bb25501ab88e00bcf8e76734e97663.1669381013.git.vkh@melexis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Hans, Thanks for your review, On Fri, Nov 25, 2022 at 03:20:46PM +0100, Hans Verkuil wrote: > On 25/11/2022 14:34, Volodymyr Kharuk wrote: > > Define Time of Flight class controls. > > Also add most common TOF controls: > > - phase sequence > > - time integration > > - frequency modulation > > > > Signed-off-by: Volodymyr Kharuk > > --- > > include/uapi/linux/v4l2-controls.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > > index d27e255ed33b..a9ecfaa4252c 100644 > > --- a/include/uapi/linux/v4l2-controls.h > > +++ b/include/uapi/linux/v4l2-controls.h > > @@ -68,6 +68,7 @@ > > #define V4L2_CTRL_CLASS_DETECT 0x00a30000 /* Detection controls */ > > #define V4L2_CTRL_CLASS_CODEC_STATELESS 0x00a40000 /* Stateless codecs controls */ > > #define V4L2_CTRL_CLASS_COLORIMETRY 0x00a50000 /* Colorimetry controls */ > > +#define V4L2_CTRL_CLASS_TOF 0x00a60000 /* Time of light camera controls */ > > light -> flight oh, indeed. Will fix. > > > > > /* User-class control IDs */ > > > > @@ -2782,6 +2783,13 @@ struct v4l2_ctrl_vp9_compressed_hdr { > > struct v4l2_vp9_mv_probs mv; > > }; > > > > +#define V4L2_CID_TOF_CLASS_BASE (V4L2_CTRL_CLASS_TOF | 0x900) > > +#define V4L2_CID_TOF_CLASS (V4L2_CTRL_CLASS_TOF | 1) > > + > > +#define V4L2_CID_TOF_PHASE_SEQ (V4L2_CID_TOF_CLASS_BASE + 0) > > +#define V4L2_CID_TOF_FMOD (V4L2_CID_TOF_CLASS_BASE + 1) > > I'd go for _FREQ_MOD Ok. Will fix. > > > +#define V4L2_CID_TOF_TINT (V4L2_CID_TOF_CLASS_BASE + 2) > > and _TIME_INTEGRATION Ok. Will fix. > > Regards, > > Hans > > > + > > /* MPEG-compression definitions kept for backwards compatibility */ > > #ifndef __KERNEL__ > > #define V4L2_CTRL_CLASS_MPEG V4L2_CTRL_CLASS_CODEC > -- -- BR, Volodymyr Kharuk