From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A3CC433FE for ; Mon, 28 Nov 2022 13:47:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232116AbiK1NrG (ORCPT ); Mon, 28 Nov 2022 08:47:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232033AbiK1Nqy (ORCPT ); Mon, 28 Nov 2022 08:46:54 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6810FD2E0 for ; Mon, 28 Nov 2022 05:46:50 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 216BA501; Mon, 28 Nov 2022 14:46:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669643208; bh=MOttAXrr6MdUr1QZh+CpIjsgv5Y3bsk9jW/lcridt/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vv4iXuZVvIN7oXQ/Xc5R7uXNv70YtFsjld6R4uRxGDSbTYK6w1JvxXWNnnQboIm97 0HYM3VP5HlvP4oh4Q4OAX5RE84chPo/IH+JTjoS4EK1XeoJBmYx6D3PdfUXMbqr2iE X/noWWjtJGyXTf/t+jU50Pcd7ccGrItVja+hlt5o= Date: Mon, 28 Nov 2022 15:46:33 +0200 From: Laurent Pinchart To: Kieran Bingham Cc: Petko Manolov , linux-media@vger.kernel.org, sakari.ailus@iki.fi Subject: Re: [PATCH v1 0/5] Adds media driver for Sony IMX492 sensor Message-ID: References: <20221125153120.541298-1-petko.manolov@konsulko.com> <166963953216.1079859.6469563044691422088@Monstersaurus> <166964269270.1079859.9052080973667851964@Monstersaurus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <166964269270.1079859.9052080973667851964@Monstersaurus> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Nov 28, 2022 at 01:38:12PM +0000, Kieran Bingham wrote: > Quoting Petko Manolov (2022-11-28 13:11:39) > > On 22-11-28 12:45:32, Kieran Bingham wrote: > > > Hi Petko, > > > > > > What device/ISP are you testing this sensor on? > > > > I'll tell you, but only if you promise to not laugh too much. Deal? > > > > i.MX8M-Mini > > > > I hope nobody will notice the above line... > > I won't laugh at all. We've just merged the ISI pipeline handler for > libcamera, which should let you use libcamera on this target (I think). The i.MX8MM doesn't have an ISI. The i.MX8MN does, but with a single pipeline, so it won't work out of the box with libcamera, but it should be easy to support it. The i.MX8MM has a CSI bridge (CSI stands for CMOS Sensor Interface there, it's a DMA engine, not to be confused with the CSI-2 receiver) which should work with the simple pipeline handler. > I would hope sometime in the future you'd be able to use the ISI > pipeline handler with a GPU based ISP with this sensor too. > > How are you managing the image 3a? the imx492 is a raw sensor isn't it ? > > > > Quoting Petko Manolov (2022-11-25 15:31:15) > > > > This patch adds dt-bindings documentation, driver source, etc for Sony imx492 > > > > image sensor. > > > > > > > > imx492 is a diagonal 23.1 mm (Type 1.4) CMOS image sensor with color or > > > > monochrome square pixel array and approximately 47.08 M effective pixels. 12-bit > > > > digital output makes it possible to output the signals with high definition for > > > > moving pictures. It is programmable through I2C interface. The I2C client > > > > address can be either 0x10 or 0x1a depending on SLASEL pin. Image data is sent > > > > through MIPI CSI-2. > > > > > > > > Petko Manolov (5): > > > > DT bindings for imx492 > > > > media: i2c: imx492: driver's header > > > > media: i2c: imx492: driver's source > > > > media: i2c: add imx492 config entry > > > > media: i2c: add imx492 entry for make > > > > > > Could you squash patches 2, 3, 4, and 5 into a single patch please? > > > > This is the exact opposite to what the networking folks would prefer, but it's > > OK with me. > > Haha ... yes - isn't it great working in mulitple subsystems.... > > > > Also - I think you'll need an entry in MAINTAINERS. > > > > Right, that one too. > > > > > I can't see any reference to the selection controls: > > > - V4L2_SEL_TGT_CROP_DEFAULT > > > - V4L2_SEL_TGT_CROP > > > - V4L2_SEL_TGT_CROP_BOUNDS > > > > These are in a very early phase of implementing. > > Ok > > > > Do you have the datasheet or sufficient information to be able to implement > > > these controls? > > > > Of course not. We are brute forcing our way forward by mostly reverse > > engineering another solution that has an FPGA on the other end of the CSI link. > > Understood ;-) (and ... I think what I was fearing/anticipating). > > > > > .../bindings/media/i2c/sony,imx492.yaml | 101 ++ > > > > drivers/media/i2c/Kconfig | 14 + > > > > drivers/media/i2c/Makefile | 1 + > > > > drivers/media/i2c/imx492.c | 1092 +++++++++++++++++ > > > > drivers/media/i2c/imx492.h | 555 +++++++++ > > > > 5 files changed, 1763 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx492.yaml > > > > create mode 100644 drivers/media/i2c/imx492.c > > > > create mode 100644 drivers/media/i2c/imx492.h -- Regards, Laurent Pinchart